linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kaixuxia <xiakaixu1987@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
	Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v5 1/3] xfs: delete duplicated tp->t_dqinfo null check and allocation
Date: Fri, 16 Oct 2020 10:57:15 +0800	[thread overview]
Message-ID: <4c9cf4f2-c349-fdb2-90c0-e73beda0ff8f@gmail.com> (raw)
In-Reply-To: <20201015082245.GA3583@infradead.org>



On 2020/10/15 16:22, Christoph Hellwig wrote:
> On Sat, Oct 10, 2020 at 10:54:19AM +0800, xiakaixu1987@gmail.com wrote:
>> From: Kaixu Xia <kaixuxia@tencent.com>
>>
>> The function xfs_trans_mod_dquot_byino() wrap around xfs_trans_mod_dquot()
> 
> s/wrap/wraps/
> 
> Also this line is too long for commit messages.
> 
>>
>> to account for quotas, and also there is the function call chain
>> xfs_trans_reserve_quota_bydquots -> xfs_trans_dqresv -> xfs_trans_mod_dquot,
> 
> This one as well.

Yeah, I'll fix them in the next version.

Thanks,
Kaixu
> 
> Otherwise this looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 

-- 
kaixuxia

  reply	other threads:[~2020-10-16  2:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10  2:54 [PATCH v5 0/3] xfs: random fixes for disk quota xiakaixu1987
2020-10-10  2:54 ` [PATCH v5 1/3] xfs: delete duplicated tp->t_dqinfo null check and allocation xiakaixu1987
2020-10-15  8:22   ` Christoph Hellwig
2020-10-16  2:57     ` kaixuxia [this message]
2020-10-10  2:54 ` [PATCH v5 2/3] xfs: check tp->t_dqinfo value instead of the XFS_TRANS_DQ_DIRTY flag xiakaixu1987
2020-10-15  8:23   ` Christoph Hellwig
2020-10-10  2:54 ` [PATCH v5 3/3] xfs: directly return if the delta equal to zero xiakaixu1987
2020-10-15  8:25   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c9cf4f2-c349-fdb2-90c0-e73beda0ff8f@gmail.com \
    --to=xiakaixu1987@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=hch@infradead.org \
    --cc=kaixuxia@tencent.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).