Bug#695875: Build with libedit rather than libreadline5

Bug#695875: Build with libedit rather than libreadline5

[Bastian Germann]

Please let the package build-depend on libedit-dev rather than the
orphaned libreadline-gplv2-dev. It is supported by upstream and its
license is compatible.

The configure option --enable-readline=yes would have to be changed to
--enable-editline=yes.

Bug#695875: [PATCH] Build with libedit rather than readline (Closes: #695875)

[bage]

From: Bastian Germann <bage@linutronix.de>

---
 debian/control | 2 +-
 debian/rules   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 0b3205f..ddd1785 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
 Priority: optional
 Maintainer: XFS Development Team <linux-xfs@vger.kernel.org>
 Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, dh-python, pkg-config
+Build-Depends: uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libedit-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, dh-python, pkg-config
 Standards-Version: 4.0.0
 Homepage: https://xfs.wiki.kernel.org/
 
diff --git a/debian/rules b/debian/rules
index e8509fb..7304222 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,7 +25,7 @@ stdenv = @GZIP=-q; export GZIP;
 
 options = export DEBUG=-DNDEBUG DISTRIBUTION=debian \
 	  INSTALL_USER=root INSTALL_GROUP=root \
-	  LOCAL_CONFIGURE_OPTIONS="--enable-readline=yes --enable-blkid=yes --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto" ;
+	  LOCAL_CONFIGURE_OPTIONS="--enable-editline=yes --enable-blkid=yes --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto" ;
 diopts  = $(options) \
 	  export OPTIMIZER=-Os LOCAL_CONFIGURE_OPTIONS="--enable-gettext=no --disable-ubsan --disable-addrsan --disable-threadsan --enable-lto" ;
 checkdir = test -f debian/rules
-- 
2.25.1

Bug#695875: marked as done (Build with libedit rather than libreadline5)

[Debian Bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

Your message dated Tue, 19 Jan 2021 23:30:59 +0100
with message-id <a2e94dea-73f1-ca64-8426-bd4e65864e44@fishpost.de>
and subject line Done: Build with libedit rather than libreadline5
has caused the Debian Bug report #695875,
regarding Build with libedit rather than libreadline5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
695875: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695875
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 2479 bytes --]

From: Nick Black <nick.black@sprezzatech.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: xfsprogs: Build-Depend on libreadline6 rather than libreadline5
Date: Thu, 13 Dec 2012 16:27:30 -0500
Message-ID: <20121213212730.25675.16201.reportbug@localhost>

Package: xfsprogs
Version: 3.1.9
Severity: normal
Tags: patch

Dear Maintainer,

Hello! During development of SprezzOS, I noticed that the xfsprogs
package Build-Depends on

	     libreadline-gplv2-dev | libreadline5-dev

libreadline5-dev no longer exists in the archive; the current
implementation is libreadline6-dev. Please make this change, so that
machines with libreadline6-dev installed can build the package.

-- System Information:
Debian Release: turing-β/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.7.0 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages xfsprogs depends on:
ii  libblkid1     2.22.1-SprezzOS3
ii  libc6         2.13-37
ii  libreadline5  5.2-12
ii  libuuid1      2.22.1-SprezzOS3

xfsprogs recommends no packages.

Versions of packages xfsprogs suggests:
ii  acl      2.2.51-8
pn  attr     <none>
pn  quota    <none>
pn  xfsdump  <none>

-- no debconf information

[-- Attachment #3: Type: message/rfc822, Size: 3740 bytes --]

From: Bastian Germann <bastiangermann@fishpost.de>
To: 695875-done@bugs.debian.org
Subject: Done: Build with libedit rather than libreadline5
Date: Tue, 19 Jan 2021 23:30:59 +0100
Message-ID: <a2e94dea-73f1-ca64-8426-bd4e65864e44@fishpost.de>

Source: xfsprogs
Source-Version: 5.10.0-2