[PATCH] i2c-cpm: Suppress autoprobing for devices

[PATCH] i2c-cpm: Suppress autoprobing for devices

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]


Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
automatic probing for this i2c controller. Might need updates to dts files
using it.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 drivers/i2c/busses/i2c-cpm.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6/drivers/i2c/busses/i2c-cpm.c
===================================================================
--- linux-2.6.orig/drivers/i2c/busses/i2c-cpm.c
+++ linux-2.6/drivers/i2c/busses/i2c-cpm.c
@@ -423,7 +423,6 @@ static const struct i2c_adapter cpm_ops 
 	.owner		= THIS_MODULE,
 	.name		= "i2c-cpm",
 	.algo		= &cpm_i2c_algo,
-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
 };
 
 static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)
-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] i2c-cpm: Suppress autoprobing for devices

[Jochen Friedrich]

Wolfram Sang schrieb:
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> automatic probing for this i2c controller. Might need updates to dts files
> using it.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Jochen Friedrich <jochen@scram.de>

Re: [PATCH] i2c-cpm: Suppress autoprobing for devices

[Kumar Gala]

On Oct 16, 2008, at 6:13 AM, Wolfram Sang wrote:

>
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also  
> remove
> automatic probing for this i2c controller. Might need updates to dts  
> files
> using it.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-cpm.c |    1 -
> 1 file changed, 1 deletion(-)

The i2c list should be CC'd.  Jean should pick this up.

- k

Re: [PATCH] [RESEND] i2c-cpm: Suppress autoprobing for devices

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
automatic probing for this i2c controller. Might need updates to dts files
using it.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Jochen Friedrich <jochen@scram.de>
---
Resend with cc to i2c.

 drivers/i2c/busses/i2c-cpm.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6/drivers/i2c/busses/i2c-cpm.c
===================================================================
--- linux-2.6.orig/drivers/i2c/busses/i2c-cpm.c
+++ linux-2.6/drivers/i2c/busses/i2c-cpm.c
@@ -423,7 +423,6 @@ static const struct i2c_adapter cpm_ops 
 	.owner		= THIS_MODULE,
 	.name		= "i2c-cpm",
 	.algo		= &cpm_i2c_algo,
-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
 };
 
 static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] i2c-cpm: Suppress autoprobing for devices

[David Miller]

From: Kumar Gala <galak@kernel.crashing.org>
Date: Thu, 16 Oct 2008 11:09:30 -0500

> 
> On Oct 16, 2008, at 6:13 AM, Wolfram Sang wrote:
> 
> >
> > Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> > automatic probing for this i2c controller. Might need updates to dts files
> > using it.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > ---
> > drivers/i2c/busses/i2c-cpm.c |    1 -
> > 1 file changed, 1 deletion(-)
> 
> The i2c list should be CC'd.  Jean should pick this up.

Don't bother, he'll just argue with you about the fact that class
based probing should be maintained.

He's doing exactly that with me right now.

I think the powerpc folks are doing exactly the right thing by merging
their I2C changes directly to Linus.  Please just continue doing this.

That's what I should have done with my sparc stuff, I'm being punished
now for having sent my changes to "the right place". :-/

Re: [PATCH] i2c-cpm: Suppress autoprobing for devices

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On Thu, Oct 16, 2008 at 12:23:25PM -0700, David Miller wrote:

> Don't bother, he'll just argue with you about the fact that class
> based probing should be maintained.
> 
> He's doing exactly that with me right now.

I think the two of you talked at cross purposes. Just observing, I can
follow his point, that you can easily switch probing off in the driver
(like Wolfgang Grandegger's and my patch does), so there is no need to
sacrifice some functionality of a whole algorithm. Just clear the
.class-entry in your driver and there should be peace ;)

All the best,

   Wolfram

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] [RESEND] i2c-cpm: Suppress autoprobing for devices

[Jean Delvare]

Hi Wolfram,

On Thu, 16 Oct 2008 21:12:00 +0200, Wolfram Sang wrote:
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> automatic probing for this i2c controller. Might need updates to dts files
> using it.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Acked-by: Jochen Friedrich <jochen@scram.de>
> ---
> Resend with cc to i2c.
> 
>  drivers/i2c/busses/i2c-cpm.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-2.6/drivers/i2c/busses/i2c-cpm.c
> ===================================================================
> --- linux-2.6.orig/drivers/i2c/busses/i2c-cpm.c
> +++ linux-2.6/drivers/i2c/busses/i2c-cpm.c
> @@ -423,7 +423,6 @@ static const struct i2c_adapter cpm_ops 
>  	.owner		= THIS_MODULE,
>  	.name		= "i2c-cpm",
>  	.algo		= &cpm_i2c_algo,
> -	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
>  };
>  
>  static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm)

Acked-by: Jean Delvare <khali@linux-fr.org>

I guess you do _not_ want me to push this patch upstream now and it
better goes through the powerpc tree to allow a synchronization with
dts file changes?

If I'm wrong and you want me to take this patch in my tree then please
tell me.

-- 
Jean Delvare

Re: [PATCH] [RESEND] i2c-cpm: Suppress autoprobing for devices

[Kumar Gala]

On Oct 16, 2008, at 2:12 PM, Wolfram Sang wrote:

> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also  
> remove
> automatic probing for this i2c controller. Might need updates to dts  
> files
> using it.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Acked-by: Jochen Friedrich <jochen@scram.de>
> ---
> Resend with cc to i2c.
>
> drivers/i2c/busses/i2c-cpm.c |    1 -
> 1 file changed, 1 deletion(-)

applied

- k