* [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return
@ 2017-03-10 11:57 Vipin K Parashar
2017-03-30 17:41 ` Vipin K Parashar
2017-03-31 12:33 ` [v4] " Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Vipin K Parashar @ 2017-03-10 11:57 UTC (permalink / raw)
To: linuxppc-dev; +Cc: stewart, Vipin K Parashar
OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
in opal_get_sensor_data() for sensor read failure with
OPAL_WRONG_STATE return code and returned -EIO.
Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
---
Changes in v4:
- Removed sleeping core log message with KERN_NOTICE priority.
Changes in v3:
- Added a new case for OPAL_WRONG_STATE in sensor read
along with a log message indicating sleeping/offline core
causing read fail.
arch/powerpc/platforms/powernv/opal-sensor.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c b/arch/powerpc/platforms/powernv/opal-sensor.c
index 308efd1..aa267f1 100644
--- a/arch/powerpc/platforms/powernv/opal-sensor.c
+++ b/arch/powerpc/platforms/powernv/opal-sensor.c
@@ -64,6 +64,10 @@ int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data)
*sensor_data = be32_to_cpu(data);
break;
+ case OPAL_WRONG_STATE:
+ ret = -EIO;
+ break;
+
default:
ret = opal_error_code(ret);
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return
2017-03-10 11:57 [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return Vipin K Parashar
@ 2017-03-30 17:41 ` Vipin K Parashar
2017-03-31 12:33 ` [v4] " Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Vipin K Parashar @ 2017-03-30 17:41 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, stewart
Hi Michael,
Any feedback/outlook with this patch ?
Regards,
Vipin
On Friday 10 March 2017 05:27 PM, Vipin K Parashar wrote:
> OPAL returns OPAL_WRONG_STATE upon failing to provide
> sensor data due to core sleeping/offline. Added check
> in opal_get_sensor_data() for sensor read failure with
> OPAL_WRONG_STATE return code and returned -EIO.
>
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
> ---
> Changes in v4:
> - Removed sleeping core log message with KERN_NOTICE priority.
>
> Changes in v3:
> - Added a new case for OPAL_WRONG_STATE in sensor read
> along with a log message indicating sleeping/offline core
> causing read fail.
>
> arch/powerpc/platforms/powernv/opal-sensor.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c b/arch/powerpc/platforms/powernv/opal-sensor.c
> index 308efd1..aa267f1 100644
> --- a/arch/powerpc/platforms/powernv/opal-sensor.c
> +++ b/arch/powerpc/platforms/powernv/opal-sensor.c
> @@ -64,6 +64,10 @@ int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data)
> *sensor_data = be32_to_cpu(data);
> break;
>
> + case OPAL_WRONG_STATE:
> + ret = -EIO;
> + break;
> +
> default:
> ret = opal_error_code(ret);
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v4] powernv/sensor: Handle OPAL_WRONG_STATE error return
2017-03-10 11:57 [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return Vipin K Parashar
2017-03-30 17:41 ` Vipin K Parashar
@ 2017-03-31 12:33 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2017-03-31 12:33 UTC (permalink / raw)
To: Vipin K Parashar, linuxppc-dev; +Cc: stewart, Vipin K Parashar
On Fri, 2017-03-10 at 11:57:32 UTC, Vipin K Parashar wrote:
> OPAL returns OPAL_WRONG_STATE upon failing to provide
> sensor data due to core sleeping/offline. Added check
> in opal_get_sensor_data() for sensor read failure with
> OPAL_WRONG_STATE return code and returned -EIO.
>
> Signed-off-by: Vipin K Parashar <vipin@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/17bb69515c6dfbe282e8a9df08ffb7
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-31 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 11:57 [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return Vipin K Parashar
2017-03-30 17:41 ` Vipin K Parashar
2017-03-31 12:33 ` [v4] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).