From: David Laight <David.Laight@ACULAB.COM>
To: 'David Hildenbrand' <dahi@linux.vnet.ibm.com>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"paulus@samba.org" <paulus@samba.org>,
"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: RE: [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic
Date: Thu, 27 Nov 2014 16:27:50 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1C9FDDD6@AcuExch.aculab.com> (raw)
In-Reply-To: <20141127164555.4bcebfe8@thinkpad-w530>
From: David Hildenbrand [mailto:dahi@linux.vnet.ibm.com]
> > From: David Hildenbrand
> > ...
> > > Although it might not be optimal, but keeping a separate counter for
> > > pagefault_disable() as part of the preemption counter seems to be the=
only
> > > doable thing right now. I am not sure if a completely separated count=
er is even
> > > possible, increasing the size of thread_info.
> >
> > What about adding (say) 0x10000 for the more restrictive test?
> >
> > David
> >
>=20
> You mean as part of the preempt counter?
>=20
> The current layout (on my branch) is
>=20
> * PREEMPT_MASK: 0x000000ff
> * SOFTIRQ_MASK: 0x0000ff00
> * HARDIRQ_MASK: 0x000f0000
> * NMI_MASK: 0x00100000
> * PREEMPT_ACTIVE: 0x00200000
>=20
> I would have added
> * PAGEFAULT_MASK: 0x03C00000
I'm not sure where you'd need to add the bits.
I think the above works because disabling 'HARDIRQ' implicitly
disables 'SOFTIRQ' and 'PREEMPT' (etc), so if 256+ threads
disable PREEMPT everything still works.
So if disabling pagefaults implies that pre-emption is disabled
(but SOFTIRQ is still allowed) then you need to insert your bit(s)
between 0xff00 and 0x00ff.
OTOH if disabling pre-emption implies that pagefaults are disabled
then you'd need to use the lsb and change all the above values.
Which makes me think that 'PREEMPT_ACTIVE' isn't right at all.
Two threads disabling NMIs (or 32 disabling HARDIRQ) won't DTRT.
OTOH I'm only guessing at how this is used.
David
next prev parent reply other threads:[~2014-11-27 16:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 11:43 [RFC 0/2] Reenable might_sleep() checks for might_fault() when atomic David Hildenbrand
2014-11-25 11:43 ` [RFC 1/2] powerpc/fsl-pci: atomic get_user when pagefault_disabled David Hildenbrand
2015-01-30 5:15 ` [RFC,1/2] " Scott Wood
2015-01-30 7:58 ` David Hildenbrand
2014-11-25 11:43 ` [RFC 2/2] mm, sched: trigger might_sleep() in might_fault() when atomic David Hildenbrand
2014-11-26 7:02 ` [RFC 0/2] Reenable might_sleep() checks for " Michael S. Tsirkin
2014-11-26 10:05 ` David Hildenbrand
2014-11-26 15:17 ` Michael S. Tsirkin
2014-11-26 15:23 ` Michael S. Tsirkin
2014-11-26 15:32 ` David Hildenbrand
2014-11-26 15:47 ` Michael S. Tsirkin
2014-11-26 16:02 ` David Hildenbrand
2014-11-26 16:19 ` Michael S. Tsirkin
2014-11-26 16:30 ` Christian Borntraeger
2014-11-26 16:50 ` Michael S. Tsirkin
2014-11-26 16:07 ` Christian Borntraeger
2014-11-26 16:32 ` Michael S. Tsirkin
2014-11-26 16:51 ` Christian Borntraeger
2014-11-26 17:04 ` Michael S. Tsirkin
2014-11-26 17:21 ` Michael S. Tsirkin
2014-11-27 7:09 ` Heiko Carstens
2014-11-27 7:40 ` Michael S. Tsirkin
2014-11-27 8:03 ` David Hildenbrand
2014-11-27 12:04 ` Heiko Carstens
2014-11-27 12:08 ` David Hildenbrand
2014-11-27 15:07 ` Thomas Gleixner
2014-11-27 15:19 ` David Hildenbrand
2014-11-27 15:37 ` David Laight
2014-11-27 15:45 ` David Hildenbrand
2014-11-27 16:27 ` David Laight [this message]
2014-11-27 16:49 ` David Hildenbrand
2014-11-27 21:52 ` Thomas Gleixner
2014-11-28 7:34 ` David Hildenbrand
2014-11-26 15:30 ` Christian Borntraeger
2014-11-26 15:37 ` Michael S. Tsirkin
2014-11-26 16:02 ` Christian Borntraeger
2014-11-26 15:22 ` Michael S. Tsirkin
2014-11-27 17:10 ` [PATCH RFC " David Hildenbrand
2014-11-27 17:10 ` [PATCH RFC 1/2] preempt: track pagefault_disable() calls in the preempt counter David Hildenbrand
2014-11-27 17:10 ` [PATCH RFC 2/2] mm, sched: trigger might_sleep() in might_fault() when pagefaults are disabled David Hildenbrand
2014-11-27 17:24 ` Michael S. Tsirkin
2014-11-27 17:32 ` Michael S. Tsirkin
2014-11-27 18:08 ` David Hildenbrand
2014-11-27 18:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1C9FDDD6@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).