Re: [PATCH v2] powerpc: allow configuring max stack dump depth

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On Thu, 2008-11-20 at 09:10 +1100, Paul Mackerras wrote:
> Johannes Berg writes:
> 
> > On my screen, when something crashes, I only have space for maybe
> > 16 functions of the stack trace before the information above it
> > scrolls off the screen. It's easy to hack the kernel to print out
> > only that much, but it's harder to remember to do it. This patch
> > introduces a config option for it so that I can keep the setting
> > in my config.
> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> > Sure, here's an updated version. I used DEBUG_KERNEL since the
> > ADVANCED_CONFIGURATION help text implies it's for MM and can cause the
> > kernel to not boot, not something this config is related to.
> 
> Um, with this I get a compile error when DEBUG_KERNEL=n:
> 
>   CC      arch/powerpc/kernel/process.o
> /home/paulus/kernel/powerpc/arch/powerpc/kernel/process.c:1001: error: 'CONFIG_PRINT_STACK_DEPTH' undeclared here (not in a function)
> make[2]: *** [arch/powerpc/kernel/process.o] Error 1

Ouch, clearly I haven't been paying attention, my mistake. Sorry about
that.

> I think it needs to look like this:
> 
> +config PRINT_STACK_DEPTH
> +	int "Stack depth to print" if DEBUG_KERNEL

Yes, that's better, thanks.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]