From: Paul Mackerras <paulus@samba.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH v2] powerpc: allow configuring max stack dump depth
Date: Thu, 20 Nov 2008 09:10:52 +1100 [thread overview]
Message-ID: <18724.36588.435729.738363@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1227095318.26243.17.camel@johannes.berg>
Johannes Berg writes:
> On my screen, when something crashes, I only have space for maybe
> 16 functions of the stack trace before the information above it
> scrolls off the screen. It's easy to hack the kernel to print out
> only that much, but it's harder to remember to do it. This patch
> introduces a config option for it so that I can keep the setting
> in my config.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> Sure, here's an updated version. I used DEBUG_KERNEL since the
> ADVANCED_CONFIGURATION help text implies it's for MM and can cause the
> kernel to not boot, not something this config is related to.
Um, with this I get a compile error when DEBUG_KERNEL=n:
CC arch/powerpc/kernel/process.o
/home/paulus/kernel/powerpc/arch/powerpc/kernel/process.c:1001: error: 'CONFIG_PRINT_STACK_DEPTH' undeclared here (not in a function)
make[2]: *** [arch/powerpc/kernel/process.o] Error 1
I think it needs to look like this:
+config PRINT_STACK_DEPTH
+ int "Stack depth to print" if DEBUG_KERNEL
+ default 64
+ help
+ This option allows you to set the stack depth that the kernel
+ prints in stack traces. This can be useful if your display is
+ too small and stack traces cause important information to
+ scroll off the screen.
+
Paul.
next prev parent reply other threads:[~2008-11-19 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 10:11 [PATCH] powerpc: allow configuring max stack dump depth Johannes Berg
2008-11-19 4:24 ` Paul Mackerras
2008-11-19 11:48 ` [PATCH v2] " Johannes Berg
2008-11-19 22:10 ` Paul Mackerras [this message]
2008-11-20 13:20 ` Johannes Berg
2008-11-20 13:24 ` [PATCH v3] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18724.36588.435729.738363@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).