* [PATCH v2] Check name property to determine partition nodes.
@ 2009-01-23 16:18 Benjamin Krill
2009-02-04 4:09 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Krill @ 2009-01-23 16:18 UTC (permalink / raw)
To: linux-mtd, dwg, linuxppc-dev, vwool
SLOF has a further node which could not be evaluate
by the current routine. The current routine returns
because the node hasn't the required reg property. As
fix this patch adds a check to determine the partition
child nodes. If the node is not an partition the number
of total partitions will be decreased and loop continue
with the next nodes.
Signed-off-by: Benjamin Krill <ben@codiert.org>
---
drivers/mtd/ofpart.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
index 9e45b3f..3e164f0 100644
--- a/drivers/mtd/ofpart.c
+++ b/drivers/mtd/ofpart.c
@@ -46,6 +46,13 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
const u32 *reg;
int len;
+ /* check if this is a partition node */
+ partname = of_get_property(pp, "name", &len);
+ if (strcmp(partname, "partition") != 0) {
+ nr_parts--;
+ continue;
+ }
+
reg = of_get_property(pp, "reg", &len);
if (!reg || (len != 2 * sizeof(u32))) {
of_node_put(pp);
--
1.6.0.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Check name property to determine partition nodes.
2009-01-23 16:18 [PATCH v2] Check name property to determine partition nodes Benjamin Krill
@ 2009-02-04 4:09 ` Benjamin Herrenschmidt
2009-02-18 7:47 ` Benjamin Krill
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2009-02-04 4:09 UTC (permalink / raw)
To: Benjamin Krill; +Cc: linuxppc-dev, vwool, linux-mtd, David Woodhouse, dwg
On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
> SLOF has a further node which could not be evaluate
> by the current routine. The current routine returns
> because the node hasn't the required reg property. As
> fix this patch adds a check to determine the partition
> child nodes. If the node is not an partition the number
> of total partitions will be decreased and loop continue
> with the next nodes.
Somebody on the MTD list is taking that ? David ? Or should I merge it
via powerpc ?
Cheers,
Ben.
> Signed-off-by: Benjamin Krill <ben@codiert.org>
> ---
> drivers/mtd/ofpart.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 9e45b3f..3e164f0 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -46,6 +46,13 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
> const u32 *reg;
> int len;
>
> + /* check if this is a partition node */
> + partname = of_get_property(pp, "name", &len);
> + if (strcmp(partname, "partition") != 0) {
> + nr_parts--;
> + continue;
> + }
> +
> reg = of_get_property(pp, "reg", &len);
> if (!reg || (len != 2 * sizeof(u32))) {
> of_node_put(pp);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Check name property to determine partition nodes.
2009-02-04 4:09 ` Benjamin Herrenschmidt
@ 2009-02-18 7:47 ` Benjamin Krill
2009-03-24 13:27 ` Benjamin Krill
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Krill @ 2009-02-18 7:47 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: linuxppc-dev, vwool, linux-mtd, David Woodhouse, dwg
* Benjamin Herrenschmidt | 2009-02-04 15:09:02 [+1100]:
>On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
>> SLOF has a further node which could not be evaluate
>> by the current routine. The current routine returns
>> because the node hasn't the required reg property. As
>> fix this patch adds a check to determine the partition
>> child nodes. If the node is not an partition the number
>> of total partitions will be decreased and loop continue
>> with the next nodes.
>
>Somebody on the MTD list is taking that ? David ? Or should I merge it
>via powerpc ?
Could somebody merge it for the next release?
Ben
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Check name property to determine partition nodes.
2009-02-18 7:47 ` Benjamin Krill
@ 2009-03-24 13:27 ` Benjamin Krill
2009-03-24 14:04 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Krill @ 2009-03-24 13:27 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, linux-mtd, David Woodhouse, dwg
>>On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
>>> SLOF has a further node which could not be evaluate
>>> by the current routine. The current routine returns
>>> because the node hasn't the required reg property. As
>>> fix this patch adds a check to determine the partition
>>> child nodes. If the node is not an partition the number
>>> of total partitions will be decreased and loop continue
>>> with the next nodes.
>>
>>Somebody on the MTD list is taking that ? David ? Or should I merge it
>>via powerpc ?
>
>Could somebody merge it for the next release?
Again, new try to get it somewhere merged.
cheers
ben
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Check name property to determine partition nodes.
2009-03-24 13:27 ` Benjamin Krill
@ 2009-03-24 14:04 ` David Woodhouse
0 siblings, 0 replies; 5+ messages in thread
From: David Woodhouse @ 2009-03-24 14:04 UTC (permalink / raw)
To: Benjamin Krill; +Cc: dwg, linux-mtd, linuxppc-dev
On Tue, 2009-03-24 at 14:27 +0100, Benjamin Krill wrote:
> >>On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
> >>> SLOF has a further node which could not be evaluate
> >>> by the current routine. The current routine returns
> >>> because the node hasn't the required reg property. As
> >>> fix this patch adds a check to determine the partition
> >>> child nodes. If the node is not an partition the number
> >>> of total partitions will be decreased and loop continue
> >>> with the next nodes.
> >>
> >>Somebody on the MTD list is taking that ? David ? Or should I merge it
> >>via powerpc ?
> >
> >Could somebody merge it for the next release?
>
> Again, new try to get it somewhere merged.
Applied; thanks.
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-24 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-23 16:18 [PATCH v2] Check name property to determine partition nodes Benjamin Krill
2009-02-04 4:09 ` Benjamin Herrenschmidt
2009-02-18 7:47 ` Benjamin Krill
2009-03-24 13:27 ` Benjamin Krill
2009-03-24 14:04 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).