From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] Adjust arch/powerpc inline asms for recent gcc change
Date: Thu, 08 Jul 2010 16:08:05 +1000 [thread overview]
Message-ID: <1278569285.28659.76.camel@pasglop> (raw)
In-Reply-To: <20100625095606.GG12443@tyan-ft48-01.lab.bos.redhat.com>
On Fri, 2010-06-25 at 11:56 +0200, Jakub Jelinek wrote:
> static inline void sync(void)
> diff --git a/arch/powerpc/include/asm/atomic.h b/arch/powerpc/include/asm/atomic.h
> index b8f152e..288d8b2 100644
> --- a/arch/powerpc/include/asm/atomic.h
> +++ b/arch/powerpc/include/asm/atomic.h
> @@ -19,14 +19,14 @@ static __inline__ int atomic_read(const atomic_t *v)
> {
> int t;
>
> - __asm__ __volatile__("lwz%U1%X1 %0,%1" : "=r"(t) : "m"(v->counter));
> + __asm__ __volatile__("lwz%U1%X1 %0,%1" : "=r"(t) : "m<>"(v->counter));
>
> return t;
> }
>
This gives me:
/home/benh/linux-powerpc-test/arch/powerpc/kernel/time.c: In function ‘timer_interrupt’:
/home/benh/linux-powerpc-test/arch/powerpc/include/asm/atomic.h:22: error: ‘asm’ operand has impossible constraints
make[2]: *** [arch/powerpc/kernel/time.o] Error 1
$ gcc --version
gcc (Debian 4.4.4-1) 4.4.4
Cheers,
Ben.
next prev parent reply other threads:[~2010-07-08 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 9:56 [PATCH] Adjust arch/powerpc inline asms for recent gcc change Jakub Jelinek
2010-06-25 11:08 ` Segher Boessenkool
2010-06-25 11:18 ` Jakub Jelinek
2010-06-30 6:10 ` Benjamin Herrenschmidt
2010-06-30 22:26 ` Segher Boessenkool
2010-07-08 6:08 ` Benjamin Herrenschmidt [this message]
2010-07-30 7:04 ` Benjamin Herrenschmidt
2010-07-30 7:19 ` Jakub Jelinek
2010-07-30 7:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278569285.28659.76.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jakub@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).