From: Jakub Jelinek <jakub@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Adjust arch/powerpc inline asms for recent gcc change
Date: Fri, 25 Jun 2010 13:18:29 +0200 [thread overview]
Message-ID: <20100625111829.GH12443@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <57727.84.105.60.153.1277464103.squirrel@gate.crashing.org>
On Fri, Jun 25, 2010 at 01:08:23PM +0200, Segher Boessenkool wrote:
> > - stw%U0%X0 %L2,%1"
> > - : "=m" (*ptep), "=m" (*((unsigned char *)ptep+4))
> > + stw%U1%X1 %L2,%1"
> > + : "=m<>" (*ptep), "=m<>" (*((unsigned char *)ptep+4))
> > : "r" (pte) : "memory");
>
> This still isn't correct -- the constraint says that a byte
> is written, but the insn changes a word. Probably should just
> be ptep[1] ?
Yeah.
Jakub
next prev parent reply other threads:[~2010-06-25 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 9:56 [PATCH] Adjust arch/powerpc inline asms for recent gcc change Jakub Jelinek
2010-06-25 11:08 ` Segher Boessenkool
2010-06-25 11:18 ` Jakub Jelinek [this message]
2010-06-30 6:10 ` Benjamin Herrenschmidt
2010-06-30 22:26 ` Segher Boessenkool
2010-07-08 6:08 ` Benjamin Herrenschmidt
2010-07-30 7:04 ` Benjamin Herrenschmidt
2010-07-30 7:19 ` Jakub Jelinek
2010-07-30 7:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100625111829.GH12443@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).