* [PATCH 1/1] SPI: dw_spi, fix PPC build
@ 2011-03-18 9:41 Jiri Slaby
2011-03-18 15:51 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2011-03-18 9:41 UTC (permalink / raw)
To: dbrownell
Cc: jirislaby, linux-kernel, Paul Mackerras, spi-devel-general, linuxppc-dev
Currently, build on PPC dies with:
In file included from drivers/spi/dw_spi_mmio.c:16:
include/linux/spi/dw_spi.h:147: error: field ‘tx_sgl’ has incomplete type
include/linux/spi/dw_spi.h:149: error: field ‘rx_sgl’ has incomplete type
Add linux/scatterlist.h include to dw_spi.h, because we need to know
the contents of the structure.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
---
include/linux/spi/dw_spi.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/spi/dw_spi.h b/include/linux/spi/dw_spi.h
index 6cd10f6..fb0bce5 100644
--- a/include/linux/spi/dw_spi.h
+++ b/include/linux/spi/dw_spi.h
@@ -2,6 +2,7 @@
#define DW_SPI_HEADER_H
#include <linux/io.h>
+#include <linux/scatterlist.h>
/* Bit fields in CTRLR0 */
#define SPI_DFS_OFFSET 0
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] SPI: dw_spi, fix PPC build
2011-03-18 9:41 [PATCH 1/1] SPI: dw_spi, fix PPC build Jiri Slaby
@ 2011-03-18 15:51 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-03-18 15:51 UTC (permalink / raw)
To: Jiri Slaby
Cc: dbrownell, jirislaby, linux-kernel, Paul Mackerras,
spi-devel-general, linuxppc-dev
On Fri, Mar 18, 2011 at 10:41:17AM +0100, Jiri Slaby wrote:
> Currently, build on PPC dies with:
> In file included from drivers/spi/dw_spi_mmio.c:16:
> include/linux/spi/dw_spi.h:147: error: field ‘tx_sgl’ has incomplete type
> include/linux/spi/dw_spi.h:149: error: field ‘rx_sgl’ has incomplete type
>
> Add linux/scatterlist.h include to dw_spi.h, because we need to know
> the contents of the structure.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
Applied, thanks.
g.
> ---
> include/linux/spi/dw_spi.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/spi/dw_spi.h b/include/linux/spi/dw_spi.h
> index 6cd10f6..fb0bce5 100644
> --- a/include/linux/spi/dw_spi.h
> +++ b/include/linux/spi/dw_spi.h
> @@ -2,6 +2,7 @@
> #define DW_SPI_HEADER_H
>
> #include <linux/io.h>
> +#include <linux/scatterlist.h>
>
> /* Bit fields in CTRLR0 */
> #define SPI_DFS_OFFSET 0
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-18 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-18 9:41 [PATCH 1/1] SPI: dw_spi, fix PPC build Jiri Slaby
2011-03-18 15:51 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).