* [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.
@ 2012-06-03 7:43 Varun Sethi
0 siblings, 0 replies; 5+ messages in thread
From: Varun Sethi @ 2012-06-03 7:43 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Varun Sethi
We should use the MPIC_LARG_VECTORS flag while intializing the MPIC.
This prevents us from eating in to hardware vector number space (MSIs)
while setting up internal sources.
Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
---
arch/powerpc/sysdev/mpic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index a98eb77..61c7225 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -1211,7 +1211,7 @@ struct mpic * __init mpic_alloc(struct device_node *node,
if (of_get_property(node, "single-cpu-affinity", NULL))
flags |= MPIC_SINGLE_DEST_CPU;
if (of_device_is_compatible(node, "fsl,mpic"))
- flags |= MPIC_FSL;
+ flags |= MPIC_FSL | MPIC_LARGE_VECTORS;
mpic = kzalloc(sizeof(struct mpic), GFP_KERNEL);
if (mpic == NULL)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.
@ 2012-07-09 8:46 Varun Sethi
2012-07-09 14:27 ` Kumar Gala
2012-07-10 12:23 ` Kumar Gala
0 siblings, 2 replies; 5+ messages in thread
From: Varun Sethi @ 2012-07-09 8:46 UTC (permalink / raw)
To: galak, linuxppc-dev; +Cc: Varun Sethi
We should use the MPIC_LARG_VECTORS flag while intializing the MPIC.
This prevents us from eating in to hardware vector number space (MSIs)
while setting up internal sources.
Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
---
arch/powerpc/sysdev/mpic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index a98eb77..61c7225 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -1211,7 +1211,7 @@ struct mpic * __init mpic_alloc(struct device_node *node,
if (of_get_property(node, "single-cpu-affinity", NULL))
flags |= MPIC_SINGLE_DEST_CPU;
if (of_device_is_compatible(node, "fsl,mpic"))
- flags |= MPIC_FSL;
+ flags |= MPIC_FSL | MPIC_LARGE_VECTORS;
mpic = kzalloc(sizeof(struct mpic), GFP_KERNEL);
if (mpic == NULL)
--
1.7.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.
2012-07-09 8:46 Varun Sethi
@ 2012-07-09 14:27 ` Kumar Gala
2012-07-09 14:41 ` Sethi Varun-B16395
2012-07-10 12:23 ` Kumar Gala
1 sibling, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2012-07-09 14:27 UTC (permalink / raw)
To: Varun Sethi; +Cc: linuxppc-dev
On Jul 9, 2012, at 3:46 AM, Varun Sethi wrote:
> We should use the MPIC_LARG_VECTORS flag while intializing the MPIC.
> This prevents us from eating in to hardware vector number space (MSIs)
> while setting up internal sources.
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> arch/powerpc/sysdev/mpic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Can you remind me the issue here w/running into the MSIs?
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.
2012-07-09 14:27 ` Kumar Gala
@ 2012-07-09 14:41 ` Sethi Varun-B16395
0 siblings, 0 replies; 5+ messages in thread
From: Sethi Varun-B16395 @ 2012-07-09 14:41 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Monday, July 09, 2012 7:58 PM
> To: Sethi Varun-B16395
> Cc: linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag
> for FSL MPIC.
>=20
>=20
> On Jul 9, 2012, at 3:46 AM, Varun Sethi wrote:
>=20
> > We should use the MPIC_LARG_VECTORS flag while intializing the MPIC.
> > This prevents us from eating in to hardware vector number space (MSIs)
> > while setting up internal sources.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> > ---
> > arch/powerpc/sysdev/mpic.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> Can you remind me the issue here w/running into the MSIs?
Vector numbers for internal interrupt sources like timers/ipis are
taken from the hardware vector number space. Currently we specify=20
number of interrupt sources as 256 and extract 12 vectors from here
for internal interrupt sources. In process we end up eating vector numbers
meant for MSIs. With this patch we are basically expanding our vector
number space.
-Varun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.
2012-07-09 8:46 Varun Sethi
2012-07-09 14:27 ` Kumar Gala
@ 2012-07-10 12:23 ` Kumar Gala
1 sibling, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2012-07-10 12:23 UTC (permalink / raw)
To: Varun Sethi; +Cc: linuxppc-dev
On Jul 9, 2012, at 3:46 AM, Varun Sethi wrote:
> We should use the MPIC_LARG_VECTORS flag while intializing the MPIC.
> This prevents us from eating in to hardware vector number space (MSIs)
> while setting up internal sources.
>
> Signed-off-by: Varun Sethi <Varun.Sethi@freescale.com>
> ---
> arch/powerpc/sysdev/mpic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to next
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-10 12:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-03 7:43 [PATCH 2/3 v2] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC Varun Sethi
2012-07-09 8:46 Varun Sethi
2012-07-09 14:27 ` Kumar Gala
2012-07-09 14:41 ` Sethi Varun-B16395
2012-07-10 12:23 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).