* [PATCH] using get/put_user64 apis on 64bit machine
@ 2012-07-23 10:16 Bharat Bhushan
2012-09-10 4:42 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Bharat Bhushan @ 2012-07-23 10:16 UTC (permalink / raw)
To: linuxppc-dev, galak, agraf, scottwood; +Cc: Bharat Bhushan
On powerpc64 machine get/put_user64() is same as get/put_user() while
on powerpc32 machine get_user64 is different. With this patch we can
use get_user64() and put_user64() on 32 and 64 bit machines.
Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
---
arch/powerpc/include/asm/uaccess.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
index 17bb40c..01743aa 100644
--- a/arch/powerpc/include/asm/uaccess.h
+++ b/arch/powerpc/include/asm/uaccess.h
@@ -114,10 +114,17 @@ struct exception_table_entry {
#define __put_user(x, ptr) \
__put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
+/*
+ * On powerpc64 machine get/put_user64() is same as get/put_user() while
+ * on powerpc32 machine get_user64 is different.
+ */
#ifndef __powerpc64__
#define __get_user64(x, ptr) \
__get_user64_nocheck((x), (ptr), sizeof(*(ptr)))
#define __put_user64(x, ptr) __put_user(x, ptr)
+#else
+#define __get_user64(x, ptr) __get_user(x, ptr)
+#define __put_user64(x, ptr) __put_user(x, ptr)
#endif
#define __get_user_inatomic(x, ptr) \
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] using get/put_user64 apis on 64bit machine
2012-07-23 10:16 [PATCH] using get/put_user64 apis on 64bit machine Bharat Bhushan
@ 2012-09-10 4:42 ` Benjamin Herrenschmidt
2012-09-10 8:50 ` Bhushan Bharat-R65777
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2012-09-10 4:42 UTC (permalink / raw)
To: Bharat Bhushan; +Cc: scottwood, Bharat Bhushan, linuxppc-dev, agraf
On Mon, 2012-07-23 at 15:46 +0530, Bharat Bhushan wrote:
> On powerpc64 machine get/put_user64() is same as get/put_user() while
> on powerpc32 machine get_user64 is different. With this patch we can
> use get_user64() and put_user64() on 32 and 64 bit machines.
>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
> ---
There appear to be no user of any of these APIs in the tree. There's
also no get_user64 -> __get_user64() macros either. Why not just remove
the whole lot ?
Cheers,
Ben.
> arch/powerpc/include/asm/uaccess.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
> index 17bb40c..01743aa 100644
> --- a/arch/powerpc/include/asm/uaccess.h
> +++ b/arch/powerpc/include/asm/uaccess.h
> @@ -114,10 +114,17 @@ struct exception_table_entry {
> #define __put_user(x, ptr) \
> __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
>
> +/*
> + * On powerpc64 machine get/put_user64() is same as get/put_user() while
> + * on powerpc32 machine get_user64 is different.
> + */
> #ifndef __powerpc64__
> #define __get_user64(x, ptr) \
> __get_user64_nocheck((x), (ptr), sizeof(*(ptr)))
> #define __put_user64(x, ptr) __put_user(x, ptr)
> +#else
> +#define __get_user64(x, ptr) __get_user(x, ptr)
> +#define __put_user64(x, ptr) __put_user(x, ptr)
> #endif
>
> #define __get_user_inatomic(x, ptr) \
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] using get/put_user64 apis on 64bit machine
2012-09-10 4:42 ` Benjamin Herrenschmidt
@ 2012-09-10 8:50 ` Bhushan Bharat-R65777
2012-09-10 22:25 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Bhushan Bharat-R65777 @ 2012-09-10 8:50 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Wood Scott-B07421, linuxppc-dev, agraf
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQmVuamFtaW4gSGVycmVu
c2NobWlkdCBbbWFpbHRvOmJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZ10NCj4gU2VudDogTW9uZGF5
LCBTZXB0ZW1iZXIgMTAsIDIwMTIgMTA6MTIgQU0NCj4gVG86IEJodXNoYW4gQmhhcmF0LVI2NTc3
Nw0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGdhbGFrQGtlcm5lbC5jcmFz
aGluZy5vcmc7IGFncmFmQHN1c2UuZGU7DQo+IFdvb2QgU2NvdHQtQjA3NDIxOyBCaHVzaGFuIEJo
YXJhdC1SNjU3NzcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gdXNpbmcgZ2V0L3B1dF91c2VyNjQg
YXBpcyBvbiA2NGJpdCBtYWNoaW5lDQo+IA0KPiBPbiBNb24sIDIwMTItMDctMjMgYXQgMTU6NDYg
KzA1MzAsIEJoYXJhdCBCaHVzaGFuIHdyb3RlOg0KPiA+IE9uIHBvd2VycGM2NCBtYWNoaW5lIGdl
dC9wdXRfdXNlcjY0KCkgaXMgc2FtZSBhcyBnZXQvcHV0X3VzZXIoKSB3aGlsZQ0KPiA+IG9uIHBv
d2VycGMzMiBtYWNoaW5lIGdldF91c2VyNjQgaXMgZGlmZmVyZW50LiBXaXRoIHRoaXMgcGF0Y2gg
d2UgY2FuDQo+ID4gdXNlIGdldF91c2VyNjQoKSBhbmQgcHV0X3VzZXI2NCgpIG9uIDMyIGFuZCA2
NCBiaXQgbWFjaGluZXMuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBCaGFyYXQgQmh1c2hhbiA8
YmhhcmF0LmJodXNoYW5AZnJlZXNjYWxlLmNvbT4NCj4gPiAtLS0NCj4gDQo+IFRoZXJlIGFwcGVh
ciB0byBiZSBubyB1c2VyIG9mIGFueSBvZiB0aGVzZSBBUElzIGluIHRoZSB0cmVlLiBUaGVyZSdz
IGFsc28gbm8NCj4gZ2V0X3VzZXI2NCAtPiBfX2dldF91c2VyNjQoKSBtYWNyb3MgZWl0aGVyLiBX
aHkgbm90IGp1c3QgcmVtb3ZlIHRoZSB3aG9sZSBsb3QgPw0KDQpXaGVuIEkgc2VudCB0aGUgcGF0
Y2ggSSBkaWQgbm90IHNlYXJjaCB0aGUgdXNlcnMsIEkgYWdyZWUgdGhhdCB3ZSBjYW4gcmVtb3Zl
IHRoZSBfX2dldF91c2VyNjQgYW5kIF9fcHV0X3VzZXI2NCBhbHRvZ2V0aGVyLg0KDQpUaGFua3MN
Ci1CaGFyYXQgDQoNCj4gDQo+IENoZWVycywNCj4gQmVuLg0KPiANCj4gPiAgYXJjaC9wb3dlcnBj
L2luY2x1ZGUvYXNtL3VhY2Nlc3MuaCB8ICAgIDcgKysrKysrKw0KPiA+ICAxIGZpbGVzIGNoYW5n
ZWQsIDcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQg
YS9hcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdWFjY2Vzcy5oDQo+ID4gYi9hcmNoL3Bvd2VycGMv
aW5jbHVkZS9hc20vdWFjY2Vzcy5oDQo+ID4gaW5kZXggMTdiYjQwYy4uMDE3NDNhYSAxMDA2NDQN
Cj4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vdWFjY2Vzcy5oDQo+ID4gKysrIGIv
YXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3VhY2Nlc3MuaA0KPiA+IEBAIC0xMTQsMTAgKzExNCwx
NyBAQCBzdHJ1Y3QgZXhjZXB0aW9uX3RhYmxlX2VudHJ5IHsgICNkZWZpbmUNCj4gPiBfX3B1dF91
c2VyKHgsIHB0cikgXA0KPiA+ICAJX19wdXRfdXNlcl9ub2NoZWNrKChfX3R5cGVvZl9fKCoocHRy
KSkpKHgpLCAocHRyKSwgc2l6ZW9mKCoocHRyKSkpDQo+ID4NCj4gPiArLyoNCj4gPiArICogT24g
cG93ZXJwYzY0IG1hY2hpbmUgZ2V0L3B1dF91c2VyNjQoKSBpcyBzYW1lIGFzIGdldC9wdXRfdXNl
cigpDQo+ID4gK3doaWxlDQo+ID4gKyAqIG9uIHBvd2VycGMzMiBtYWNoaW5lIGdldF91c2VyNjQg
aXMgZGlmZmVyZW50Lg0KPiA+ICsgKi8NCj4gPiAgI2lmbmRlZiBfX3Bvd2VycGM2NF9fDQo+ID4g
ICNkZWZpbmUgX19nZXRfdXNlcjY0KHgsIHB0cikgXA0KPiA+ICAJX19nZXRfdXNlcjY0X25vY2hl
Y2soKHgpLCAocHRyKSwgc2l6ZW9mKCoocHRyKSkpICAjZGVmaW5lDQo+ID4gX19wdXRfdXNlcjY0
KHgsIHB0cikgX19wdXRfdXNlcih4LCBwdHIpDQo+ID4gKyNlbHNlDQo+ID4gKyNkZWZpbmUgX19n
ZXRfdXNlcjY0KHgsIHB0cikgX19nZXRfdXNlcih4LCBwdHIpICNkZWZpbmUNCj4gPiArX19wdXRf
dXNlcjY0KHgsIHB0cikgX19wdXRfdXNlcih4LCBwdHIpDQo+ID4gICNlbmRpZg0KPiA+DQo+ID4g
ICNkZWZpbmUgX19nZXRfdXNlcl9pbmF0b21pYyh4LCBwdHIpIFwNCj4gDQo+IA0KDQo=
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] using get/put_user64 apis on 64bit machine
2012-09-10 8:50 ` Bhushan Bharat-R65777
@ 2012-09-10 22:25 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2012-09-10 22:25 UTC (permalink / raw)
To: Bhushan Bharat-R65777; +Cc: Wood Scott-B07421, linuxppc-dev, agraf
On Mon, 2012-09-10 at 08:50 +0000, Bhushan Bharat-R65777 wrote:
> When I sent the patch I did not search the users, I agree that we can
> remove the __get_user64 and __put_user64 altogether.
Care to send a patch ?
Cheers,
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-10 22:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-23 10:16 [PATCH] using get/put_user64 apis on 64bit machine Bharat Bhushan
2012-09-10 4:42 ` Benjamin Herrenschmidt
2012-09-10 8:50 ` Bhushan Bharat-R65777
2012-09-10 22:25 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).