linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: mikey@neuling.org
Subject: [PATCH V3 1/2]     powerpc, perf: Ignore separate BHRB privilege state filter request
Date: Mon, 10 Jun 2013 10:55:09 +0530	[thread overview]
Message-ID: <1370841910-28695-2-git-send-email-khandual@linux.vnet.ibm.com> (raw)
In-Reply-To: <1370841910-28695-1-git-send-email-khandual@linux.vnet.ibm.com>

    Completely ignore BHRB privilege state filter request as we are
    already configuring that with privilege state filtering attribute
    for the accompanying PMU event. This would help achieve cleaner
    user space interaction for BHRB.

    This patch fixes a situation like this

    Before patch:-
    ------------
    ./perf record -j any -e branch-misses:k ls
    Error:
    The sys_perf_event_open() syscall returned with 95 (Operation not
    supported) for event (branch-misses:k).
    /bin/dmesg may provide additional information.
    No CONFIG_PERF_EVENTS=y kernel support configured?

    Here 'perf record' actually copies over ':k' filter request into BHRB
    privilege state filter config and our previous check in kernel would
    fail that.

    After patch:-
    -------------
    ./perf record -j any -e branch-misses:k ls
    perf  perf.data  perf.data.old  test-mmap-ring
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.002 MB perf.data (~102 samples)]

    Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 arch/powerpc/perf/power8-pmu.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c
index f7d1c4f..371c6e7 100644
--- a/arch/powerpc/perf/power8-pmu.c
+++ b/arch/powerpc/perf/power8-pmu.c
@@ -523,18 +523,13 @@ static int power8_generic_events[] = {
 static u64 power8_bhrb_filter_map(u64 branch_sample_type)
 {
 	u64 pmu_bhrb_filter = 0;
-	u64 br_privilege = branch_sample_type & ONLY_PLM;
 
-	/* BHRB and regular PMU events share the same prvillege state
+	/* BHRB and regular PMU events share the same privilege state
 	 * filter configuration. BHRB is always recorded along with a
-	 * regular PMU event. So privilege state filter criteria for BHRB
-	 * and the companion PMU events has to be the same. As a default
-	 * "perf record" tool sets all privillege bits ON when no filter
-	 * criteria is provided in the command line. So as along as all
-	 * privillege bits are ON or they are OFF, we are good to go.
+	 * regular PMU event. As the privilege state filter is handled
+	 * in the basic PMC configuration of the accompanying regular
+	 * PMU event, we ignore any separate BHRB specific request.
 	 */
-	if ((br_privilege != 7) && (br_privilege != 0))
-		return -1;
 
 	/* No branch filter requested */
 	if (branch_sample_type & PERF_SAMPLE_BRANCH_ANY)
-- 
1.7.11.7

  reply	other threads:[~2013-06-10  5:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10  5:25 [PATCH V3 0/2] Improvement and fixes for BHRB Anshuman Khandual
2013-06-10  5:25 ` Anshuman Khandual [this message]
2013-06-10  5:25 ` [PATCH V3 2/2] powerpc, perf: BHRB filter configuration should follow the task Anshuman Khandual
2013-06-10  5:53 [PATCH V3 0/2] Improvement and fixes for BHRB Anshuman Khandual
2013-06-10  5:53 ` [PATCH V3 1/2] powerpc, perf: Ignore separate BHRB privilege state filter request Anshuman Khandual
2013-06-24  7:19   ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370841910-28695-2-git-send-email-khandual@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).