From: Scott Wood <scottwood@freescale.com>
To: Haijun Zhang <Haijun.Zhang@freescale.com>
Cc: linux-mmc@vger.kernel.org, r39252@freescale.com,
AFLEMING@freescale.com, cbouatmailru@gmail.com, cjb@laptop.org,
linuxppc-dev@lists.ozlabs.org,
Haijun Zhang <Haijun.Zhang@freescale.com>
Subject: Re: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
Date: Mon, 8 Jul 2013 12:14:05 -0500 [thread overview]
Message-ID: <1373303645.8183.163@snotra> (raw)
In-Reply-To: <1373267764-6364-1-git-send-email-Haijun.Zhang@freescale.com> (from Haijun.Zhang@freescale.com on Mon Jul 8 02:16:03 2013)
On 07/08/2013 02:16:03 AM, Haijun Zhang wrote:
> In order to make a difference between different T4240 board.
> Specify T4240QDS board the unique compatible flags for t4240qds
> eSDHC host.
>=20
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> ---
> arch/powerpc/boot/dts/fsl/t4240si-post.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi =20
> b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> index bd611a9..08b47d0 100644
> --- a/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t4240si-post.dtsi
> @@ -397,7 +397,7 @@
>=20
> /include/ "qoriq-esdhc-0.dtsi"
> sdhc@114000 {
> - compatible =3D "fsl,t4240-esdhc", "fsl,esdhc";
> + compatible =3D "fsl,t4240qds-esdhc", "fsl,esdhc";
> sdhci,auto-cmd12;
> };
NACK. This node is describing the sdhc block of the t4240 SoC. What =20
board you stick it in doesn't change what it is.
Plus, what about users with old device trees?
-Scott=
next prev parent reply other threads:[~2013-07-08 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
2013-07-08 17:18 ` Scott Wood
2013-07-12 18:35 ` Anton Vorontsov
2013-07-16 3:11 ` Zhang Haijun-B42677
2013-07-16 5:04 ` Anton Vorontsov
2013-07-08 17:14 ` Scott Wood [this message]
2013-07-09 6:04 ` 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Zhang Haijun-B42677
2013-07-09 20:04 ` Scott Wood
2013-07-10 3:41 ` Zhang Haijun-B42677
2013-07-10 20:30 ` Scott Wood
2013-07-11 1:02 ` Zhang Haijun-B42677
2013-07-11 14:35 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373303645.8183.163@snotra \
--to=scottwood@freescale.com \
--cc=AFLEMING@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r39252@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).