From: Scott Wood <scottwood@freescale.com>
To: Zhang Haijun-B42677 <B42677@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Wrobel Heinz-R39252 <r39252@freescale.com>,
Fleming Andy-AFLEMING <afleming@freescale.com>,
"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>,
"cjb@laptop.org" <cjb@laptop.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board
Date: Wed, 10 Jul 2013 15:30:05 -0500 [thread overview]
Message-ID: <1373488205.8183.228@snotra> (raw)
In-Reply-To: <99E897753B6F7048BD8CCDB4661D02E139CE27@039-SN2MPN1-021.039d.mgd.msft.net> (from B42677@freescale.com on Tue Jul 9 22:41:22 2013)
On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:
> > No. It's still supposed to be describing the sdhc block itself, =20
> not the
> > board -- and any workarounds that key off of this will still fail =20
> to work
> > with existing device trees.
> [Haijun Wrote:] So, leave dts unchanged and to check compitable for =20
> board in sdhci-pltfm.c
> e.g.:
> unsigned long root =3D of_get_flat_dt_root();
>=20
> if (of_flat_dt_is_compatible(root, "fsl,T4240QDS"))
> host->quirks |=3D XXX;
Why are you looking at the flat tree at this point? Use the normal OF =20
accessors. The flat stuff is only for early boot.
Also make sure that you only do this for quirks that are actually =20
board-specific. In your last patch you had two quirks keyed off of the =20
board, one of which is keyed off of the SoC for other chips.
-SCott=
next prev parent reply other threads:[~2013-07-10 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 7:16 [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Haijun Zhang
2013-07-08 7:16 ` [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board Haijun Zhang
2013-07-08 17:18 ` Scott Wood
2013-07-12 18:35 ` Anton Vorontsov
2013-07-16 3:11 ` Zhang Haijun-B42677
2013-07-16 5:04 ` Anton Vorontsov
2013-07-08 17:14 ` [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board Scott Wood
2013-07-09 6:04 ` 答复: " Zhang Haijun-B42677
2013-07-09 20:04 ` Scott Wood
2013-07-10 3:41 ` Zhang Haijun-B42677
2013-07-10 20:30 ` Scott Wood [this message]
2013-07-11 1:02 ` Zhang Haijun-B42677
2013-07-11 14:35 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373488205.8183.228@snotra \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B42677@freescale.com \
--cc=afleming@freescale.com \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r39252@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).