* [PATCH] powerpc: Add a vga alias node for P1022
@ 2013-11-15 6:06 Jason Jin
2013-11-15 19:08 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Jason Jin @ 2013-11-15 6:06 UTC (permalink / raw)
To: scottwood; +Cc: linuxppc-dev
In u-boot, when set the video as console, the name 'vga' is used
as a general name for the video device, during the fdt_fixup_stdout
process, the 'vga' name is used to search in the dtb to setup the
'linux,stdout-path' node. Though the P1022 DIU is not VGA-compatible device,
to meet the 'vga' name used in u-boot, the vga alias node is added for
P1022 in this patch. At the same time, a display alias is also added
so that no other components grow dependencies on the vga alias node.
Signed-off-by: Jason Jin <Jason.Jin@freescale.com>
---
V2: Update the description and also add a display alias.
arch/powerpc/boot/dts/fsl/p1022si-post.dtsi | 2 +-
arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
index e179803..be49300 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
@@ -174,7 +174,7 @@
/include/ "pq3-gpio-0.dtsi"
- display@10000 {
+ display: display@10000 {
compatible = "fsl,diu", "fsl,p1022-diu";
reg = <0x10000 1000>;
interrupts = <64 2 0 0>;
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
index 1956dea..de76ae8 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
@@ -50,6 +50,8 @@
pci0 = &pci0;
pci1 = &pci1;
pci2 = &pci2;
+ vga = &display;
+ display = &display;
};
cpus {
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Add a vga alias node for P1022
2013-11-15 6:06 [PATCH] powerpc: Add a vga alias node for P1022 Jason Jin
@ 2013-11-15 19:08 ` Scott Wood
0 siblings, 0 replies; 3+ messages in thread
From: Scott Wood @ 2013-11-15 19:08 UTC (permalink / raw)
To: Jason Jin; +Cc: linuxppc-dev
On Fri, 2013-11-15 at 14:06 +0800, Jason Jin wrote:
> In u-boot, when set the video as console, the name 'vga' is used
> as a general name for the video device, during the fdt_fixup_stdout
> process, the 'vga' name is used to search in the dtb to setup the
> 'linux,stdout-path' node. Though the P1022 DIU is not VGA-compatible device,
> to meet the 'vga' name used in u-boot, the vga alias node is added for
> P1022 in this patch. At the same time, a display alias is also added
> so that no other components grow dependencies on the vga alias node.
Please explain this in a brief code comment (e.g. /* inaccurate vga name
for U-Boot compatibility */), not just the commit message.
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] powerpc: Add a vga alias node for P1022
@ 2015-08-17 7:50 Dongsheng Wang
0 siblings, 0 replies; 3+ messages in thread
From: Dongsheng Wang @ 2015-08-17 7:50 UTC (permalink / raw)
To: scottwood; +Cc: Jason.Jin, linuxppc-dev, devicetree, Wang Dongsheng
From: Jason Jin <Jason.Jin@freescale.com>
In u-boot, when set the video as console, the name 'vga' is used
as a general name for the video device, during the fdt_fixup_stdout
process, the 'vga' name is used to search in the dtb to setup the
'linux,stdout-path' node. Though the P1022 DIU is not VGA-compatible
device, to meet the 'vga' name used in u-boot, the vga alias node is
added for P1022 in this patch. At the same time, a display alias is
also added so that no other components grow dependencies on the vga
alias node.
Signed-off-by: Jason Jin <Jason.Jin@freescale.com>
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
index ebf2022..426bf41 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-post.dtsi
@@ -175,7 +175,7 @@
/include/ "pq3-gpio-0.dtsi"
- display@10000 {
+ display: display@10000 {
compatible = "fsl,diu", "fsl,p1022-diu";
reg = <0x10000 1000>;
interrupts = <64 2 0 0>;
diff --git a/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi b/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
index 1956dea..de76ae8 100644
--- a/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
+++ b/arch/powerpc/boot/dts/fsl/p1022si-pre.dtsi
@@ -50,6 +50,8 @@
pci0 = &pci0;
pci1 = &pci1;
pci2 = &pci2;
+ vga = &display;
+ display = &display;
};
cpus {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-17 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-15 6:06 [PATCH] powerpc: Add a vga alias node for P1022 Jason Jin
2013-11-15 19:08 ` Scott Wood
2015-08-17 7:50 Dongsheng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).