From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@fr.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] offb: make the screen properties endian safe
Date: Thu, 21 Nov 2013 09:50:01 +1100 [thread overview]
Message-ID: <1384987801.26969.114.camel@pasglop> (raw)
In-Reply-To: <1383212192-3622-1-git-send-email-clg@fr.ibm.com>
On Thu, 2013-10-31 at 10:36 +0100, Cédric Le Goater wrote:
> The "screen" properties : depth, width, height, linebytes need
> to be converted to the host endian order when read from the device
> tree.
>
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
> ---
Did you actually test that ? IE, using emulated VGA in qemu for
example ?
I'm asking because there are a few interesting nits here...
- fbdev *generally* assume native endian framebuffer, but of course
under qemu today, the adapter will use a big endian frame buffer
aperture. You can compile in support for foreign endian but I don't know
how that actually works.
- The setcolreg fix ... the "value" is used 2 lines above your endian
swap, is that correct ?
Cheers
Ben.
> Changes in v2:
>
> - replaced be32_to_cpu() by be32_to_cpup()
> - fixed setcolreg ops
>
> drivers/video/offb.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/offb.c b/drivers/video/offb.c
> index 0c4f343..68e8415 100644
> --- a/drivers/video/offb.c
> +++ b/drivers/video/offb.c
> @@ -120,7 +120,7 @@ static int offb_setcolreg(u_int regno, u_int red, u_int green, u_int blue,
> mask <<= info->var.transp.offset;
> value |= mask;
> }
> - pal[regno] = value;
> + pal[regno] = cpu_to_be32(value);
> return 0;
> }
>
> @@ -536,7 +536,7 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> unsigned int flags, rsize, addr_prop = 0;
> unsigned long max_size = 0;
> u64 rstart, address = OF_BAD_ADDR;
> - const u32 *pp, *addrp, *up;
> + const __be32 *pp, *addrp, *up;
> u64 asize;
> int foreign_endian = 0;
>
> @@ -552,25 +552,25 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
> if (pp == NULL)
> pp = of_get_property(dp, "depth", &len);
> if (pp && len == sizeof(u32))
> - depth = *pp;
> + depth = be32_to_cpup(pp);
>
> pp = of_get_property(dp, "linux,bootx-width", &len);
> if (pp == NULL)
> pp = of_get_property(dp, "width", &len);
> if (pp && len == sizeof(u32))
> - width = *pp;
> + width = be32_to_cpup(pp);
>
> pp = of_get_property(dp, "linux,bootx-height", &len);
> if (pp == NULL)
> pp = of_get_property(dp, "height", &len);
> if (pp && len == sizeof(u32))
> - height = *pp;
> + height = be32_to_cpup(pp);
>
> pp = of_get_property(dp, "linux,bootx-linebytes", &len);
> if (pp == NULL)
> pp = of_get_property(dp, "linebytes", &len);
> if (pp && len == sizeof(u32) && (*pp != 0xffffffffu))
> - pitch = *pp;
> + pitch = be32_to_cpup(pp);
> else
> pitch = width * ((depth + 7) / 8);
>
next prev parent reply other threads:[~2013-11-20 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 16:14 [PATCH] offb: make the screen properties endian safe Cédric Le Goater
2013-10-31 2:08 ` Benjamin Herrenschmidt
2013-10-31 9:36 ` [PATCH v2] " Cédric Le Goater
2013-11-20 22:50 ` Benjamin Herrenschmidt [this message]
2013-11-21 15:45 ` Cedric Le Goater
2013-11-21 19:57 ` Benjamin Herrenschmidt
2013-11-23 17:38 ` Cedric Le Goater
2013-11-23 21:04 ` Benjamin Herrenschmidt
2013-12-04 16:47 ` Cedric Le Goater
2013-12-04 16:49 ` [PATCH v3 1/2] offb: little endian fixes Cédric Le Goater
2013-12-04 16:49 ` [PATCH v3 2/2] offb: add palette hack for little endian Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384987801.26969.114.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=clg@fr.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).