From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cedric Le Goater <clg@fr.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] offb: make the screen properties endian safe
Date: Sun, 24 Nov 2013 08:04:03 +1100 [thread overview]
Message-ID: <1385240643.4882.133.camel@pasglop> (raw)
In-Reply-To: <5290E820.2080809@fr.ibm.com>
On Sat, 2013-11-23 at 18:38 +0100, Cedric Le Goater wrote:
> So, 32bpp "works" but 16 is broken ... I guess my palette fix is just a lucky
> hack and I need to dig deeper in fb code to have a better understanding of
> the color map.
>
> I should have provided you two patches in the first place. Do you want the
> device tree data fixes for the frame buffer screen properties ? It helps to
> have a display for little endian guests even if the colors are wrong.
Before you pull your hair out, check if it works in BE :-)
Cheers,
Ben.
next prev parent reply other threads:[~2013-11-23 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 16:14 [PATCH] offb: make the screen properties endian safe Cédric Le Goater
2013-10-31 2:08 ` Benjamin Herrenschmidt
2013-10-31 9:36 ` [PATCH v2] " Cédric Le Goater
2013-11-20 22:50 ` Benjamin Herrenschmidt
2013-11-21 15:45 ` Cedric Le Goater
2013-11-21 19:57 ` Benjamin Herrenschmidt
2013-11-23 17:38 ` Cedric Le Goater
2013-11-23 21:04 ` Benjamin Herrenschmidt [this message]
2013-12-04 16:47 ` Cedric Le Goater
2013-12-04 16:49 ` [PATCH v3 1/2] offb: little endian fixes Cédric Le Goater
2013-12-04 16:49 ` [PATCH v3 2/2] offb: add palette hack for little endian Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385240643.4882.133.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=clg@fr.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).