From: Scott Wood <scottwood@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: Pull request: scottwood/linux.git
Date: Fri, 17 Jan 2014 17:00:29 -0600 [thread overview]
Message-ID: <1389999629.24905.290.camel@snotra.buserror.net> (raw)
In-Reply-To: <1389758064.6933.56.camel@pasglop>
On Wed, 2014-01-15 at 14:54 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2014-01-10 at 18:44 -0600, Scott Wood wrote:
> > Highlights include 32-bit booke relocatable support, e6500 hardware
> > tablewalk support, various e500 SPE fixes, some new/revived boards, and
> > e6500 deeper idle and altivec powerdown modes.
>
> This breaks WSP (A2) build with 64K pages:
>
> /home/benh/linux-powerpc-test/arch/powerpc/mm/tlb_low_64e.S: Assembler messages:
> /home/benh/linux-powerpc-test/arch/powerpc/mm/tlb_low_64e.S:334: Error: can't resolve `L0^A' {*ABS* section} - `PUD_SHIFT' {*UND* section}
> /home/benh/linux-powerpc-test/arch/powerpc/mm/tlb_low_64e.S:334: Error: expression too complex
> /home/benh/linux-powerpc-test/arch/powerpc/mm/tlb_low_64e.S:334: Error: operand out of range (67 is not between 0 and 63)
> make[2]: *** [arch/powerpc/mm/tlb_low_64e.o] Error 1
>
> I'm merging anyway because nobody uses WSP anymore (I'm keen to remove it by 3.15 or so)
Does this apply to all non-FSL 64-bit book3e, or is there anything else
that is still in use?
> but in the meantime you may want to fix it (probably just ifdef the PUD level walk on
> 64k pages, look at what I do elsewhere).
Ifdeffing the PUD level doesn't make much sense in this case (other than
perhaps as the least intrusive way to make the error go away) because
that codepath is specific to e6500 which doesn't support 64K pages. The
whole e6500 section should be ifdeffed out if there are 64K pages (or
really, if CONFIG_PPC_FSL_BOOK3E isn't defined, and 64K pages should
conflict with PPC_FSL_BOOK3E).
-Scott
next prev parent reply other threads:[~2014-01-17 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 0:44 Pull request: scottwood/linux.git Scott Wood
2014-01-15 3:54 ` Benjamin Herrenschmidt
2014-01-17 23:00 ` Scott Wood [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-23 21:21 Scott Wood
2014-01-18 1:22 Scott Wood
2014-01-28 6:20 ` Anatolij Gustschin
2013-11-22 23:21 Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389999629.24905.290.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).