* powerpc: CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS?
@ 2014-05-22 9:09 Paul Bolle
2014-05-22 13:17 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-22 9:09 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev
In v3.2 checks for CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS and
CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS were added to
arch/powerpc/platforms/wsp/wsp_pci.c. The check for
CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS was dropped again in v3.3.
Neither of these macros have ever had a matching Kconfig symbol. So they
have always evaluated to false.
Is it perhaps intended that one sets the macro still in the tree,
CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS, manually? And is that macro
still needed?
Paul Bolle
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: powerpc: CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS?
2014-05-22 9:09 powerpc: CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS? Paul Bolle
@ 2014-05-22 13:17 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2014-05-22 13:17 UTC (permalink / raw)
To: Paul Bolle; +Cc: linuxppc-dev, Paul Mackerras
On Thu, 2014-05-22 at 11:09 +0200, Paul Bolle wrote:
> In v3.2 checks for CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS and
> CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS were added to
> arch/powerpc/platforms/wsp/wsp_pci.c. The check for
> CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS was dropped again in v3.3.
>
> Neither of these macros have ever had a matching Kconfig symbol. So they
> have always evaluated to false.
>
> Is it perhaps intended that one sets the macro still in the tree,
> CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS, manually? And is that macro
> still needed?
To be honest we can kill all of the wsp code I think ... The project
got canned and I don't think anybody still uses them.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-22 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 9:09 powerpc: CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS? Paul Bolle
2014-05-22 13:17 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).