* [PATCH 5/14] powerpc/mpc5xxx: delete unneeded test before of_node_put
@ 2014-08-08 10:07 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2014-08-08 10:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kernel-janitors, linux-kernel, Paul Mackerras,
Uwe Kleine-König, linuxppc-dev
From: Julia Lawall <Julia.Lawall@lip6.fr>
Of_node_put supports NULL as its argument, so the initial test is not
necessary.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
-if (e)
of_node_put(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/powerpc/sysdev/mpc5xxx_clocks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/mpc5xxx_clocks.c b/arch/powerpc/sysdev/mpc5xxx_clocks.c
index 5492dc5..f4f0301 100644
--- a/arch/powerpc/sysdev/mpc5xxx_clocks.c
+++ b/arch/powerpc/sysdev/mpc5xxx_clocks.c
@@ -26,8 +26,7 @@ unsigned long mpc5xxx_get_bus_frequency(struct device_node *node)
of_node_put(node);
node = np;
}
- if (node)
- of_node_put(node);
+ of_node_put(node);
return p_bus_freq ? *p_bus_freq : 0;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-08 10:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-08 10:07 [PATCH 5/14] powerpc/mpc5xxx: delete unneeded test before of_node_put Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).