* [PATCH] Avoid bashisms
@ 2014-08-04 19:36 av1474
2014-09-12 8:25 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: av1474 @ 2014-08-04 19:36 UTC (permalink / raw)
To: linuxppc-dev
>From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
From: malc <av1474@comtv.ru>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] Avoid bashisms
---
arch/powerpc/kernel/prom_init_check.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..413f792 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -50,22 +50,22 @@ do
done
# ignore register save/restore funcitons
- if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_restgpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_restgpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_rest32gpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_savegpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_savegpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_save32gpr_" ]; then
OK=1
fi
--
2.0.0.GIT
--
mailto:av1474@comtv.ru
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Avoid bashisms
2014-08-04 19:36 [PATCH] Avoid bashisms av1474
@ 2014-09-12 8:25 ` Michael Ellerman
2014-09-12 18:55 ` powerpc: Avoid bashisms in prom_init_check.sh av1474
[not found] ` <87r3zgd5xx.fsf_-___23348.7322264866$1410551821$gmane$org@comtv.ru>
0 siblings, 2 replies; 4+ messages in thread
From: Michael Ellerman @ 2014-09-12 8:25 UTC (permalink / raw)
To: av1474; +Cc: linuxppc-dev
On Mon, 2014-08-04 at 23:36 +0400, av1474@comtv.ru wrote:
> From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
> From: malc <av1474@comtv.ru>
> Date: Mon, 4 Aug 2014 23:28:05 +0400
> Subject: [PATCH] Avoid bashisms
Hi malc,
If you want us to take your patch, please resend with:
- a better subject, eg:
powerpc: Avoid bashisms in prom_init_check.sh
- a Signed-off-by line.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* powerpc: Avoid bashisms in prom_init_check.sh
2014-09-12 8:25 ` Michael Ellerman
@ 2014-09-12 18:55 ` av1474
[not found] ` <87r3zgd5xx.fsf_-___23348.7322264866$1410551821$gmane$org@comtv.ru>
1 sibling, 0 replies; 4+ messages in thread
From: av1474 @ 2014-09-12 18:55 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
>From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
From: malc <av1474 at comtv.ru>
Date: Mon, 4 Aug 2014 23:28:05 +0400
Subject: [PATCH] powerpc: Avoid bashisms in prom_init_check.sh
Signed-off-by: Vassili Karpov <av1474@comtv.ru>
---
arch/powerpc/kernel/prom_init_check.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..413f792 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -50,22 +50,22 @@ do
done
# ignore register save/restore funcitons
- if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_restgpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_restgpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_rest32gpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+ if [ "$(printf %.9s $UNDEF)" = "_savegpr_" ]; then
OK=1
fi
- if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
+ if [ "$(printf %.10s $UNDEF)" = "_savegpr0_" ]; then
OK=1
fi
- if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
+ if [ "$(printf %.11s $UNDEF)" = "_save32gpr_" ]; then
OK=1
fi
--
2.0.0.GIT
> On Mon, 2014-08-04 at 23:36 +0400, av1474@comtv.ru wrote:
>> From 300a98f895dc7e2167cf379408322a9607907761 Mon Sep 17 00:00:00 2001
>> From: malc <av1474@comtv.ru>
>> Date: Mon, 4 Aug 2014 23:28:05 +0400
>> Subject: [PATCH] Avoid bashisms
>
> Hi malc,
>
> If you want us to take your patch, please resend with:
> - a better subject, eg:
> powerpc: Avoid bashisms in prom_init_check.sh
> - a Signed-off-by line.
>
> cheers
Thanks for suggestions,
--
mailto:av1474@comtv.ru
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Simplify symbol check in prom_init_check.sh
[not found] ` <87r3zgd5xx.fsf_-___23348.7322264866$1410551821$gmane$org@comtv.ru>
@ 2014-09-13 8:20 ` Andreas Schwab
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2014-09-13 8:20 UTC (permalink / raw)
To: av1474; +Cc: linuxppc-dev
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
arch/powerpc/kernel/prom_init_check.sh | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/kernel/prom_init_check.sh b/arch/powerpc/kernel/prom_init_check.sh
index fe8e54b..12640f7 100644
--- a/arch/powerpc/kernel/prom_init_check.sh
+++ b/arch/powerpc/kernel/prom_init_check.sh
@@ -50,24 +50,14 @@ do
done
# ignore register save/restore funcitons
- if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
+ case $UNDEF in
+ _restgpr_*|_restgpr0_*|_rest32gpr_*)
OK=1
- fi
- if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
- OK=1
- fi
- if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
- OK=1
- fi
- if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
+ ;;
+ _savegpr_*|_savegpr0_*|_save32gpr_*)
OK=1
- fi
- if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
- OK=1
- fi
- if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
- OK=1
- fi
+ ;;
+ esac
if [ $OK -eq 0 ]; then
ERROR=1
--
2.1.0
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-13 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04 19:36 [PATCH] Avoid bashisms av1474
2014-09-12 8:25 ` Michael Ellerman
2014-09-12 18:55 ` powerpc: Avoid bashisms in prom_init_check.sh av1474
[not found] ` <87r3zgd5xx.fsf_-___23348.7322264866$1410551821$gmane$org@comtv.ru>
2014-09-13 8:20 ` [PATCH] Simplify symbol check " Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).