linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
@ 2014-09-17 16:36 Christophe Leroy
  2014-09-17 16:40 ` Scott Wood
  0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2014-09-17 16:36 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras
  Cc: scottwood, linuxppc-dev, linux-kernel

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>

---
Changes in v2:
- Patch number 10 removed, it was implementing a 16 bit alignment of the PGDIR.
It is not worth potentially wasting up to 64k of memory just for removing one
instruction (ori).
- Preserve r11 while calculating the level 2 address, therefore no more need to
save r11 into CR.

Changes in v3:
- Few fixes following review from Joachim Tjernlund
- Removed the major hack which was saving resisters in memory for CPU6 errata
- Invalidating non present TLB entries earlier (in head_8xx instead of fault.c)

 arch/powerpc/Kconfig                     |   2 +-
 arch/powerpc/include/asm/mmu-8xx.h       |   2 +
 arch/powerpc/include/asm/pgtable-ppc32.h |  20 ++
 arch/powerpc/include/asm/pte-8xx.h       |   7 +-
 arch/powerpc/include/asm/reg.h           |   3 +-
 arch/powerpc/kernel/head_8xx.S           | 370 ++++++++++++-------------
 arch/powerpc/mm/fault.c                  |   9 +-
 7 files changed, 203 insertions(+), 210 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
  2014-09-17 16:36 [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages Christophe Leroy
@ 2014-09-17 16:40 ` Scott Wood
  2014-09-17 20:33   ` christophe leroy
  0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2014-09-17 16:40 UTC (permalink / raw)
  To: Christophe Leroy; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel

On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote:
> This patchset:
> 1) provides several MMU TLB handling optimisation on MPC8xx.
> 2) adds support of 16k pages on MPC8xx.
> All changes have been successfully tested on a custom board equipped with MPC885
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous
patchset -- have they changed?

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
  2014-09-17 16:40 ` Scott Wood
@ 2014-09-17 20:33   ` christophe leroy
  2014-09-17 20:34     ` Scott Wood
  0 siblings, 1 reply; 6+ messages in thread
From: christophe leroy @ 2014-09-17 20:33 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel


Le 17/09/2014 18:40, Scott Wood a écrit :
> On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote:
>> This patchset:
>> 1) provides several MMU TLB handling optimisation on MPC8xx.
>> 2) adds support of 16k pages on MPC8xx.
>> All changes have been successfully tested on a custom board equipped with MPC885
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous
> patchset -- have they changed?
>
> -Scott
>
No, only 3, 7, 17 are changed, and 20,21 are new.
I didn't notice you already applied some. How should I then proceed now 
for the remaining ones ? Submit a new set ?

Thanks
Christophe

---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active.
http://www.avast.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
  2014-09-17 20:33   ` christophe leroy
@ 2014-09-17 20:34     ` Scott Wood
  2014-10-13 16:44       ` leroy christophe
  0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2014-09-17 20:34 UTC (permalink / raw)
  To: christophe leroy; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel

On Wed, 2014-09-17 at 22:33 +0200, christophe leroy wrote:
> Le 17/09/2014 18:40, Scott Wood a écrit :
> > On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote:
> >> This patchset:
> >> 1) provides several MMU TLB handling optimisation on MPC8xx.
> >> 2) adds support of 16k pages on MPC8xx.
> >> All changes have been successfully tested on a custom board equipped with MPC885
> >>
> >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> >> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous
> > patchset -- have they changed?
> >
> > -Scott
> >
> No, only 3, 7, 17 are changed, and 20,21 are new.
> I didn't notice you already applied some. How should I then proceed now 
> for the remaining ones ? Submit a new set ?
> 

No, I'll just skip the ones I've already applied.

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
  2014-09-17 20:34     ` Scott Wood
@ 2014-10-13 16:44       ` leroy christophe
  2014-10-14  9:16         ` Scott Wood
  0 siblings, 1 reply; 6+ messages in thread
From: leroy christophe @ 2014-10-13 16:44 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel


Le 17/09/2014 22:34, Scott Wood a écrit :
> On Wed, 2014-09-17 at 22:33 +0200, christophe leroy wrote:
>> Le 17/09/2014 18:40, Scott Wood a écrit :
>>> On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote:
>>>> This patchset:
>>>> 1) provides several MMU TLB handling optimisation on MPC8xx.
>>>> 2) adds support of 16k pages on MPC8xx.
>>>> All changes have been successfully tested on a custom board equipped with MPC885
>>>>
>>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>>> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>> I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous
>>> patchset -- have they changed?
>>>
>>> -Scott
>>>
>> No, only 3, 7, 17 are changed, and 20,21 are new.
>> I didn't notice you already applied some. How should I then proceed now
>> for the remaining ones ? Submit a new set ?
>>
> No, I'll just skip the ones I've already applied.
>
>
I think I took into account all Joakim's and your's comments in v4.
Since I submitted v4, I think I didn't get any new comment.
What's the way forward to get the remaining ones applied ?

Christophe

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages
  2014-10-13 16:44       ` leroy christophe
@ 2014-10-14  9:16         ` Scott Wood
  0 siblings, 0 replies; 6+ messages in thread
From: Scott Wood @ 2014-10-14  9:16 UTC (permalink / raw)
  To: leroy christophe; +Cc: linuxppc-dev, Paul Mackerras, linux-kernel

On Mon, 2014-10-13 at 18:44 +0200, leroy christophe wrote:
> Le 17/09/2014 22:34, Scott Wood a écrit :
> > On Wed, 2014-09-17 at 22:33 +0200, christophe leroy wrote:
> >> Le 17/09/2014 18:40, Scott Wood a écrit :
> >>> On Wed, 2014-09-17 at 18:36 +0200, Christophe Leroy wrote:
> >>>> This patchset:
> >>>> 1) provides several MMU TLB handling optimisation on MPC8xx.
> >>>> 2) adds support of 16k pages on MPC8xx.
> >>>> All changes have been successfully tested on a custom board equipped with MPC885
> >>>>
> >>>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> >>>> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr>
> >>> I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous
> >>> patchset -- have they changed?
> >>>
> >>> -Scott
> >>>
> >> No, only 3, 7, 17 are changed, and 20,21 are new.
> >> I didn't notice you already applied some. How should I then proceed now
> >> for the remaining ones ? Submit a new set ?
> >>
> > No, I'll just skip the ones I've already applied.
> >
> >
> I think I took into account all Joakim's and your's comments in v4.
> Since I submitted v4, I think I didn't get any new comment.
> What's the way forward to get the remaining ones applied ?

I haven't had a chance to review v4 yet.  I'm currently at conferences
and will be on vacation next week, but I will try to look at them soon
after that.

-Scott

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-10-14  9:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 16:36 [PATCH v3 00/21] powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages Christophe Leroy
2014-09-17 16:40 ` Scott Wood
2014-09-17 20:33   ` christophe leroy
2014-09-17 20:34     ` Scott Wood
2014-10-13 16:44       ` leroy christophe
2014-10-14  9:16         ` Scott Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).