From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: bhelgaas@google.com, benh@au1.ibm.com, gwshan@linux.vnet.ibm.com
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V14 06/21] PCI: Index IOV resources in the conventional style
Date: Fri, 20 Mar 2015 11:06:22 +0800 [thread overview]
Message-ID: <1426820797-6267-7-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
In-Reply-To: <1426820797-6267-1-git-send-email-weiyang@linux.vnet.ibm.com>
From: Bjorn Helgaas <bhelgaas@google.com>
Most of PCI uses "res = &dev->resource[i]", not "res = dev->resource + i".
Use that style in iov.c also.
No functional change.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/iov.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 5bca0e1..27b98c3 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -95,7 +95,7 @@ static int virtfn_add(struct pci_dev *dev, int id, int reset)
virtfn->multifunction = 0;
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
- res = dev->resource + PCI_IOV_RESOURCES + i;
+ res = &dev->resource[i + PCI_IOV_RESOURCES];
if (!res->parent)
continue;
virtfn->resource[i].name = pci_name(virtfn);
@@ -212,7 +212,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn)
nres = 0;
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
bars |= (1 << (i + PCI_IOV_RESOURCES));
- res = dev->resource + PCI_IOV_RESOURCES + i;
+ res = &dev->resource[i + PCI_IOV_RESOURCES];
if (res->parent)
nres++;
}
@@ -373,7 +373,7 @@ found:
nres = 0;
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
- res = dev->resource + PCI_IOV_RESOURCES + i;
+ res = &dev->resource[i + PCI_IOV_RESOURCES];
bar64 = __pci_read_base(dev, pci_bar_unknown, res,
pos + PCI_SRIOV_BAR + i * 4);
if (!res->flags)
@@ -417,7 +417,7 @@ found:
failed:
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
- res = dev->resource + PCI_IOV_RESOURCES + i;
+ res = &dev->resource[i + PCI_IOV_RESOURCES];
res->flags = 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2015-03-20 3:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 3:06 [PATCH V14 00/21] Enable SRIOV on Power8 Wei Yang
2015-03-20 3:06 ` [PATCH V14 01/21] powerpc/pci: Refactor pci_dn Wei Yang
2015-03-20 3:06 ` [PATCH V14 02/21] powerpc/powernv: Use pci_dn, not device_node, in PCI config accessor Wei Yang
2015-03-20 3:06 ` [PATCH V14 03/21] PCI: Print more info in sriov_enable() error message Wei Yang
2015-03-20 3:06 ` [PATCH V14 04/21] PCI: Print PF SR-IOV resource that contains all VF(n) BAR space Wei Yang
2015-03-20 3:06 ` [PATCH V14 05/21] PCI: Keep individual VF BAR size in struct pci_sriov Wei Yang
2015-03-20 3:06 ` Wei Yang [this message]
2015-03-20 3:06 ` [PATCH V14 07/21] PCI: Refresh First VF Offset and VF Stride when updating NumVFs Wei Yang
2015-03-20 3:06 ` [PATCH V14 08/21] PCI: Calculate maximum number of buses required for VFs Wei Yang
2015-03-20 3:06 ` [PATCH V14 09/21] PCI: Export pci_iov_virtfn_bus() and pci_iov_virtfn_devfn() Wei Yang
2015-03-20 3:06 ` [PATCH V14 10/21] PCI: Add pcibios_sriov_enable() and pcibios_sriov_disable() Wei Yang
2015-03-20 5:46 ` Gavin Shan
2015-03-20 3:06 ` [PATCH V14 11/21] PCI: Add pcibios_iov_resource_alignment() interface Wei Yang
2015-03-20 3:06 ` [PATCH V14 12/21] PCI: Consider additional PF's IOV BAR alignment in sizing and assigning Wei Yang
2015-03-20 3:06 ` [PATCH V14 13/21] powerpc/pci: Don't unset PCI resources for VFs Wei Yang
2015-03-20 3:06 ` [PATCH V14 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically Wei Yang
2015-03-20 21:22 ` Bjorn Helgaas
2015-03-20 3:06 ` [PATCH V14 15/21] powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe Wei Yang
2015-03-20 3:06 ` [PATCH V14 16/21] powerpc/powernv: Implement pcibios_iov_resource_alignment() on powernv Wei Yang
2015-03-20 3:06 ` [PATCH V14 17/21] powerpc/powernv: Shift VF resource with an offset Wei Yang
2015-03-23 23:22 ` Daniel Axtens
2015-03-24 1:54 ` Wei Yang
2015-03-20 3:06 ` [PATCH V14 18/21] powerpc/powernv: Reserve additional space for IOV BAR, with m64_per_iov supported Wei Yang
2015-03-20 3:06 ` [PATCH V14 19/21] powerpc/powernv: Group VF PE when IOV BAR is big on PHB3 Wei Yang
2015-03-20 3:06 ` [PATCH V14 20/21] powerpc/pci: Remove unused struct pci_dn.pcidev field Wei Yang
2015-03-20 3:06 ` [PATCH V14 21/21] powerpc/pci: Add PCI resource alignment documentation Wei Yang
2015-03-20 5:43 ` [PATCH V14 00/21] Enable SRIOV on Power8 Gavin Shan
2015-03-20 14:34 ` Bjorn Helgaas
2015-03-20 21:05 ` Benjamin Herrenschmidt
2015-03-20 21:16 ` Bjorn Helgaas
2015-03-20 21:28 ` Benjamin Herrenschmidt
2015-03-20 21:20 ` Bjorn Helgaas
2015-03-20 22:24 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426820797-6267-7-git-send-email-weiyang@linux.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=benh@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).