linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Wei Yang <weiyang@linux.vnet.ibm.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH V14 00/21] Enable SRIOV on Power8
Date: Sat, 21 Mar 2015 08:05:02 +1100	[thread overview]
Message-ID: <1426885502.4770.159.camel@au1.ibm.com> (raw)
In-Reply-To: <CAErSpo6zTLyDK+aaHK6+uwfs579Qq1vbXDx4rb9L4uNq=24dVA@mail.gmail.com>

On Fri, 2015-03-20 at 09:34 -0500, Bjorn Helgaas wrote:
> On Fri, Mar 20, 2015 at 12:43 AM, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> > On Fri, Mar 20, 2015 at 11:06:16AM +0800, Wei Yang wrote:
> >
> > [snip]
> >
> >>---
> >>v14:
> >>   * call ppc_md.pcibios_fixup_sriov() in pcibios_add_device
> >>   * add more explanation in change log
> >>   * Following patches have been reordered to the beginning.
> >>     "EEH refactor to use pci_dn":
> >>     8ec20d6 powerpc/powernv: Use pci_dn, not device_node, in PCI config accessor
> >>     a3460fc powerpc/pci: Refactor pci_dn
> >>     These two patches will be modified to merge with other patches which are
> >>     under discussion/review in ppc mail list. Some changes may also be made in
> >>     other patches, which I didn't include them in this series, so that the
> >>     auto build robot could work on this.
> >
> > The comment here isn't precise enough and not the things I suggested before.
> > Those 2 patches have been split into 3 patches (A/B/C). Some other EEH
> > cleanup/refactor patches depends on A/B and those patches would be merged
> > before your SRIOV patches to PowerPC tree. C, which I already sent to you,
> > need to be integrated to your patchset right after the following one:
> >
> > powerpc/pci: Don't unset PCI resources for VFs
> >
> > I guess you can move the patches around after checking if Bjorn has further
> > concerns/comments.
> 
> I think we need to move forward on this soon so it has at least a
> little time in -next.  And it sounds like I cannot merge this v14
> as-is because it doesn't include these additional EEH cleanup/refactor
> patches?  (If they are only cleanup and refactoring, I don't
> understand why they would be required, but I haven't seen them, so I'm
> taking your word for it.)
> 
> So I guess I'm waiting for v15.  Don't wait for my comments on v14.
> Ideally I'd also like an ack from a powerpc maintainer.  This has so
> much powerpc impact that I'm not comfortable stuffing this in without
> their OK.

The other option is you put the generic changes in a topic branch which
both of us merge and I take care of the rest.

Cheers,
Ben.

> Bjorn

  reply	other threads:[~2015-03-20 21:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20  3:06 [PATCH V14 00/21] Enable SRIOV on Power8 Wei Yang
2015-03-20  3:06 ` [PATCH V14 01/21] powerpc/pci: Refactor pci_dn Wei Yang
2015-03-20  3:06 ` [PATCH V14 02/21] powerpc/powernv: Use pci_dn, not device_node, in PCI config accessor Wei Yang
2015-03-20  3:06 ` [PATCH V14 03/21] PCI: Print more info in sriov_enable() error message Wei Yang
2015-03-20  3:06 ` [PATCH V14 04/21] PCI: Print PF SR-IOV resource that contains all VF(n) BAR space Wei Yang
2015-03-20  3:06 ` [PATCH V14 05/21] PCI: Keep individual VF BAR size in struct pci_sriov Wei Yang
2015-03-20  3:06 ` [PATCH V14 06/21] PCI: Index IOV resources in the conventional style Wei Yang
2015-03-20  3:06 ` [PATCH V14 07/21] PCI: Refresh First VF Offset and VF Stride when updating NumVFs Wei Yang
2015-03-20  3:06 ` [PATCH V14 08/21] PCI: Calculate maximum number of buses required for VFs Wei Yang
2015-03-20  3:06 ` [PATCH V14 09/21] PCI: Export pci_iov_virtfn_bus() and pci_iov_virtfn_devfn() Wei Yang
2015-03-20  3:06 ` [PATCH V14 10/21] PCI: Add pcibios_sriov_enable() and pcibios_sriov_disable() Wei Yang
2015-03-20  5:46   ` Gavin Shan
2015-03-20  3:06 ` [PATCH V14 11/21] PCI: Add pcibios_iov_resource_alignment() interface Wei Yang
2015-03-20  3:06 ` [PATCH V14 12/21] PCI: Consider additional PF's IOV BAR alignment in sizing and assigning Wei Yang
2015-03-20  3:06 ` [PATCH V14 13/21] powerpc/pci: Don't unset PCI resources for VFs Wei Yang
2015-03-20  3:06 ` [PATCH V14 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically Wei Yang
2015-03-20 21:22   ` Bjorn Helgaas
2015-03-20  3:06 ` [PATCH V14 15/21] powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe Wei Yang
2015-03-20  3:06 ` [PATCH V14 16/21] powerpc/powernv: Implement pcibios_iov_resource_alignment() on powernv Wei Yang
2015-03-20  3:06 ` [PATCH V14 17/21] powerpc/powernv: Shift VF resource with an offset Wei Yang
2015-03-23 23:22   ` Daniel Axtens
2015-03-24  1:54     ` Wei Yang
2015-03-20  3:06 ` [PATCH V14 18/21] powerpc/powernv: Reserve additional space for IOV BAR, with m64_per_iov supported Wei Yang
2015-03-20  3:06 ` [PATCH V14 19/21] powerpc/powernv: Group VF PE when IOV BAR is big on PHB3 Wei Yang
2015-03-20  3:06 ` [PATCH V14 20/21] powerpc/pci: Remove unused struct pci_dn.pcidev field Wei Yang
2015-03-20  3:06 ` [PATCH V14 21/21] powerpc/pci: Add PCI resource alignment documentation Wei Yang
2015-03-20  5:43 ` [PATCH V14 00/21] Enable SRIOV on Power8 Gavin Shan
2015-03-20 14:34   ` Bjorn Helgaas
2015-03-20 21:05     ` Benjamin Herrenschmidt [this message]
2015-03-20 21:16       ` Bjorn Helgaas
2015-03-20 21:28         ` Benjamin Herrenschmidt
2015-03-20 21:20 ` Bjorn Helgaas
2015-03-20 22:24   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426885502.4770.159.camel@au1.ibm.com \
    --to=benh@au1.ibm.com \
    --cc=bhelgaas@google.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=weiyang@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).