* [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
@ 2015-04-15 8:17 Jia Hongtao
2015-05-26 6:33 ` Hongtao Jia
0 siblings, 1 reply; 7+ messages in thread
From: Jia Hongtao @ 2015-04-15 8:17 UTC (permalink / raw)
To: scottwood; +Cc: hongtao.jia, devicetree, rui.zhang, robh+dt, linuxppc-dev
This is Thermal Monitoring Unit for QorIQ platform.
Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
---
Changes from V1:
* Provide more details on compatible and calibration properties.
.../devicetree/bindings/thermal/qoriq-thermal.txt | 68 ++++++++++++++++++
arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi | 82 ++++++++++++++++++++++
arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 1 +
3 files changed, 151 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
new file mode 100644
index 0000000..48e7fff
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
@@ -0,0 +1,68 @@
+* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
+
+Required properties:
+- compatible : Must include "fsl,qoriq-tmu". The version of the device is
+ determined by the TMU IP Block Revision Register (IPBRR0) at
+ offset 0x0BF8.
+ Table of correspondences between IPBRR0 values and example chips:
+ Value Device
+ ---------- -----
+ 0x01900102 T1040
+- reg : Address range of TMU registers.
+- interrupts : Contains the interrupt for TMU.
+- calibration : Calibration table for TMU. This is required to determine
+ what a specific sensor reading translates to in degrees Celsius.
+ There are four calibration config ranges, for each range we need
+ a couple of calibration data formatted like <TTCFGR, TSCFGR>.
+ Freescale provides the data required.
+
+Example:
+
+tmu@f0000 {
+ compatible = "fsl,qoriq-tmu";
+ reg = <0xf0000 0x1000>;
+ interrupts = <18 2 0 0>;
+ calibration = <0x00000000 0x0000000f
+ 0x00000001 0x00000017
+ 0x00000002 0x0000001e
+ 0x00000003 0x00000026
+ 0x00000004 0x0000002e
+ 0x00000005 0x00000035
+ 0x00000006 0x0000003d
+ 0x00000007 0x00000044
+ 0x00000008 0x0000004c
+ 0x00000009 0x00000053
+ 0x0000000a 0x0000005b
+ 0x0000000b 0x00000062
+
+ 0x00010000 0x00000011
+ 0x00010001 0x00000019
+ 0x00010002 0x00000021
+ 0x00010003 0x0000002a
+ 0x00010004 0x00000032
+ 0x00010005 0x0000003a
+ 0x00010006 0x00000042
+ 0x00010007 0x0000004b
+ 0x00010008 0x00000053
+ 0x00010009 0x0000005b
+ 0x0001000a 0x00000063
+
+ 0x00020000 0x00000012
+ 0x00020001 0x0000001b
+ 0x00020002 0x00000024
+ 0x00020003 0x0000002c
+ 0x00020004 0x00000035
+ 0x00020005 0x0000003d
+ 0x00020006 0x00000046
+ 0x00020007 0x0000004e
+ 0x00020008 0x00000057
+
+ 0x00030000 0x00000009
+ 0x00030001 0x00000011
+ 0x00030002 0x00000019
+ 0x00030003 0x00000021
+ 0x00030004 0x00000029
+ 0x00030005 0x00000031
+ 0x00030006 0x00000039
+ 0x00030007 0x00000041>;
+};
diff --git a/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
new file mode 100644
index 0000000..d85c77d
--- /dev/null
+++ b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
@@ -0,0 +1,82 @@
+/*
+ * QorIQ TMU device tree stub [ controller @ offset 0xf0000 ]
+ *
+ * Copyright 2015 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+tmu@f0000 {
+ compatible = "fsl,qoriq-tmu";
+ reg = <0xf0000 0x1000>;
+ interrupts = <18 2 0 0>;
+ calibration = <0x00000000 0x0000000f
+ 0x00000001 0x00000017
+ 0x00000002 0x0000001e
+ 0x00000003 0x00000026
+ 0x00000004 0x0000002e
+ 0x00000005 0x00000035
+ 0x00000006 0x0000003d
+ 0x00000007 0x00000044
+ 0x00000008 0x0000004c
+ 0x00000009 0x00000053
+ 0x0000000a 0x0000005b
+ 0x0000000b 0x00000062
+
+ 0x00010000 0x00000011
+ 0x00010001 0x00000019
+ 0x00010002 0x00000021
+ 0x00010003 0x0000002a
+ 0x00010004 0x00000032
+ 0x00010005 0x0000003a
+ 0x00010006 0x00000042
+ 0x00010007 0x0000004b
+ 0x00010008 0x00000053
+ 0x00010009 0x0000005b
+ 0x0001000a 0x00000063
+
+ 0x00020000 0x00000012
+ 0x00020001 0x0000001b
+ 0x00020002 0x00000024
+ 0x00020003 0x0000002c
+ 0x00020004 0x00000035
+ 0x00020005 0x0000003d
+ 0x00020006 0x00000046
+ 0x00020007 0x0000004e
+ 0x00020008 0x00000057
+
+ 0x00030000 0x00000009
+ 0x00030001 0x00000011
+ 0x00030002 0x00000019
+ 0x00030003 0x00000021
+ 0x00030004 0x00000029
+ 0x00030005 0x00000031
+ 0x00030006 0x00000039
+ 0x00030007 0x00000041>;
+};
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index 15ae462..bb9f792 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -345,6 +345,7 @@
reg = <0xea000 0x4000>;
};
+/include/ "qoriq-tmu-t104xsi.dtsi"
/include/ "elo3-dma-0.dtsi"
/include/ "elo3-dma-1.dtsi"
/include/ "qoriq-espi-0.dtsi"
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-04-15 8:17 [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x Jia Hongtao
@ 2015-05-26 6:33 ` Hongtao Jia
2015-05-26 19:37 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Hongtao Jia @ 2015-05-26 6:33 UTC (permalink / raw)
To: Scott Wood, edubezval
Cc: linuxppc-dev, devicetree, robh+dt, rui.zhang, Hongtao Jia
Hi Scott,
Eduardo indicated that "calibration" property should add "fsl" prefix.
I updated the patch.
Any other comments?
If not I will send V3 soon.
Thanks.
---
Best Regards,
Hongtao
> -----Original Message-----
> From: Jia Hongtao [mailto:hongtao.jia@freescale.com]
> Sent: Wednesday, April 15, 2015 4:18 PM
> To: Wood Scott-B07421
> Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org;
> robh+dt@kernel.org; rui.zhang@intel.com; Jia Hongtao-B38951
> Subject: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ
> T104x
>=20
> This is Thermal Monitoring Unit for QorIQ platform.
>=20
> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com>
> ---
> Changes from V1:
> * Provide more details on compatible and calibration properties.
>=20
> .../devicetree/bindings/thermal/qoriq-thermal.txt | 68
> ++++++++++++++++++
> arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi | 82
> ++++++++++++++++++++++
> arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 1 +
> 3 files changed, 151 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/qoriq-
> thermal.txt
> create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
>=20
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> new file mode 100644
> index 0000000..48e7fff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> @@ -0,0 +1,68 @@
> +* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
> +
> +Required properties:
> +- compatible : Must include "fsl,qoriq-tmu". The version of the device
> is
> + determined by the TMU IP Block Revision Register (IPBRR0) at
> + offset 0x0BF8.
> + Table of correspondences between IPBRR0 values and example chips:
> + Value Device
> + ---------- -----
> + 0x01900102 T1040
> +- reg : Address range of TMU registers.
> +- interrupts : Contains the interrupt for TMU.
> +- calibration : Calibration table for TMU. This is required to determine
> + what a specific sensor reading translates to in degrees Celsius.
> + There are four calibration config ranges, for each range we need
> + a couple of calibration data formatted like <TTCFGR, TSCFGR>.
> + Freescale provides the data required.
> +
> +Example:
> +
> +tmu@f0000 {
> + compatible =3D "fsl,qoriq-tmu";
> + reg =3D <0xf0000 0x1000>;
> + interrupts =3D <18 2 0 0>;
> + calibration =3D <0x00000000 0x0000000f
> + 0x00000001 0x00000017
> + 0x00000002 0x0000001e
> + 0x00000003 0x00000026
> + 0x00000004 0x0000002e
> + 0x00000005 0x00000035
> + 0x00000006 0x0000003d
> + 0x00000007 0x00000044
> + 0x00000008 0x0000004c
> + 0x00000009 0x00000053
> + 0x0000000a 0x0000005b
> + 0x0000000b 0x00000062
> +
> + 0x00010000 0x00000011
> + 0x00010001 0x00000019
> + 0x00010002 0x00000021
> + 0x00010003 0x0000002a
> + 0x00010004 0x00000032
> + 0x00010005 0x0000003a
> + 0x00010006 0x00000042
> + 0x00010007 0x0000004b
> + 0x00010008 0x00000053
> + 0x00010009 0x0000005b
> + 0x0001000a 0x00000063
> +
> + 0x00020000 0x00000012
> + 0x00020001 0x0000001b
> + 0x00020002 0x00000024
> + 0x00020003 0x0000002c
> + 0x00020004 0x00000035
> + 0x00020005 0x0000003d
> + 0x00020006 0x00000046
> + 0x00020007 0x0000004e
> + 0x00020008 0x00000057
> +
> + 0x00030000 0x00000009
> + 0x00030001 0x00000011
> + 0x00030002 0x00000019
> + 0x00030003 0x00000021
> + 0x00030004 0x00000029
> + 0x00030005 0x00000031
> + 0x00030006 0x00000039
> + 0x00030007 0x00000041>;
> +};
> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> new file mode 100644
> index 0000000..d85c77d
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> @@ -0,0 +1,82 @@
> +/*
> + * QorIQ TMU device tree stub [ controller @ offset 0xf0000 ]
> + *
> + * Copyright 2015 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above
> copyright
> + * notice, this list of conditions and the following disclaimer in
> the
> + * documentation and/or other materials provided with the
> distribution.
> + * * Neither the name of Freescale Semiconductor nor the
> + * names of its contributors may be used to endorse or promote
> products
> + * derived from this software without specific prior written
> permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of
> the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND
> ANY
> + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> ARE
> + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR
> ANY
> + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> CAUSED AND
> + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
> TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +tmu@f0000 {
> + compatible =3D "fsl,qoriq-tmu";
> + reg =3D <0xf0000 0x1000>;
> + interrupts =3D <18 2 0 0>;
> + calibration =3D <0x00000000 0x0000000f
> + 0x00000001 0x00000017
> + 0x00000002 0x0000001e
> + 0x00000003 0x00000026
> + 0x00000004 0x0000002e
> + 0x00000005 0x00000035
> + 0x00000006 0x0000003d
> + 0x00000007 0x00000044
> + 0x00000008 0x0000004c
> + 0x00000009 0x00000053
> + 0x0000000a 0x0000005b
> + 0x0000000b 0x00000062
> +
> + 0x00010000 0x00000011
> + 0x00010001 0x00000019
> + 0x00010002 0x00000021
> + 0x00010003 0x0000002a
> + 0x00010004 0x00000032
> + 0x00010005 0x0000003a
> + 0x00010006 0x00000042
> + 0x00010007 0x0000004b
> + 0x00010008 0x00000053
> + 0x00010009 0x0000005b
> + 0x0001000a 0x00000063
> +
> + 0x00020000 0x00000012
> + 0x00020001 0x0000001b
> + 0x00020002 0x00000024
> + 0x00020003 0x0000002c
> + 0x00020004 0x00000035
> + 0x00020005 0x0000003d
> + 0x00020006 0x00000046
> + 0x00020007 0x0000004e
> + 0x00020008 0x00000057
> +
> + 0x00030000 0x00000009
> + 0x00030001 0x00000011
> + 0x00030002 0x00000019
> + 0x00030003 0x00000021
> + 0x00030004 0x00000029
> + 0x00030005 0x00000031
> + 0x00030006 0x00000039
> + 0x00030007 0x00000041>;
> +};
> diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> index 15ae462..bb9f792 100644
> --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> @@ -345,6 +345,7 @@
> reg =3D <0xea000 0x4000>;
> };
>=20
> +/include/ "qoriq-tmu-t104xsi.dtsi"
> /include/ "elo3-dma-0.dtsi"
> /include/ "elo3-dma-1.dtsi"
> /include/ "qoriq-espi-0.dtsi"
> --
> 2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-05-26 6:33 ` Hongtao Jia
@ 2015-05-26 19:37 ` Scott Wood
2015-06-09 2:19 ` Hongtao Jia
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2015-05-26 19:37 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: edubezval, linuxppc-dev, devicetree, robh+dt, rui.zhang
On Tue, 2015-05-26 at 01:33 -0500, Jia Hongtao-B38951 wrote:
> Hi Scott,
>
> Eduardo indicated that "calibration" property should add "fsl"
> prefix.
> I updated the patch.
> Any other comments?
> If not I will send V3 soon.
>
> Thanks.
I'd go with "fsl,tmu-calibration" rather than "fsl,calibration" but
not a big deal either way.
> > diff --git a/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> > b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> > new file mode 100644
> > index 0000000..d85c77d
> > --- /dev/null
> > +++ b/arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> > @@ -0,0 +1,82 @@
> > +/*
> > + * QorIQ TMU device tree stub [ controller @ offset 0xf0000 ]
> > + *
> > + * Copyright 2015 Freescale Semiconductor Inc.
> > + *
> > + * Redistribution and use in source and binary forms, with or
> > without
> > + * modification, are permitted provided that the following
> > conditions
> > are met:
> > + * * Redistributions of source code must retain the above
> > copyright
> > + * notice, this list of conditions and the following
> > disclaimer.
> > + * * Redistributions in binary form must reproduce the above
> > copyright
> > + * notice, this list of conditions and the following
> > disclaimer in
> > the
> > + * documentation and/or other materials provided with the
> > distribution.
> > + * * Neither the name of Freescale Semiconductor nor the
> > + * names of its contributors may be used to endorse or
> > promote
> > products
> > + * derived from this software without specific prior written
> > permission.
> > + *
> > + *
> > + * ALTERNATIVELY, this software may be distributed under the
> > terms of
> > the
> > + * GNU General Public License ("GPL") as published by the Free
> > Software
> > + * Foundation, either version 2 of that License or (at your
> > option) any
> > + * later version.
> > + *
> > + * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS''
> > AND
> > ANY
> > + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> > THE
> > IMPLIED
> > + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> > PURPOSE
> > ARE
> > + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE
> > LIABLE FOR
> > ANY
> > + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> > CONSEQUENTIAL
> > DAMAGES
> > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
> > GOODS OR
> > SERVICES;
> > + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > HOWEVER
> > CAUSED AND
> > + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> > LIABILITY, OR
> > TORT
> > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
> > THE USE
> > OF THIS
> > + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> > + */
> > +
> > +tmu@f0000{
> > + compatible = "fsl,qoriq-tmu";
> > + reg = <0xf0000 0x1000>;
> > + interrupts = <18 2 0 0>;
> > + calibration = <0x00000000 0x0000000f
> > + 0x00000001 0x00000017
> > + 0x00000002 0x0000001e
> > + 0x00000003 0x00000026
> > + 0x00000004 0x0000002e
> > + 0x00000005 0x00000035
> > + 0x00000006 0x0000003d
> > + 0x00000007 0x00000044
> > + 0x00000008 0x0000004c
> > + 0x00000009 0x00000053
> > + 0x0000000a 0x0000005b
> > + 0x0000000b 0x00000062
> > +
> > + 0x00010000 0x00000011
> > + 0x00010001 0x00000019
> > + 0x00010002 0x00000021
> > + 0x00010003 0x0000002a
> > + 0x00010004 0x00000032
> > + 0x00010005 0x0000003a
> > + 0x00010006 0x00000042
> > + 0x00010007 0x0000004b
> > + 0x00010008 0x00000053
> > + 0x00010009 0x0000005b
> > + 0x0001000a 0x00000063
> > +
> > + 0x00020000 0x00000012
> > + 0x00020001 0x0000001b
> > + 0x00020002 0x00000024
> > + 0x00020003 0x0000002c
> > + 0x00020004 0x00000035
> > + 0x00020005 0x0000003d
> > + 0x00020006 0x00000046
> > + 0x00020007 0x0000004e
> > + 0x00020008 0x00000057
> > +
> > + 0x00030000 0x00000009
> > + 0x00030001 0x00000011
> > + 0x00030002 0x00000019
> > + 0x00030003 0x00000021
> > + 0x00030004 0x00000029
> > + 0x00030005 0x00000031
> > + 0x00030006 0x00000039
> > + 0x00030007 0x00000041>;
> > +};
> > diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > index 15ae462..bb9f792 100644
> > --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > @@ -345,6 +345,7 @@
> > reg = <0xea000 0x4000>;
> > };
> >
> > +/include/ "qoriq-tmu-t104xsi.dtsi"
> > /include/ "elo3-dma-0.dtsi"
> > /include/ "elo3-dma-1.dtsi"
> > /include/ "qoriq-espi-0.dtsi"
Why is this chip-specific enough to be called "t104xsi", but not chip-
specific enough to just go directly into t1040si-post?
-SCott
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-05-26 19:37 ` Scott Wood
@ 2015-06-09 2:19 ` Hongtao Jia
2015-06-09 17:47 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Hongtao Jia @ 2015-06-09 2:19 UTC (permalink / raw)
To: Scott Wood; +Cc: edubezval, linuxppc-dev, devicetree, robh+dt, rui.zhang
DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIx
DQo+IFNlbnQ6IFdlZG5lc2RheSwgTWF5IDI3LCAyMDE1IDM6MzggQU0NCj4gVG86IEppYSBIb25n
dGFvLUIzODk1MQ0KPiBDYzogZWR1YmV6dmFsQGdtYWlsLmNvbTsgbGludXhwcGMtZGV2QGxpc3Rz
Lm96bGFicy5vcmc7DQo+IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyByb2JoK2R0QGtlcm5l
bC5vcmc7IHJ1aS56aGFuZ0BpbnRlbC5jb20NCj4gU3ViamVjdDogUmU6IFtQQVRDSCBWMl0gUW9y
SVEvVE1VOiBhZGQgVE1VIG5vZGUgdG8gZGV2aWNlIHRyZWUgZm9yIFFvcklRDQo+IFQxMDR4DQo+
IA0KPiBPbiBUdWUsIDIwMTUtMDUtMjYgYXQgMDE6MzMgLTA1MDAsIEppYSBIb25ndGFvLUIzODk1
MSB3cm90ZToNCj4gPiBIaSBTY290dCwNCj4gPg0KPiA+IEVkdWFyZG8gaW5kaWNhdGVkIHRoYXQg
ImNhbGlicmF0aW9uIiBwcm9wZXJ0eSBzaG91bGQgYWRkICJmc2wiDQo+ID4gcHJlZml4Lg0KPiA+
IEkgdXBkYXRlZCB0aGUgcGF0Y2guDQo+ID4gQW55IG90aGVyIGNvbW1lbnRzPw0KPiA+IElmIG5v
dCBJIHdpbGwgc2VuZCBWMyBzb29uLg0KPiA+DQo+ID4gVGhhbmtzLg0KPiANCj4gSSdkIGdvIHdp
dGggImZzbCx0bXUtY2FsaWJyYXRpb24iIHJhdGhlciB0aGFuICJmc2wsY2FsaWJyYXRpb24iIGJ1
dCBub3QgYQ0KPiBiaWcgZGVhbCBlaXRoZXIgd2F5Lg0KDQpUaGFua3MgZm9yIHRoZSBhZHZpY2Uu
DQoNCj4gDQo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2ZzbC9xb3Jp
cS10bXUtdDEwNHhzaS5kdHNpDQo+ID4gPiBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcW9y
aXEtdG11LXQxMDR4c2kuZHRzaQ0KPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiA+IGlu
ZGV4IDAwMDAwMDAuLmQ4NWM3N2QNCj4gPiA+IC0tLSAvZGV2L251bGwNCj4gPiA+ICsrKyBiL2Fy
Y2gvcG93ZXJwYy9ib290L2R0cy9mc2wvcW9yaXEtdG11LXQxMDR4c2kuZHRzaQ0KPiA+ID4gQEAg
LTAsMCArMSw4MiBAQA0KPiA+ID4gKy8qDQo+ID4gPiArICogUW9ySVEgVE1VIGRldmljZSB0cmVl
IHN0dWIgWyBjb250cm9sbGVyIEAgb2Zmc2V0IDB4ZjAwMDAgXQ0KPiA+ID4gKyAqDQo+ID4gPiAr
ICogQ29weXJpZ2h0IDIwMTUgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgSW5jLg0KPiA+ID4gKyAq
DQo+ID4gPiArICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm
b3Jtcywgd2l0aCBvcg0KPiA+ID4gd2l0aG91dA0KPiA+ID4gKyAqIG1vZGlmaWNhdGlvbiwgYXJl
IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcNCj4gPiA+IGNvbmRpdGlvbnMN
Cj4gPiA+IGFyZSBtZXQ6DQo+ID4gPiArICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJj
ZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZQ0KPiA+ID4gY29weXJpZ2h0DQo+ID4gPiArICog
ICAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZw0K
PiA+ID4gZGlzY2xhaW1lci4NCj4gPiA+ICsgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmlu
YXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlDQo+ID4gPiBjb3B5cmlnaHQNCj4gPiA+
ICsgKiAgICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93
aW5nDQo+ID4gPiBkaXNjbGFpbWVyIGluDQo+ID4gPiB0aGUNCj4gPiA+ICsgKiAgICAgICBkb2N1
bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUNCj4gPiA+
IGRpc3RyaWJ1dGlvbi4NCj4gPiA+ICsgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEZyZWVz
Y2FsZSBTZW1pY29uZHVjdG9yIG5vciB0aGUNCj4gPiA+ICsgKiAgICAgICBuYW1lcyBvZiBpdHMg
Y29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3INCj4gPiA+IHByb21vdGUNCj4g
PiA+IHByb2R1Y3RzDQo+ID4gPiArICogICAgICAgZGVyaXZlZCBmcm9tIHRoaXMgc29mdHdhcmUg
d2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuDQo+ID4gPiBwZXJtaXNzaW9uLg0KPiA+ID4g
KyAqDQo+ID4gPiArICoNCj4gPiA+ICsgKiBBTFRFUk5BVElWRUxZLCB0aGlzIHNvZnR3YXJlIG1h
eSBiZSBkaXN0cmlidXRlZCB1bmRlciB0aGUNCj4gPiA+IHRlcm1zIG9mDQo+ID4gPiB0aGUNCj4g
PiA+ICsgKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoIkdQTCIpIGFzIHB1Ymxpc2hlZCBi
eSB0aGUgRnJlZQ0KPiA+ID4gU29mdHdhcmUNCj4gPiA+ICsgKiBGb3VuZGF0aW9uLCBlaXRoZXIg
dmVyc2lvbiAyIG9mIHRoYXQgTGljZW5zZSBvciAoYXQgeW91cg0KPiA+ID4gb3B0aW9uKSBhbnkN
Cj4gPiA+ICsgKiBsYXRlciB2ZXJzaW9uLg0KPiA+ID4gKyAqDQo+ID4gPiArICogVEhJUyBTT0ZU
V0FSRSBJUyBQUk9WSURFRCBCWSBGcmVlc2NhbGUgU2VtaWNvbmR1Y3RvciBgYEFTIElTJycNCj4g
PiA+IEFORA0KPiA+ID4gQU5ZDQo+ID4gPiArICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ
RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLA0KPiA+ID4gVEhFDQo+ID4gPiBJTVBM
SUVEDQo+ID4gPiArICogV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1Mg
Rk9SIEEgUEFSVElDVUxBUg0KPiA+ID4gUFVSUE9TRQ0KPiA+ID4gQVJFDQo+ID4gPiArICogRElT
Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgQkUNCj4g
PiA+IExJQUJMRSBGT1INCj4gPiA+IEFOWQ0KPiA+ID4gKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElO
Q0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1INCj4gPiA+IENPTlNFUVVFTlRJQUwNCj4g
PiA+IERBTUFHRVMNCj4gPiA+ICsgKiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBS
T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUNCj4gPiA+IEdPT0RTIE9SDQo+ID4gPiBTRVJWSUNFUzsN
Cj4gPiA+ICsgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U
RVJSVVBUSU9OKQ0KPiA+ID4gSE9XRVZFUg0KPiA+ID4gQ0FVU0VEIEFORA0KPiA+ID4gKyAqIE9O
IEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QNCj4g
PiA+IExJQUJJTElUWSwgT1INCj4gPiA+IFRPUlQNCj4gPiA+ICsgKiAoSU5DTFVESU5HIE5FR0xJ
R0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GDQo+ID4gPiBUSEUg
VVNFDQo+ID4gPiBPRiBUSElTDQo+ID4gPiArICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP
RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuDQo+ID4gPiArICovDQo+ID4gPiArDQo+
ID4gPiAgK3RtdUBmMDAwMHsNCj4gPiA+ICsgICBjb21wYXRpYmxlID0gImZzbCxxb3JpcS10bXUi
Ow0KPiA+ID4gKyAgIHJlZyA9IDwweGYwMDAwIDB4MTAwMD47DQo+ID4gPiArICAgaW50ZXJydXB0
cyA9IDwxOCAyIDAgMD47DQo+ID4gPiArICAgY2FsaWJyYXRpb24gPSA8MHgwMDAwMDAwMCAweDAw
MDAwMDBmDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwMSAweDAwMDAwMDE3DQo+
ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwMiAweDAwMDAwMDFlDQo+ID4gPiArICAg
ICAgICAgICAgICAgICAgMHgwMDAwMDAwMyAweDAwMDAwMDI2DQo+ID4gPiArICAgICAgICAgICAg
ICAgICAgMHgwMDAwMDAwNCAweDAwMDAwMDJlDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgw
MDAwMDAwNSAweDAwMDAwMDM1DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwNiAw
eDAwMDAwMDNkDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwNyAweDAwMDAwMDQ0
DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwOCAweDAwMDAwMDRjDQo+ID4gPiAr
ICAgICAgICAgICAgICAgICAgMHgwMDAwMDAwOSAweDAwMDAwMDUzDQo+ID4gPiArICAgICAgICAg
ICAgICAgICAgMHgwMDAwMDAwYSAweDAwMDAwMDViDQo+ID4gPiArICAgICAgICAgICAgICAgICAg
MHgwMDAwMDAwYiAweDAwMDAwMDYyDQo+ID4gPiArDQo+ID4gPiArICAgICAgICAgICAgICAgICAg
MHgwMDAxMDAwMCAweDAwMDAwMDExDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAw
MSAweDAwMDAwMDE5DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwMiAweDAwMDAw
MDIxDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwMyAweDAwMDAwMDJhDQo+ID4g
PiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwNCAweDAwMDAwMDMyDQo+ID4gPiArICAgICAg
ICAgICAgICAgICAgMHgwMDAxMDAwNSAweDAwMDAwMDNhDQo+ID4gPiArICAgICAgICAgICAgICAg
ICAgMHgwMDAxMDAwNiAweDAwMDAwMDQyDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAx
MDAwNyAweDAwMDAwMDRiDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwOCAweDAw
MDAwMDUzDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwOSAweDAwMDAwMDViDQo+
ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAxMDAwYSAweDAwMDAwMDYzDQo+ID4gPiArDQo+
ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAyMDAwMCAweDAwMDAwMDEyDQo+ID4gPiArICAg
ICAgICAgICAgICAgICAgMHgwMDAyMDAwMSAweDAwMDAwMDFiDQo+ID4gPiArICAgICAgICAgICAg
ICAgICAgMHgwMDAyMDAwMiAweDAwMDAwMDI0DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgw
MDAyMDAwMyAweDAwMDAwMDJjDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAyMDAwNCAw
eDAwMDAwMDM1DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAyMDAwNSAweDAwMDAwMDNk
DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAyMDAwNiAweDAwMDAwMDQ2DQo+ID4gPiAr
ICAgICAgICAgICAgICAgICAgMHgwMDAyMDAwNyAweDAwMDAwMDRlDQo+ID4gPiArICAgICAgICAg
ICAgICAgICAgMHgwMDAyMDAwOCAweDAwMDAwMDU3DQo+ID4gPiArDQo+ID4gPiArICAgICAgICAg
ICAgICAgICAgMHgwMDAzMDAwMCAweDAwMDAwMDA5DQo+ID4gPiArICAgICAgICAgICAgICAgICAg
MHgwMDAzMDAwMSAweDAwMDAwMDExDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAzMDAw
MiAweDAwMDAwMDE5DQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAzMDAwMyAweDAwMDAw
MDIxDQo+ID4gPiArICAgICAgICAgICAgICAgICAgMHgwMDAzMDAwNCAweDAwMDAwMDI5DQo+ID4g
PiArICAgICAgICAgICAgICAgICAgMHgwMDAzMDAwNSAweDAwMDAwMDMxDQo+ID4gPiArICAgICAg
ICAgICAgICAgICAgMHgwMDAzMDAwNiAweDAwMDAwMDM5DQo+ID4gPiArICAgICAgICAgICAgICAg
ICAgMHgwMDAzMDAwNyAweDAwMDAwMDQxPjsgfTsNCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bv
d2VycGMvYm9vdC9kdHMvZnNsL3QxMDQwc2ktcG9zdC5kdHNpDQo+ID4gPiBiL2FyY2gvcG93ZXJw
Yy9ib290L2R0cy9mc2wvdDEwNDBzaS1wb3N0LmR0c2kNCj4gPiA+IGluZGV4IDE1YWU0NjIuLmJi
OWY3OTIgMTAwNjQ0DQo+ID4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDQw
c2ktcG9zdC5kdHNpDQo+ID4gPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDQw
c2ktcG9zdC5kdHNpDQo+ID4gPiBAQCAtMzQ1LDYgKzM0NSw3IEBADQo+ID4gPiAgICAgICAgICAg
ICByZWcgICAgICAgID0gPDB4ZWEwMDAgMHg0MDAwPjsNCj4gPiA+ICAgICB9Ow0KPiA+ID4NCj4g
PiA+ICsvaW5jbHVkZS8gInFvcmlxLXRtdS10MTA0eHNpLmR0c2kiDQo+ID4gPiAgL2luY2x1ZGUv
ICJlbG8zLWRtYS0wLmR0c2kiDQo+ID4gPiAgL2luY2x1ZGUvICJlbG8zLWRtYS0xLmR0c2kiDQo+
ID4gPiAgL2luY2x1ZGUvICJxb3JpcS1lc3BpLTAuZHRzaSINCj4gDQo+IFdoeSBpcyB0aGlzIGNo
aXAtc3BlY2lmaWMgZW5vdWdoIHRvIGJlIGNhbGxlZCAidDEwNHhzaSIsIGJ1dCBub3QgY2hpcC0N
Cj4gc3BlY2lmaWMgZW5vdWdoIHRvIGp1c3QgZ28gZGlyZWN0bHkgaW50byB0MTA0MHNpLXBvc3Q/
DQoNClQxMDR4IHBsYXRmb3JtIHNoYXJlIHRoZSBzYW1lIGNhbGlicmF0aW9uIGRhdGEuDQoNCi1I
b25ndGFvLg0KDQo+IA0KPiAtU0NvdHQNCj4gDQoNCg==
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-06-09 2:19 ` Hongtao Jia
@ 2015-06-09 17:47 ` Scott Wood
2015-06-10 8:56 ` Hongtao Jia
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2015-06-09 17:47 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: edubezval, linuxppc-dev, devicetree, robh+dt, rui.zhang
On Mon, 2015-06-08 at 21:19 -0500, Jia Hongtao-B38951 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, May 27, 2015 3:38 AM
> > To: Jia Hongtao-B38951
> > Cc: edubezval@gmail.com; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; robh+dt@kernel.org; rui.zhang@intel.com
> > Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for
> > QorIQ
> > T104x
> >
> > On Tue, 2015-05-26 at 01:33 -0500, Jia Hongtao-B38951 wrote:
> > > diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > index 15ae462..bb9f792 100644
> > > > --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > @@ -345,6 +345,7 @@
> > > > reg = <0xea000 0x4000>;
> > > > };
> > > >
> > > > +/include/ "qoriq-tmu-t104xsi.dtsi"
> > > > /include/ "elo3-dma-0.dtsi"
> > > > /include/ "elo3-dma-1.dtsi"
> > > > /include/ "qoriq-espi-0.dtsi"
> >
> > Why is this chip-specific enough to be called "t104xsi", but not
> > chip-
> > specific enough to just go directly into t1040si-post?
>
> T104x platform share the same calibration data.
Which t104x are you referring to that doesn't use t1040si-post.dtsi?
Plus, given the numbering scheme it's always possible that a new t104x
comes out that has little to do with existing t104x.
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-06-09 17:47 ` Scott Wood
@ 2015-06-10 8:56 ` Hongtao Jia
2015-06-10 18:37 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Hongtao Jia @ 2015-06-10 8:56 UTC (permalink / raw)
To: Scott Wood; +Cc: edubezval, linuxppc-dev, devicetree, robh+dt, rui.zhang
DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIx
DQo+IFNlbnQ6IFdlZG5lc2RheSwgSnVuZSAxMCwgMjAxNSAxOjQ3IEFNDQo+IFRvOiBKaWEgSG9u
Z3Rhby1CMzg5NTENCj4gQ2M6IGVkdWJlenZhbEBnbWFpbC5jb207IGxpbnV4cHBjLWRldkBsaXN0
cy5vemxhYnMub3JnOw0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgcm9iaCtkdEBrZXJu
ZWwub3JnOyBydWkuemhhbmdAaW50ZWwuY29tDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggVjJdIFFv
cklRL1RNVTogYWRkIFRNVSBub2RlIHRvIGRldmljZSB0cmVlIGZvciBRb3JJUQ0KPiBUMTA0eA0K
PiANCj4gT24gTW9uLCAyMDE1LTA2LTA4IGF0IDIxOjE5IC0wNTAwLCBKaWEgSG9uZ3Rhby1CMzg5
NTEgd3JvdGU6DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTog
V29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IFdlZG5lc2RheSwgTWF5IDI3LCAyMDE1IDM6
MzggQU0NCj4gPiA+IFRvOiBKaWEgSG9uZ3Rhby1CMzg5NTENCj4gPiA+IENjOiBlZHViZXp2YWxA
Z21haWwuY29tOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gPiA+IGRldmljZXRy
ZWVAdmdlci5rZXJuZWwub3JnOyByb2JoK2R0QGtlcm5lbC5vcmc7IHJ1aS56aGFuZ0BpbnRlbC5j
b20NCj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggVjJdIFFvcklRL1RNVTogYWRkIFRNVSBub2Rl
IHRvIGRldmljZSB0cmVlIGZvcg0KPiA+ID4gUW9ySVEgVDEwNHgNCj4gPiA+DQo+ID4gPiBPbiBU
dWUsIDIwMTUtMDUtMjYgYXQgMDE6MzMgLTA1MDAsIEppYSBIb25ndGFvLUIzODk1MSB3cm90ZToN
Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvdDEwNDBzaS1w
b3N0LmR0c2kNCj4gPiA+ID4gPiBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvdDEwNDBzaS1w
b3N0LmR0c2kNCj4gPiA+ID4gPiBpbmRleCAxNWFlNDYyLi5iYjlmNzkyIDEwMDY0NA0KPiA+ID4g
PiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9mc2wvdDEwNDBzaS1wb3N0LmR0c2kNCj4g
PiA+ID4gPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QxMDQwc2ktcG9zdC5kdHNp
DQo+ID4gPiA+ID4gQEAgLTM0NSw2ICszNDUsNyBAQA0KPiA+ID4gPiA+ICAgICAgICAgICAgIHJl
ZyAgICAgICAgPSA8MHhlYTAwMCAweDQwMDA+Ow0KPiA+ID4gPiA+ICAgICB9Ow0KPiA+ID4gPiA+
DQo+ID4gPiA+ID4gKy9pbmNsdWRlLyAicW9yaXEtdG11LXQxMDR4c2kuZHRzaSINCj4gPiA+ID4g
PiAgL2luY2x1ZGUvICJlbG8zLWRtYS0wLmR0c2kiDQo+ID4gPiA+ID4gIC9pbmNsdWRlLyAiZWxv
My1kbWEtMS5kdHNpIg0KPiA+ID4gPiA+ICAvaW5jbHVkZS8gInFvcmlxLWVzcGktMC5kdHNpIg0K
PiA+ID4NCj4gPiA+IFdoeSBpcyB0aGlzIGNoaXAtc3BlY2lmaWMgZW5vdWdoIHRvIGJlIGNhbGxl
ZCAidDEwNHhzaSIsIGJ1dCBub3QNCj4gPiA+IGNoaXAtDQo+ID4gPiBzcGVjaWZpYyBlbm91Z2gg
dG8ganVzdCBnbyBkaXJlY3RseSBpbnRvIHQxMDQwc2ktcG9zdD8NCg0KVGhlIHRtdSBub2RlIGlu
Y2x1ZGVzIGxvdHMgb2YgY29udGVudHMuDQpJcyBpdCBsb29rcyBtZXNzeSBpZiBqdXN0IGdvIGRp
cmVjdGx5IGludG8gdDEwNDBzaS1wb3N0Pw0KDQo+ID4NCj4gPiBUMTA0eCBwbGF0Zm9ybSBzaGFy
ZSB0aGUgc2FtZSBjYWxpYnJhdGlvbiBkYXRhLg0KPiANCj4gV2hpY2ggdDEwNHggYXJlIHlvdSBy
ZWZlcnJpbmcgdG8gdGhhdCBkb2Vzbid0IHVzZSB0MTA0MHNpLXBvc3QuZHRzaT8NCj4gUGx1cywg
Z2l2ZW4gdGhlIG51bWJlcmluZyBzY2hlbWUgaXQncyBhbHdheXMgcG9zc2libGUgdGhhdCBhIG5l
dyB0MTA0eA0KPiBjb21lcyBvdXQgdGhhdCBoYXMgbGl0dGxlIHRvIGRvIHdpdGggZXhpc3Rpbmcg
dDEwNHguDQoNClllcywgcmlnaHQuIFRoZSBuYW1lIGNvbnRhaW5zICJ0MTA0eCIga2V5d29yZCBz
ZWVtcyBub3QgcGVyZmVjdC4NCkknZCBsaWtlIHRvIGNoYW5nZSAicW9yaXEtdG11LXQxMDR4c2ku
ZHRzaSIgdG8gInFvcmlxLXRtdS10MTA0MHNpLmR0c2kiDQphbmQgaW5jbHVkZWQgaW4gdDEwNDBz
aS1wb3N0LiBJcyB0aGlzIE9LIHdpdGggeW91Pw0KDQotSG9uZ3Rhby4NCg0KPiANCj4gLVNjb3R0
DQo+IA0KDQo=
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x
2015-06-10 8:56 ` Hongtao Jia
@ 2015-06-10 18:37 ` Scott Wood
0 siblings, 0 replies; 7+ messages in thread
From: Scott Wood @ 2015-06-10 18:37 UTC (permalink / raw)
To: Jia Hongtao-B38951
Cc: edubezval, linuxppc-dev, devicetree, robh+dt, rui.zhang
On Wed, 2015-06-10 at 03:56 -0500, Jia Hongtao-B38951 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, June 10, 2015 1:47 AM
> > To: Jia Hongtao-B38951
> > Cc: edubezval@gmail.com; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org; robh+dt@kernel.org; rui.zhang@intel.com
> > Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for
> > QorIQ
> > T104x
> >
> > On Mon, 2015-06-08 at 21:19 -0500, Jia Hongtao-B38951 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, May 27, 2015 3:38 AM
> > > > To: Jia Hongtao-B38951
> > > > Cc: edubezval@gmail.com; linuxppc-dev@lists.ozlabs.org;
> > > > devicetree@vger.kernel.org; robh+dt@kernel.org;
> > > > rui.zhang@intel.com
> > > > Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree
> > > > for
> > > > QorIQ T104x
> > > >
> > > > On Tue, 2015-05-26 at 01:33 -0500, Jia Hongtao-B38951 wrote:
> > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > index 15ae462..bb9f792 100644
> > > > > > --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > @@ -345,6 +345,7 @@
> > > > > > reg = <0xea000 0x4000>;
> > > > > > };
> > > > > >
> > > > > > +/include/ "qoriq-tmu-t104xsi.dtsi"
> > > > > > /include/ "elo3-dma-0.dtsi"
> > > > > > /include/ "elo3-dma-1.dtsi"
> > > > > > /include/ "qoriq-espi-0.dtsi"
> > > >
> > > > Why is this chip-specific enough to be called "t104xsi", but
> > > > not
> > > > chip-
> > > > specific enough to just go directly into t1040si-post?
>
> The tmu node includes lots of contents.
> Is it looks messy if just go directly into t1040si-post?
I don't think it's too much to go into the main file. Having too many
files is a hassle as well...
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-10 18:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-15 8:17 [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x Jia Hongtao
2015-05-26 6:33 ` Hongtao Jia
2015-05-26 19:37 ` Scott Wood
2015-06-09 2:19 ` Hongtao Jia
2015-06-09 17:47 ` Scott Wood
2015-06-10 8:56 ` Hongtao Jia
2015-06-10 18:37 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).