From: Scott Wood <scottwood@freescale.com>
To: Bucur Madalin-Cristian-B32716 <madalin.bucur@freescale.com>
Cc: Joe Perches <joe@perches.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liberman Igal-B31950 <Igal.Liberman@freescale.com>,
"ppc@mindchasers.com" <ppc@mindchasers.com>,
"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"joakim.tjernlund@transmode.se" <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet
Date: Mon, 27 Jul 2015 13:59:25 -0500 [thread overview]
Message-ID: <1438023565.2993.299.camel@freescale.com> (raw)
In-Reply-To: <BL2PR03MB545D22D02CEEDA05878E833E6810@BL2PR03MB545.namprd03.prod.outlook.com>
On Fri, 2015-07-24 at 10:45 -0500, Bucur Madalin-Cristian-B32716 wrote:
> > -----Original Message-----
> > From: Joe Perches [mailto:joe@perches.com]
> > On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
> > > +static int __init dpa_load(void)
> > > +{
> > []
> > > + err = platform_driver_register(&dpa_driver);
> > > + if (unlikely(err < 0)) {
> > > + pr_err(KBUILD_MODNAME
> > > + ": %s:%hu:%s(): platform_driver_register() = %d\n",
> > > + KBUILD_BASENAME ".c", __LINE__, __func__, err);
> > > + }
> > > +
> > > + pr_debug(KBUILD_MODNAME ": %s:%s() ->\n",
> > > + KBUILD_BASENAME ".c", __func__);
> >
> > Perhaps these should use pr_fmt
>
> Agree.
How about dropping all that complexity, and just using pr_debug("%s\n",
__func__), or dev_dbg where possible?
>
> > > +static void __exit dpa_unload(void)
> > > +{
> > > + pr_debug(KBUILD_MODNAME ": -> %s:%s()\n",
> > > + KBUILD_BASENAME ".c", __func__);
> >
> > dynamic debug has __func__ available and perhaps
> > the function tracer might be used instead.
> >
> > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h
> > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h
> > []
> > > +#define __hot
> >
> > curious.
> >
> > Maybe it'd be good to add a real __hot to compiler.h
>
> They're mostly there to make readers aware the code is critical, any
> changes could mess performance.
Mostly or entirely? Why not just use a comment, which could also point out
specific things that were done for performance?
-Scott
next prev parent reply other threads:[~2015-07-27 18:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 16:16 [PATCH 01/10] devres: add devm_alloc_percpu() Madalin Bucur
2015-07-22 16:16 ` [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-07-22 16:16 ` [PATCH 03/10] dpaa_eth: add configurable bpool thresholds Madalin Bucur
2015-07-22 16:16 ` [PATCH 04/10] dpaa_eth: add support for S/G frames Madalin Bucur
2015-07-22 16:16 ` [PATCH 05/10] dpaa_eth: add driver's Tx queue selection mechanism Madalin Bucur
2015-07-22 16:16 ` [PATCH 06/10] dpaa_eth: add ethtool functionality Madalin Bucur
2015-07-22 16:16 ` [PATCH 07/10] dpaa_eth: add sysfs exports Madalin Bucur
2015-07-22 16:16 ` [PATCH 08/10] dpaa_eth: add debugfs counters Madalin Bucur
2015-07-22 16:16 ` [PATCH 09/10] dpaa_eth: add debugfs entries Madalin Bucur
2015-07-22 16:16 ` [PATCH 10/10] dpaa_eth: add trace points Madalin Bucur
2015-07-22 17:47 ` [PATCH 03/10] dpaa_eth: add configurable bpool thresholds Joe Perches
2015-07-24 15:49 ` Madalin-Cristian Bucur
2015-07-26 23:35 ` David Miller
2015-07-27 12:54 ` Madalin-Cristian Bucur
2015-07-22 17:37 ` [PATCH 02/10] dpaa_eth: add support for DPAA Ethernet Joe Perches
2015-07-24 15:45 ` Madalin-Cristian Bucur
2015-07-27 18:59 ` Scott Wood [this message]
2015-07-29 14:15 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438023565.2993.299.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Igal.Liberman@freescale.com \
--cc=joakim.tjernlund@transmode.se \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ppc@mindchasers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).