* [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs
@ 2015-09-19 18:16 Poonam Aggrwal
2015-09-20 0:15 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Poonam Aggrwal @ 2015-09-19 18:16 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, devicetree-discuss; +Cc: scottwood, poonam aggrwal
From: poonam aggrwal <poonam.aggrwal@freescale.com>
Device Tree Bindings for DSP CPU clusters and DSP CPUs for Freescale PowerPC
SOCs which have DSP CPUs in addition to PowerPC CPUs.
For example B4860 has 3 DSP clusters which have 2 SC3900 cores each.
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
---
- based of: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
branch master
This patch was sent earlier and some comments were received. Some have been
taken care; others we can further discuss. Apologize for not following up
on them in time.
.../devicetree/bindings/powerpc/fsl/dsp-cpus.txt | 78 ++++++++++++++++++++++
1 file changed, 78 insertions(+)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
new file mode 100644
index 0000000..6d901ef
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
@@ -0,0 +1,78 @@
+===================================================================
+Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which
+have DSP CPUs in addition to PowerPC cpus.
+Copyright 2013 Freescale Semiconductor Inc.
+
+Power Architecture CPUs in Freescale SOCs are represented in device trees as
+per the definition in ePAPR.
+
+Required properties for DSP CPU cluster:
+- compatible : should be "fsl,sc3900-cluster".
+- reg : should contain the cluster index
+
+Required properties for DSP CPU:
+- compatible : should be "fsl,sc3900".
+- reg : should contain index of DSP CPU within the DSP clsuter.
+- next-level-cache : should point to the phandle of the next-level L2 cache.
+
+Example for B4860:
+B4860 SOC of Freescale has 3 DSP clusters. Each DSP cluster has 2 DSP CPUs each.
+The DSP CPUs are SC3900. There is a shared L2 cache per DSP cluster.
+ dsp-clusters {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dsp-cluster0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,sc3900-cluster";
+ reg = <0>;
+
+ dsp0: dsp@0 {
+ compatible = "fsl,sc3900";
+ reg = <0>;
+ next-level-cache = <&L2_2>;
+ };
+ dsp1: dsp@1 {
+ compatible = "fsl,sc3900";
+ reg = <1>;
+ next-level-cache = <&L2_2>;
+ };
+ };
+
+ dsp-cluster1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,sc3900-cluster";
+ reg = <1>;
+
+ dsp2: dsp@2 {
+ compatible = "fsl,sc3900";
+ reg = <2>;
+ next-level-cache = <&L2_3>;
+ };
+ dsp3: dsp@3 {
+ compatible = "fsl,sc3900";
+ reg = <3>;
+ next-level-cache = <&L2_3>;
+ };
+ };
+
+ dsp-cluster2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,sc3900-cluster";
+ reg = <2>;
+
+ dsp4: dsp@4 {
+ compatible = "fsl,sc3900";
+ reg = <4>;
+ next-level-cache = <&L2_4>;
+ };
+ dsp5: dsp@5 {
+ compatible = "fsl,sc3900";
+ reg = <5>;
+ next-level-cache = <&L2_4>;
+ };
+ };
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs
2015-09-19 18:16 [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs Poonam Aggrwal
@ 2015-09-20 0:15 ` Scott Wood
2015-09-21 8:36 ` Aggrwal Poonam
0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2015-09-20 0:15 UTC (permalink / raw)
To: Poonam Aggrwal; +Cc: linuxppc-dev, linux-kernel, devicetree-discuss
On Sat, 2015-09-19 at 23:46 +0530, Poonam Aggrwal wrote:
> From: poonam aggrwal <poonam.aggrwal@freescale.com>
>
> Device Tree Bindings for DSP CPU clusters and DSP CPUs for Freescale PowerPC
> SOCs which have DSP CPUs in addition to PowerPC CPUs.
> For example B4860 has 3 DSP clusters which have 2 SC3900 cores each.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> ---
> - based of: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> branch master
>
> This patch was sent earlier and some comments were received. Some have been
> taken care; others we can further discuss. Apologize for not following up
> on them in time.
> .../devicetree/bindings/powerpc/fsl/dsp-cpus.txt | 78
> ++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/dsp-
> cpus.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> new file mode 100644
> index 0000000..6d901ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> @@ -0,0 +1,78 @@
> +===================================================================
> +Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which
> +have DSP CPUs in addition to PowerPC cpus.
> +Copyright 2013 Freescale Semiconductor Inc.
> +
> +Power Architecture CPUs in Freescale SOCs are represented in device trees
> as
> +per the definition in ePAPR.
> +
> +Required properties for DSP CPU cluster:
> +- compatible : should be "fsl,sc3900-cluster".
> +- reg : should contain the cluster index
> +
> +Required properties for DSP CPU:
> +- compatible : should be "fsl,sc3900".
> +- reg : should contain index of DSP CPU within the DSP clsuter.
> +- next-level-cache : should point to the phandle of the next-level L2
> cache.
Why is the dsp-clusters container only shown in the example, not the binding
itself?
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs
2015-09-20 0:15 ` Scott Wood
@ 2015-09-21 8:36 ` Aggrwal Poonam
2015-09-21 20:01 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Aggrwal Poonam @ 2015-09-21 8:36 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, linux-kernel, devicetree-discuss
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogU3VuZGF5LCBTZXB0ZW1iZXIgMjAsIDIwMTUgNTo0NSBBTQ0KPiBUbzogQWdn
cndhbCBQb29uYW0tQjEwODEyIDxQb29uYW0uQWdncndhbEBmcmVlc2NhbGUuY29tPg0KPiBDYzog
bGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5v
cmc7IGRldmljZXRyZWUtDQo+IGRpc2N1c3NAbGlzdHMub3psYWJzLm9yZw0KPiBTdWJqZWN0OiBS
ZTogW1BBVENIIDIvNF0gcG93ZXJwYy9kZXZpY2UtdHJlZTogYmluZGluZ3MgZm9yIERTUA0KPiBj
b3Jlcy9jbHVzdGVycyBmb3IgRnJlZXNjYWxlIFNPQ3MNCj4gDQo+IE9uIFNhdCwgMjAxNS0wOS0x
OSBhdCAyMzo0NiArMDUzMCwgUG9vbmFtIEFnZ3J3YWwgd3JvdGU6DQo+ID4gRnJvbTogcG9vbmFt
IGFnZ3J3YWwgPHBvb25hbS5hZ2dyd2FsQGZyZWVzY2FsZS5jb20+DQo+ID4NCj4gPiBEZXZpY2Ug
VHJlZSBCaW5kaW5ncyBmb3IgRFNQIENQVSBjbHVzdGVycyBhbmQgRFNQIENQVXMgZm9yIEZyZWVz
Y2FsZQ0KPiA+IFBvd2VyUEMgU09DcyB3aGljaCBoYXZlIERTUCBDUFVzIGluIGFkZGl0aW9uIHRv
IFBvd2VyUEMgQ1BVcy4NCj4gPiBGb3IgZXhhbXBsZSBCNDg2MCBoYXMgMyBEU1AgY2x1c3RlcnMg
d2hpY2ggaGF2ZSAyIFNDMzkwMCBjb3JlcyBlYWNoLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTog
UG9vbmFtIEFnZ3J3YWwgPHBvb25hbS5hZ2dyd2FsQGZyZWVzY2FsZS5jb20+DQo+ID4gLS0tDQo+
ID4gLSBiYXNlZCBvZjogZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwv
Z2l0L3RvcnZhbGRzL2xpbnV4LmdpdA0KPiA+ICAgYnJhbmNoIG1hc3Rlcg0KPiA+DQo+ID4gVGhp
cyBwYXRjaCB3YXMgc2VudCBlYXJsaWVyIGFuZCBzb21lIGNvbW1lbnRzIHdlcmUgcmVjZWl2ZWQu
IFNvbWUgaGF2ZQ0KPiA+IGJlZW4gdGFrZW4gY2FyZTsgb3RoZXJzIHdlIGNhbiBmdXJ0aGVyIGRp
c2N1c3MuICBBcG9sb2dpemUgZm9yIG5vdA0KPiA+IGZvbGxvd2luZyB1cCBvbiB0aGVtIGluIHRp
bWUuDQo+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNsL2RzcC1jcHVzLnR4
dCAgIHwgNzgNCj4gPiArKysrKysrKysrKysrKysrKysrKysrDQo+ID4gIDEgZmlsZSBjaGFuZ2Vk
LCA3OCBpbnNlcnRpb25zKCspDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NA0KPiBEb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZHNwLQ0KPiA+IGNwdXMudHh0DQo+
ID4NCj4gPiBkaWZmIC0tZ2l0DQo+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu
Z3MvcG93ZXJwYy9mc2wvZHNwLWNwdXMudHh0DQo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy
ZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvZHNwLWNwdXMudHh0DQo+ID4gbmV3IGZpbGUgbW9kZSAx
MDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwLi42ZDkwMWVmDQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+
ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlcnBjL2ZzbC9kc3At
Y3B1cy50eHQNCj4gPiBAQCAtMCwwICsxLDc4IEBADQo+ID4NCj4gKz09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KPiA9PT09PT09PT09DQo+
ID4gK0JpbmRpbmcgZm9yIERTUCBDUFUgY2x1c3RlcnMgYW5kIERTUCBDUFVzIGZvciBGcmVlc2Nh
bGUgU09DcyB3aGljaA0KPiA+ICtoYXZlIERTUCBDUFVzIGluIGFkZGl0aW9uIHRvIFBvd2VyUEMg
Y3B1cy4NCj4gPiArQ29weXJpZ2h0IDIwMTMgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IgSW5jLg0K
PiA+ICsNCj4gPiArUG93ZXIgQXJjaGl0ZWN0dXJlIENQVXMgaW4gRnJlZXNjYWxlIFNPQ3MgYXJl
IHJlcHJlc2VudGVkIGluIGRldmljZQ0KPiA+ICt0cmVlcw0KPiA+IGFzDQo+ID4gK3BlciB0aGUg
ZGVmaW5pdGlvbiBpbiBlUEFQUi4NCj4gPiArDQo+ID4gK1JlcXVpcmVkIHByb3BlcnRpZXMgZm9y
IERTUCBDUFUgY2x1c3RlcjoNCj4gPiArLSBjb21wYXRpYmxlIDogc2hvdWxkIGJlICJmc2wsc2Mz
OTAwLWNsdXN0ZXIiLg0KPiA+ICstIHJlZyA6IHNob3VsZCBjb250YWluIHRoZSBjbHVzdGVyIGlu
ZGV4DQo+ID4gKw0KPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzIGZvciBEU1AgQ1BVOg0KPiA+ICst
IGNvbXBhdGlibGUgOiBzaG91bGQgYmUgImZzbCxzYzM5MDAiLg0KPiA+ICstIHJlZyA6IHNob3Vs
ZCBjb250YWluIGluZGV4IG9mIERTUCBDUFUgd2l0aGluIHRoZSBEU1AgY2xzdXRlci4NCj4gPiAr
LSBuZXh0LWxldmVsLWNhY2hlIDogc2hvdWxkIHBvaW50IHRvIHRoZSBwaGFuZGxlIG9mIHRoZSBu
ZXh0LWxldmVsIEwyDQo+ID4gY2FjaGUuDQo+IA0KPiBXaHkgaXMgdGhlIGRzcC1jbHVzdGVycyBj
b250YWluZXIgb25seSBzaG93biBpbiB0aGUgZXhhbXBsZSwgbm90IHRoZSBiaW5kaW5nDQo+IGl0
c2VsZj8NCg0KSSB3aWxsIHRyeSB0byBhZGQgbW9yZSBkZXNjcmlwdGlvbiBpbiB0aGUgYmluZGlu
ZyBmb3IgY2x1c3RlcjsgQW5kIHRoZSBzdHJ1Y3R1cmUgb2YgZHNwIGNsdXN0ZXIgKGxpa2Ugc3Vi
IG5vZGUgb2YgRFNQIGNsdXN0ZXIgaXMgY29yZSwgZXRjKS4NCkRpZCBJIGdldCB5b3VyIGZlZWRi
YWNrIHJpZ2h0Pw0KPiANCj4gLVNjb3R0DQoNCg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs
2015-09-21 8:36 ` Aggrwal Poonam
@ 2015-09-21 20:01 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2015-09-21 20:01 UTC (permalink / raw)
To: Aggrwal Poonam-B10812; +Cc: linuxppc-dev, linux-kernel, devicetree-discuss
On Mon, 2015-09-21 at 03:36 -0500, Aggrwal Poonam-B10812 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Sunday, September 20, 2015 5:45 AM
> > To: Aggrwal Poonam-B10812 <Poonam.Aggrwal@freescale.com>
> > Cc: linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> > devicetree-
> > discuss@lists.ozlabs.org
> > Subject: Re: [PATCH 2/4] powerpc/device-tree: bindings for DSP
> > cores/clusters for Freescale SOCs
> >
> > On Sat, 2015-09-19 at 23:46 +0530, Poonam Aggrwal wrote:
> > > From: poonam aggrwal <poonam.aggrwal@freescale.com>
> > >
> > > Device Tree Bindings for DSP CPU clusters and DSP CPUs for Freescale
> > > PowerPC SOCs which have DSP CPUs in addition to PowerPC CPUs.
> > > For example B4860 has 3 DSP clusters which have 2 SC3900 cores each.
> > >
> > > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > > ---
> > > - based of:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > branch master
> > >
> > > This patch was sent earlier and some comments were received. Some have
> > > been taken care; others we can further discuss. Apologize for not
> > > following up on them in time.
> > > .../devicetree/bindings/powerpc/fsl/dsp-cpus.txt | 78
> > > ++++++++++++++++++++++
> > > 1 file changed, 78 insertions(+)
> > > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/dsp-
> > > cpus.txt
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> > > new file mode 100644
> > > index 0000000..6d901ef
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/dsp-cpus.txt
> > > @@ -0,0 +1,78 @@
> > >
> > +=========================================================
> > ==========
> > > +Binding for DSP CPU clusters and DSP CPUs for Freescale SOCs which
> > > +have DSP CPUs in addition to PowerPC cpus.
> > > +Copyright 2013 Freescale Semiconductor Inc.
> > > +
> > > +Power Architecture CPUs in Freescale SOCs are represented in device
> > > +trees
> > > as
> > > +per the definition in ePAPR.
> > > +
> > > +Required properties for DSP CPU cluster:
> > > +- compatible : should be "fsl,sc3900-cluster".
> > > +- reg : should contain the cluster index
> > > +
> > > +Required properties for DSP CPU:
> > > +- compatible : should be "fsl,sc3900".
> > > +- reg : should contain index of DSP CPU within the DSP clsuter.
> > > +- next-level-cache : should point to the phandle of the next-level L2
> > > cache.
> >
> > Why is the dsp-clusters container only shown in the example, not the
> > binding
> > itself?
>
> I will try to add more description in the binding for cluster; And the
> structure of dsp cluster (like sub node of DSP cluster is core, etc).
> Did I get your feedback right?
No, I was complaining that the example has a "dsp-clusters" container node
and the binding itself doesn't mention it at all.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-21 20:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-19 18:16 [PATCH 2/4] powerpc/device-tree: bindings for DSP cores/clusters for Freescale SOCs Poonam Aggrwal
2015-09-20 0:15 ` Scott Wood
2015-09-21 8:36 ` Aggrwal Poonam
2015-09-21 20:01 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).