linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Segher Boessenkool <segher@kernel.crashing.org>,
	 nfont@linux.vnet.ibm.com
Subject: Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module
Date: Thu, 01 Oct 2015 12:56:40 +1000	[thread overview]
Message-ID: <1443668200.17980.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1443629978.8361.316.camel@linux.intel.com>

On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote:
> On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote:
> > On Tue, 2015-11-08 at 11:23:09 UTC, Andy Shevchenko wrote:
> > >  int dlpar_attach_node(struct device_node *dn)
> > >  {
> > >  	int rc;
> > >  
> > > -	dn->parent = derive_parent(dn->full_name);
> > > -	if (!dn->parent)
> > > -		return -ENOMEM;
> > > +	dn->parent = pseries_of_derive_parent(dn->full_name);
> > > +	if (IS_ERR(dn->parent))
> > > +		return PTR_ERR(dn_parent);
> >                                  ^
> > 				 ?
> > 
> > There are cross compilers on kernel.org, or on Ubuntu you can just:
> > 
> > $ apt-get install gcc-powerpc-linux-gnu
> > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu-gcc
> 
> Thanks! I tried today and the above the only problem with the series.
> Would you like me to resend whole series?

I'd like someone to test it. I gather that you haven't because it didn't
compile.

I assume you don't have access to hardware to test it on?

cheers

  reply	other threads:[~2015-10-01  2:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 11:23 [PATCH v2 1/5] powerpc/pseries: extract of_helpers module Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 2/5] powerpc/pseries: fix a potential memory leak Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 3/5] powerpc/pseries: replace kmalloc + strlcpy Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 4/5] powerpc/pseries: handle nodes without '/' Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 5/5] powerpc/pseries: re-use code from of_helpers module Andy Shevchenko
2015-08-14 11:51   ` [v2,5/5] " Michael Ellerman
2015-09-30 16:19     ` Andy Shevchenko
2015-10-01  2:56       ` Michael Ellerman [this message]
2015-10-01  7:02         ` Denis Kirjanov
2015-10-01  8:39           ` Andy Shevchenko
2015-10-01  9:32             ` Denis Kirjanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443668200.17980.1.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).