linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Denis Kirjanov <kda@linux-powerpc.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com
Subject: Re: [v2,5/5] powerpc/pseries: re-use code from of_helpers module
Date: Thu, 1 Oct 2015 10:02:10 +0300	[thread overview]
Message-ID: <CAOJe8K1qga-K0Nf=W1h7uP_Rr+w2akH4ES+PGmkSJTLTbL8oPg@mail.gmail.com> (raw)
In-Reply-To: <1443668200.17980.1.camel@ellerman.id.au>

On 10/1/15, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Wed, 2015-09-30 at 19:19 +0300, Andy Shevchenko wrote:
>> On Fri, 2015-08-14 at 21:51 +1000, Michael Ellerman wrote:
>> > On Tue, 2015-11-08 at 11:23:09 UTC, Andy Shevchenko wrote:
>> > >  int dlpar_attach_node(struct device_node *dn)
>> > >  {
>> > >  	int rc;
>> > >
>> > > -	dn->parent = derive_parent(dn->full_name);
>> > > -	if (!dn->parent)
>> > > -		return -ENOMEM;
>> > > +	dn->parent = pseries_of_derive_parent(dn->full_name);
>> > > +	if (IS_ERR(dn->parent))
>> > > +		return PTR_ERR(dn_parent);
>> >                                  ^
>> > 				 ?
>> >
>> > There are cross compilers on kernel.org, or on Ubuntu you can just:
>> >
>> > $ apt-get install gcc-powerpc-linux-gnu
>> > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu-gcc
>>
>> Thanks! I tried today and the above the only problem with the series.
>> Would you like me to resend whole series?
>
> I'd like someone to test it. I gather that you haven't because it didn't
> compile.

Oh yeah, totally untested:

  CC      arch/powerpc/platforms/pseries/dlpar.o
arch/powerpc/platforms/pseries/dlpar.c: In function 'dlpar_attach_node':
arch/powerpc/platforms/pseries/dlpar.c:255:18: error: 'dn_parent'
undeclared (first use in this function)
   return PTR_ERR(dn_parent);
                  ^
arch/powerpc/platforms/pseries/dlpar.c:255:18: note: each undeclared
identifier is reported only once for each function it appears in
scripts/Makefile.build:258: recipe for target
'arch/powerpc/platforms/pseries/dlpar.o' failed
make[2]: *** [arch/powerpc/platforms/pseries/dlpar.o] Error 1
scripts/Makefile.build:403: recipe for target
'arch/powerpc/platforms/pseries' failed
make[1]: *** [arch/powerpc/platforms/pseries] Error 2
Makefile:941: recipe for target 'arch/powerpc/platforms' failed
make: *** [arch/powerpc/platforms] Error 2

>
> I assume you don't have access to hardware to test it on?
>
> cheers
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

  reply	other threads:[~2015-10-01  7:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 11:23 [PATCH v2 1/5] powerpc/pseries: extract of_helpers module Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 2/5] powerpc/pseries: fix a potential memory leak Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 3/5] powerpc/pseries: replace kmalloc + strlcpy Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 4/5] powerpc/pseries: handle nodes without '/' Andy Shevchenko
2015-08-11 11:23 ` [PATCH v2 5/5] powerpc/pseries: re-use code from of_helpers module Andy Shevchenko
2015-08-14 11:51   ` [v2,5/5] " Michael Ellerman
2015-09-30 16:19     ` Andy Shevchenko
2015-10-01  2:56       ` Michael Ellerman
2015-10-01  7:02         ` Denis Kirjanov [this message]
2015-10-01  8:39           ` Andy Shevchenko
2015-10-01  9:32             ` Denis Kirjanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOJe8K1qga-K0Nf=W1h7uP_Rr+w2akH4ES+PGmkSJTLTbL8oPg@mail.gmail.com' \
    --to=kda@linux-powerpc.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nfont@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).