* [PATCH RESEND] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing
@ 2016-01-11 16:44 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2016-01-11 16:44 UTC (permalink / raw)
To: agraf; +Cc: gleb, pbonzini, kvm-ppc, kvm, linuxppc-dev, linux-kernel
This fixes the incorrect return statement in the function
mpic_set_default_irq_routing from always returning zero
to signal success to this function's caller to instead
return the return value of kvm_set_irq_routing as this
function can fail and we need to correctly signal the
caller of mpic_set_default_irq_routing when the call
to this particular function has failed.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/powerpc/kvm/mpic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index 6249cdc..b14b85a 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -1641,16 +1641,17 @@ static void mpic_destroy(struct kvm_device *dev)
static int mpic_set_default_irq_routing(struct openpic *opp)
{
struct kvm_irq_routing_entry *routing;
+ int ret;
/* Create a nop default map, so that dereferencing it still works */
routing = kzalloc((sizeof(*routing)), GFP_KERNEL);
if (!routing)
return -ENOMEM;
- kvm_set_irq_routing(opp->kvm, routing, 0, 0);
+ ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
kfree(routing);
- return 0;
+ return ret;
}
static int mpic_create(struct kvm_device *dev, u32 type)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing
@ 2016-02-17 16:25 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2016-02-17 16:25 UTC (permalink / raw)
To: agraf; +Cc: gleb, pbonzini, kvm-ppc, kvm, linuxppc-dev, linux-kernel
This fixes the incorrect return statement in the function
mpic_set_default_irq_routing from always returning zero
to signal success to this function's caller to instead
return the return value of kvm_set_irq_routing as this
function can fail and we need to correctly signal the
caller of mpic_set_default_irq_routing when the call
to this particular function has failed.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/powerpc/kvm/mpic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c
index 6249cdc..b14b85a 100644
--- a/arch/powerpc/kvm/mpic.c
+++ b/arch/powerpc/kvm/mpic.c
@@ -1641,16 +1641,17 @@ static void mpic_destroy(struct kvm_device *dev)
static int mpic_set_default_irq_routing(struct openpic *opp)
{
struct kvm_irq_routing_entry *routing;
+ int ret;
/* Create a nop default map, so that dereferencing it still works */
routing = kzalloc((sizeof(*routing)), GFP_KERNEL);
if (!routing)
return -ENOMEM;
- kvm_set_irq_routing(opp->kvm, routing, 0, 0);
+ ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
kfree(routing);
- return 0;
+ return ret;
}
static int mpic_create(struct kvm_device *dev, u32 type)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-17 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-11 16:44 [PATCH RESEND] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing Nicholas Krause
2016-02-17 16:25 Nicholas Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).