[PATCH 1/2] Fix misleading comment in early_setup_secondary

[PATCH 1/2] Fix misleading comment in early_setup_secondary

[Madhavan Srinivasan]

Current comment in the early_setup_secondary() for
paca->soft_enabled update is misleading. Comment should say to
Mark interrupts "disabled" insteads of "enable".
Patch to fix the typo.

Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/kernel/setup_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 5c03a6a9b054..c2b2e72042cf 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -323,7 +323,7 @@ void __init early_setup(unsigned long dt_ptr)
 #ifdef CONFIG_SMP
 void early_setup_secondary(void)
 {
-	/* Mark interrupts enabled in PACA */
+	/* Mark interrupts disabled in PACA */
 	get_paca()->soft_enabled = 0;
 
 	/* Initialize the hash table or TLB handling */
-- 
1.9.1

[PATCH 2/2] Fix misleading comment for hard_irq_disable() in pmao_restore_workaround

[Madhavan Srinivasan]

Current comment added in pmao_restore_workaround() for
hard_irq_disable is misleading. Comment should say to hard
"disable" interrupts instead of "enable" it. Patch to fix the typo.

Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/perf/core-book3s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index d1e65ce545b3..97a1d40d8696 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -651,7 +651,7 @@ static void pmao_restore_workaround(bool ebb)
 
 	/*
 	 * We are already soft-disabled in power_pmu_enable(). We need to hard
-	 * enable to actually prevent the PMU exception from firing.
+	 * disable to actually prevent the PMU exception from firing.
 	 */
 	hard_irq_disable();
 
-- 
1.9.1

Re: [2/2] Fix misleading comment for hard_irq_disable() in pmao_restore_workaround

[Michael Ellerman]

On Fri, 2016-04-03 at 05:01:49 UTC, Madhavan Srinivasan wrote:
> Current comment added in pmao_restore_workaround() for
> hard_irq_disable is misleading. Comment should say to hard
> "disable" interrupts instead of "enable" it. Patch to fix the typo.
> 
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/58bffb5bbb238d56e8818acb46

cheers

Re: [1/2] Fix misleading comment in early_setup_secondary

[Michael Ellerman]

On Fri, 2016-04-03 at 05:01:48 UTC, Madhavan Srinivasan wrote:
> Current comment in the early_setup_secondary() for
> paca->soft_enabled update is misleading. Comment should say to
> Mark interrupts "disabled" insteads of "enable".
> Patch to fix the typo.
> 
> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/103b7827d977ea34c982e6a9d2

cheers