linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/4xx: make sam440ep_setup_rtc init
@ 2016-04-26 16:49 Yang Shi
  2017-04-03 10:13 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Shi @ 2016-04-26 16:49 UTC (permalink / raw)
  To: alistair, mporter, benh, paulus, mpe, linuxppc-dev, yang.shi; +Cc: linux-kernel

sam440ep_setup_rtc is just called by machine_device_initcall, and it calls
i2c_register_board_info which is init too, so the lack of __init may cause
mismatch warning when linking kernel.

Signed-off-by: Yang Shi <yang.shi@windriver.com>
---
 arch/powerpc/platforms/44x/sam440ep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/44x/sam440ep.c b/arch/powerpc/platforms/44x/sam440ep.c
index 3ee4a03..fbecfc1 100644
--- a/arch/powerpc/platforms/44x/sam440ep.c
+++ b/arch/powerpc/platforms/44x/sam440ep.c
@@ -72,7 +72,7 @@ static struct i2c_board_info sam440ep_rtc_info = {
 	.irq = -1,
 };
 
-static int sam440ep_setup_rtc(void)
+static int __init sam440ep_setup_rtc(void)
 {
 	return i2c_register_board_info(0, &sam440ep_rtc_info, 1);
 }
-- 
2.0.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: powerpc/4xx: make sam440ep_setup_rtc init
  2016-04-26 16:49 [PATCH] powerpc/4xx: make sam440ep_setup_rtc init Yang Shi
@ 2017-04-03 10:13 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2017-04-03 10:13 UTC (permalink / raw)
  To: yshi, alistair, mporter, benh, paulus, linuxppc-dev, yang.shi
  Cc: linux-kernel

On Tue, 2016-04-26 at 16:49:38 UTC, yshi wrote:
> sam440ep_setup_rtc is just called by machine_device_initcall, and it calls
> i2c_register_board_info which is init too, so the lack of __init may cause
> mismatch warning when linking kernel.
> 
> Signed-off-by: Yang Shi <yang.shi@windriver.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/adec9a2e7ca3b4193818f9a7b39563

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-03 10:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-26 16:49 [PATCH] powerpc/4xx: make sam440ep_setup_rtc init Yang Shi
2017-04-03 10:13 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).