linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Cc: mpe@ellerman.id.au, anton@samba.org, paulus@samba.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 10/11] powerpc: Support to replay PMIs
Date: Mon, 01 Aug 2016 18:52:42 +1000	[thread overview]
Message-ID: <1470041562.5978.365.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160801180716.5d0a47de@roar.ozlabs.ibm.com>

On Mon, 2016-08-01 at 18:07 +1000, Nicholas Piggin wrote:
> > +static inline unsigned long soft_irq_set_level(int value)
> > +{
> > +     unsigned long flags, zero;
> > +
> > +     asm volatile(
> > +             "li %1,%3; lbz %0,%2(13); stb %1,%2(13)"
> > +             : "=r" (flags), "=&r" (zero)
> > +             : "i" (offsetof(struct paca_struct, soft_enabled)),\
> > +               "i" (value)
> > +             : "memory");
> > +
> > +     return flags;
> > +}

I would add a WARN_ON (possibly under control
of CONFIG_TRACE_IRQFLAGS(*) to verify we only ever use this to make
interrupts "less enabled".

(*) Or check if distros use CONFIG_TRACE_IRQFLAGS these days, then
create a new CONFIG_DEBUG_IRQ or something like that, and also move
the other use of CONFIG_TRACE_IRQFLAGS in local_irq_restore that
checks the msr as we really don't want that in production kernels.

Cheers,
Ben.

  parent reply	other threads:[~2016-08-01  9:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-31 19:06 [RFC PATCH v2 00/11] powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 01/11] Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 02/11] Cleanup to use IRQ_DISABLE_LEVEL_* macros for paca->soft_enabled update Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 03/11] powerpc: move set_soft_enabled() Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 04/11] powerpc: Use set_soft_enabled api to update paca->soft_enabled Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 05/11] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 06/11] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 07/11] powerpc: Add new _EXCEPTION_PROLOG_1 macro Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 08/11] powerpc: Add "mask_lvl" paramater to MASKABLE_* macros Madhavan Srinivasan
2016-08-01  5:21   ` Nicholas Piggin
2016-08-01  5:49     ` Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 09/11] powerpc: Add support to mask perf interrupts Madhavan Srinivasan
2016-08-01  5:29   ` Nicholas Piggin
2016-08-01  6:09     ` Madhavan Srinivasan
2016-08-01  6:48       ` Nicholas Piggin
2016-07-31 19:06 ` [RFC PATCH v2 10/11] powerpc: Support to replay PMIs Madhavan Srinivasan
2016-08-01  8:07   ` Nicholas Piggin
2016-08-01  8:51     ` Benjamin Herrenschmidt
2016-08-01 10:22       ` Madhavan Srinivasan
2016-08-01 10:43         ` Nicholas Piggin
2016-08-01  8:52     ` Benjamin Herrenschmidt [this message]
2016-07-31 19:06 ` [RFC PATCH v2 11/11] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470041562.5978.365.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).