From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Balbir Singh <bsingharora@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call
Date: Tue, 14 Nov 2017 15:59:21 +0530 [thread overview]
Message-ID: <1510654928.8xrjtkjm8m.naveen@linux.ibm.com> (raw)
In-Reply-To: <20171114092910.20399-3-kamalesh@linux.vnet.ibm.com>
Kamalesh Babulal wrote:
> From: Josh Poimboeuf <jpoimboe@redhat.com>
>=20
> When attempting to load a livepatch module, I got the following error:
>=20
> module_64: patch_module: Expect noop after relocate, got 3c820000
>=20
> The error was triggered by the following code in
> unregister_netdevice_queue():
>=20
> 14c: 00 00 00 48 b 14c <unregister_netdevice_queue+0x14c>
> 14c: R_PPC64_REL24 net_set_todo
> 150: 00 00 82 3c addis r4,r2,0
>=20
> GCC didn't insert a nop after the branch to net_set_todo() because it's
> a sibling call, so it never returns. The nop isn't needed after the
> branch in that case.
>=20
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> arch/powerpc/kernel/module_64.c | 4 ++++
> 1 file changed, 4 insertions(+)
>=20
> diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module=
_64.c
> index 39b01fd..9e5391f 100644
> --- a/arch/powerpc/kernel/module_64.c
> +++ b/arch/powerpc/kernel/module_64.c
> @@ -489,6 +489,10 @@ static int restore_r2(u32 *instruction, struct modul=
e *me)
> if (is_early_mcount_callsite(instruction - 1))
> return 1;
>=20
> + /* Sibling calls don't return, so they don't need to restore r2 */
> + if (instruction[-1] =3D=3D PPC_INST_BRANCH)
> + return 1;
> +
This looks quite fragile, unless we know for sure that gcc will _always_
emit this instruction form for sibling calls with relocations.
As an alternative, does it make sense to do the following check instead?
if ((instr_is_branch_iform(insn) || instr_is_branch_bform(insn))
&& !(insn & 0x1))
- Naveen
=
next prev parent reply other threads:[~2017-11-14 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 9:29 [PATCH v4 0/3] ppc64le: Add REL24 relocation support of livepatch symbols Kamalesh Babulal
2017-11-14 9:29 ` [PATCH v4 1/3] kernel/modules: " Kamalesh Babulal
2017-12-12 11:39 ` [v4, " Michael Ellerman
2017-11-14 9:29 ` [PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call Kamalesh Babulal
2017-11-14 10:29 ` Naveen N. Rao [this message]
2017-11-14 15:53 ` Josh Poimboeuf
2017-11-15 5:38 ` Kamalesh Babulal
2017-11-15 9:28 ` Naveen N. Rao
2017-11-16 1:26 ` Josh Poimboeuf
2017-11-16 13:09 ` Naveen N. Rao
2017-11-16 17:45 ` [PATCH v4.2] " Josh Poimboeuf
2017-11-17 8:17 ` Kamalesh Babulal
2017-11-18 8:33 ` Naveen N. Rao
2017-12-12 11:39 ` [v4.2] " Michael Ellerman
2017-11-14 9:29 ` [PATCH v4 3/3] powerpc/modules: Improve restore_r2() error message Kamalesh Babulal
2017-12-06 4:32 ` Michael Ellerman
2017-12-12 11:39 ` [v4,3/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510654928.8xrjtkjm8m.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).