From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [v4.2] powerpc/modules: Don't try to restore r2 after a sibling call
Date: Tue, 12 Dec 2017 22:39:25 +1100 (AEDT) [thread overview]
Message-ID: <3ywyXY71NTz9t3m@ozlabs.org> (raw)
In-Reply-To: <20171116174537.duz4x6vfzhp44lfh@treble>
On Thu, 2017-11-16 at 17:45:37 UTC, Josh Poimboeuf wrote:
>
> From: Josh Poimboeuf <jpoimboe@redhat.com>
> Subject: [PATCH v4.2] powerpc/modules: Don't try to restore r2 after a sibling call
>
> When attempting to load a livepatch module, I got the following error:
>
> module_64: patch_module: Expect noop after relocate, got 3c820000
>
> The error was triggered by the following code in
> unregister_netdevice_queue():
>
> 14c: 00 00 00 48 b 14c <unregister_netdevice_queue+0x14c>
> 14c: R_PPC64_REL24 net_set_todo
> 150: 00 00 82 3c addis r4,r2,0
>
> GCC didn't insert a nop after the branch to net_set_todo() because it's
> a sibling call, so it never returns. The nop isn't needed after the
> branch in that case.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b9eab08d012fa093947b230f9a8725
cheers
next prev parent reply other threads:[~2017-12-12 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 9:29 [PATCH v4 0/3] ppc64le: Add REL24 relocation support of livepatch symbols Kamalesh Babulal
2017-11-14 9:29 ` [PATCH v4 1/3] kernel/modules: " Kamalesh Babulal
2017-12-12 11:39 ` [v4, " Michael Ellerman
2017-11-14 9:29 ` [PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call Kamalesh Babulal
2017-11-14 10:29 ` Naveen N. Rao
2017-11-14 15:53 ` Josh Poimboeuf
2017-11-15 5:38 ` Kamalesh Babulal
2017-11-15 9:28 ` Naveen N. Rao
2017-11-16 1:26 ` Josh Poimboeuf
2017-11-16 13:09 ` Naveen N. Rao
2017-11-16 17:45 ` [PATCH v4.2] " Josh Poimboeuf
2017-11-17 8:17 ` Kamalesh Babulal
2017-11-18 8:33 ` Naveen N. Rao
2017-12-12 11:39 ` Michael Ellerman [this message]
2017-11-14 9:29 ` [PATCH v4 3/3] powerpc/modules: Improve restore_r2() error message Kamalesh Babulal
2017-12-06 4:32 ` Michael Ellerman
2017-12-12 11:39 ` [v4,3/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ywyXY71NTz9t3m@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).