* [PATCH -next] powerpc/platforms/85xx: drop pointless static qualifier
@ 2018-11-15 12:33 YueHaibing
2018-11-27 9:22 ` [-next] " Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-15 12:33 UTC (permalink / raw)
To: Scott Wood, Kumar Gala, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman
Cc: linuxppc-dev, kernel-janitors, Yue Haibing, linux-kernel
From: Yue Haibing <yuehaibing@huawei.com>
There is no need to have the 'void __iomem *cpld_base' variable static
since new value always be assigned before use it.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/85xx/t1042rdb_diu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/85xx/t1042rdb_diu.c b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
index dac36ba..2d16521 100644
--- a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
+++ b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
@@ -39,7 +39,7 @@
*/
static void t1042rdb_set_monitor_port(enum fsl_diu_monitor_port port)
{
- static void __iomem *cpld_base;
+ void __iomem *cpld_base;
cpld_base = of_iomap(cpld_node, 0);
if (!cpld_base) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [-next] powerpc/platforms/85xx: drop pointless static qualifier
2018-11-15 12:33 [PATCH -next] powerpc/platforms/85xx: drop pointless static qualifier YueHaibing
@ 2018-11-27 9:22 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2018-11-27 9:22 UTC (permalink / raw)
To: YueHaibing, Scott Wood, Kumar Gala, Benjamin Herrenschmidt,
Paul Mackerras
Cc: kernel-janitors, Yue Haibing, linuxppc-dev, linux-kernel
On Thu, 2018-11-15 at 12:33:16 UTC, YueHaibing wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
>
> There is no need to have the 'void __iomem *cpld_base' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/af8511cf32189ba66c7e2a4146f11c
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-27 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-15 12:33 [PATCH -next] powerpc/platforms/85xx: drop pointless static qualifier YueHaibing
2018-11-27 9:22 ` [-next] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).