* [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
@ 2020-09-01 12:46 Michael Ellerman
2020-09-01 15:33 ` Sachin Sant
2020-09-03 12:27 ` Michael Ellerman
0 siblings, 2 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-09-01 12:46 UTC (permalink / raw)
To: linuxppc-dev
In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
default") PROT_SAO was disabled in guests/LPARs by default. So skip
the test if we are running in a guest to avoid a spurious failure.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
tools/testing/selftests/powerpc/mm/prot_sao.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/powerpc/mm/prot_sao.c b/tools/testing/selftests/powerpc/mm/prot_sao.c
index e0cf8ebbf8cd..30b71b1d78d5 100644
--- a/tools/testing/selftests/powerpc/mm/prot_sao.c
+++ b/tools/testing/selftests/powerpc/mm/prot_sao.c
@@ -7,6 +7,7 @@
#include <stdlib.h>
#include <string.h>
#include <sys/mman.h>
+#include <unistd.h>
#include <asm/cputable.h>
@@ -18,9 +19,13 @@ int test_prot_sao(void)
{
char *p;
- /* SAO was introduced in 2.06 and removed in 3.1 */
+ /*
+ * SAO was introduced in 2.06 and removed in 3.1. It's disabled in
+ * guests/LPARs by default, so also skip if we are running in a guest.
+ */
SKIP_IF(!have_hwcap(PPC_FEATURE_ARCH_2_06) ||
- have_hwcap2(PPC_FEATURE2_ARCH_3_1));
+ have_hwcap2(PPC_FEATURE2_ARCH_3_1) ||
+ access("/proc/device-tree/rtas/ibm,hypertas-functions", F_OK) == 0);
/*
* Ensure we can ask for PROT_SAO.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
2020-09-01 12:46 [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS Michael Ellerman
@ 2020-09-01 15:33 ` Sachin Sant
2020-09-08 7:22 ` Michael Ellerman
2020-09-03 12:27 ` Michael Ellerman
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Sant @ 2020-09-01 15:33 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
> On 01-Sep-2020, at 6:16 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
> default") PROT_SAO was disabled in guests/LPARs by default. So skip
> the test if we are running in a guest to avoid a spurious failure.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> —
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
With the fix test is skipped while running in a guest
# ./prot_sao
test: prot-sao
tags: git_version:unknown
[SKIP] Test skipped on line 25
skip: prot-sao
#
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
2020-09-01 12:46 [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS Michael Ellerman
2020-09-01 15:33 ` Sachin Sant
@ 2020-09-03 12:27 ` Michael Ellerman
1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-09-03 12:27 UTC (permalink / raw)
To: linuxppc-dev, Michael Ellerman
On Tue, 1 Sep 2020 22:46:53 +1000, Michael Ellerman wrote:
> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
> default") PROT_SAO was disabled in guests/LPARs by default. So skip
> the test if we are running in a guest to avoid a spurious failure.
Applied to powerpc/fixes.
[1/1] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
https://git.kernel.org/powerpc/c/fc1f178cdb31783ff37296ecae817a1045a1a513
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS
2020-09-01 15:33 ` Sachin Sant
@ 2020-09-08 7:22 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2020-09-08 7:22 UTC (permalink / raw)
To: Sachin Sant; +Cc: linuxppc-dev
Sachin Sant <sachinp@linux.vnet.ibm.com> writes:
>> On 01-Sep-2020, at 6:16 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> In commit 9b725a90a8f1 ("powerpc/64s: Disallow PROT_SAO in LPARs by
>> default") PROT_SAO was disabled in guests/LPARs by default. So skip
>> the test if we are running in a guest to avoid a spurious failure.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> —
>
> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>
> With the fix test is skipped while running in a guest
>
> # ./prot_sao
> test: prot-sao
> tags: git_version:unknown
> [SKIP] Test skipped on line 25
> skip: prot-sao
> #
Thanks. Sorry I missed adding your Tested-by tag.
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-08 7:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 12:46 [PATCH] selftests/powerpc: Skip PROT_SAO test in guests/LPARS Michael Ellerman
2020-09-01 15:33 ` Sachin Sant
2020-09-08 7:22 ` Michael Ellerman
2020-09-03 12:27 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).