* [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12
@ 2021-05-18 20:58 Nick Desaulniers
2021-05-18 21:12 ` Nathan Chancellor
2021-06-06 12:08 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Nick Desaulniers @ 2021-05-18 20:58 UTC (permalink / raw)
To: Michael Ellerman
Cc: Fangrui Song, Nick Desaulniers, linux-kernel, Nathan Chancellor,
clang-built-linux, Paul Mackerras, linuxppc-dev
Until clang-12, clang would attempt to assemble 32b powerpc assembler in
64b emulation mode when using a 64b target triple with -m32, leading to
errors during the build of the compat VDSO. Simply disable all of
CONFIG_COMPAT; users should upgrade to the latest release of clang for
proper support.
Link: https://github.com/ClangBuiltLinux/linux/issues/1160
Link: https://github.com/llvm/llvm-project/commits/2288319733cd5f525bf7e24dece08bfcf9d0ff9e
Link: https://groups.google.com/g/clang-built-linux/c/ayNmi3HoNdY/m/XJAGj_G2AgAJ
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/powerpc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index ce3f59531b51..2a02784b7ef0 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -289,6 +289,7 @@ config PANIC_TIMEOUT
config COMPAT
bool "Enable support for 32bit binaries"
depends on PPC64
+ depends on !CC_IS_CLANG || CLANG_VERSION >= 120000
default y if !CPU_LITTLE_ENDIAN
select ARCH_WANT_OLD_COMPAT_IPC
select COMPAT_OLD_SIGACTION
--
2.31.1.751.gd2f1c929bd-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12
2021-05-18 20:58 [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12 Nick Desaulniers
@ 2021-05-18 21:12 ` Nathan Chancellor
2021-06-06 12:08 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-05-18 21:12 UTC (permalink / raw)
To: Nick Desaulniers, Michael Ellerman
Cc: Fangrui Song, linux-kernel, clang-built-linux, Paul Mackerras,
linuxppc-dev
On 5/18/2021 1:58 PM, Nick Desaulniers wrote:
> Until clang-12, clang would attempt to assemble 32b powerpc assembler in
> 64b emulation mode when using a 64b target triple with -m32, leading to
> errors during the build of the compat VDSO. Simply disable all of
> CONFIG_COMPAT; users should upgrade to the latest release of clang for
> proper support.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1160
> Link: https://github.com/llvm/llvm-project/commits/2288319733cd5f525bf7e24dece08bfcf9d0ff9e
> Link: https://groups.google.com/g/clang-built-linux/c/ayNmi3HoNdY/m/XJAGj_G2AgAJ
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/powerpc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index ce3f59531b51..2a02784b7ef0 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -289,6 +289,7 @@ config PANIC_TIMEOUT
> config COMPAT
> bool "Enable support for 32bit binaries"
> depends on PPC64
> + depends on !CC_IS_CLANG || CLANG_VERSION >= 120000
> default y if !CPU_LITTLE_ENDIAN
> select ARCH_WANT_OLD_COMPAT_IPC
> select COMPAT_OLD_SIGACTION
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12
2021-05-18 20:58 [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12 Nick Desaulniers
2021-05-18 21:12 ` Nathan Chancellor
@ 2021-06-06 12:08 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-06-06 12:08 UTC (permalink / raw)
To: Nick Desaulniers, Michael Ellerman
Cc: Fangrui Song, linux-kernel, Nathan Chancellor, clang-built-linux,
Paul Mackerras, linuxppc-dev
On Tue, 18 May 2021 13:58:57 -0700, Nick Desaulniers wrote:
> Until clang-12, clang would attempt to assemble 32b powerpc assembler in
> 64b emulation mode when using a 64b target triple with -m32, leading to
> errors during the build of the compat VDSO. Simply disable all of
> CONFIG_COMPAT; users should upgrade to the latest release of clang for
> proper support.
Applied to powerpc/next.
[1/1] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12
https://git.kernel.org/powerpc/c/6fcb574125e673f33ff058caa54b4e65629f3a08
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-06 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 20:58 [PATCH] powerpc: Kconfig: disable CONFIG_COMPAT for clang < 12 Nick Desaulniers
2021-05-18 21:12 ` Nathan Chancellor
2021-06-06 12:08 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).