powerpc: mcu_mpc8349emitx.c:189:13: error: unused variable 'ret' [-Werror=unused-variable]

powerpc: mcu_mpc8349emitx.c:189:13: error: unused variable 'ret' [-Werror=unused-variable]

[Naresh Kamboju]

[Please ignore this email if it is already reported ]

Regression found on powerpc gcc-8/9/10 and gcc-11 built with ppc6xx_defconfig
Following build warnings / errors reported on linux next 20211109.

metadata:
    git_describe: next-20211109
    git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
    git_short_log: c8109c2ba35e (\"Add linux-next specific files for 20211109\")
    target_arch: powerpc
    toolchain: gcc-11

build error :
--------------
<stdin>:1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp]
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c: In function 'mcu_remove':
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c:189:13: error: unused
variable 'ret' [-Werror=unused-variable]
  189 |         int ret;
      |             ^~~
cc1: all warnings being treated as errors
make[4]: *** [scripts/Makefile.build:288:
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.o] Error 1
make[4]: Target '__build' not remade because of errors.
make[3]: *** [scripts/Makefile.build:571: arch/powerpc/platforms/83xx] Error 2

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

build link:
-----------
https://builds.tuxbuild.com/20fICxLPRCpcISasoGwKGICBELv/build.log

build config:
-------------
https://builds.tuxbuild.com/20fICxLPRCpcISasoGwKGICBELv/config

# To install tuxmake on your system globally
# sudo pip3 install -U tuxmake
tuxmake --runtime podman --target-arch powerpc --toolchain gcc-11
--kconfig ppc6xx_defconfig


--
Linaro LKFT
https://lkft.linaro.org

Re: powerpc: mcu_mpc8349emitx.c:189:13: error: unused variable 'ret' [-Werror=unused-variable]

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

Hi Naresh,

On Tue, 9 Nov 2021 18:37:48 +0530 Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> [Please ignore this email if it is already reported ]
> 
> Regression found on powerpc gcc-8/9/10 and gcc-11 built with ppc6xx_defconfig
> Following build warnings / errors reported on linux next 20211109.
> 
> metadata:
>     git_describe: next-20211109
>     git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>     git_short_log: c8109c2ba35e (\"Add linux-next specific files for 20211109\")
>     target_arch: powerpc
>     toolchain: gcc-11
> 
> build error :
> --------------
> <stdin>:1559:2: warning: #warning syscall futex_waitv not implemented [-Wcpp]
> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c: In function 'mcu_remove':
> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c:189:13: error: unused
> variable 'ret' [-Werror=unused-variable]
>   189 |         int ret;
>       |             ^~~
> cc1: all warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:288:
> arch/powerpc/platforms/83xx/mcu_mpc8349emitx.o] Error 1
> make[4]: Target '__build' not remade because of errors.
> make[3]: *** [scripts/Makefile.build:571: arch/powerpc/platforms/83xx] Error 2
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> build link:
> -----------
> https://builds.tuxbuild.com/20fICxLPRCpcISasoGwKGICBELv/build.log
> 
> build config:
> -------------
> https://builds.tuxbuild.com/20fICxLPRCpcISasoGwKGICBELv/config
> 
> # To install tuxmake on your system globally
> # sudo pip3 install -U tuxmake
> tuxmake --runtime podman --target-arch powerpc --toolchain gcc-11
> --kconfig ppc6xx_defconfig
> 
> 
> --
> Linaro LKFT
> https://lkft.linaro.org

Caused by commit

  5d354dc35ebb ("powerpc/83xx/mpc8349emitx: Make mcu_gpiochip_remove() return void")

that is now in Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] powerpc/83xx/mpc8349emitx: Drop unused variable

[Uwe Kleine-König]

Commit 5d354dc35ebb ("powerpc/83xx/mpc8349emitx: Make
mcu_gpiochip_remove() return void") removed the usage of the variable
ret, but failed to remove the variable itself, resulting in:

	arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c: In function ‘mcu_remove’:
	arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c:189:6: error: unused variable ‘ret’ [-Werror=unused-variable]
	  189 |  int ret;
	      |      ^~~

So remove the variable now.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index bb789f33c70e..a38372f9ac12 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -186,7 +186,6 @@ static int mcu_probe(struct i2c_client *client)
 static int mcu_remove(struct i2c_client *client)
 {
 	struct mcu *mcu = i2c_get_clientdata(client);
-	int ret;
 
 	kthread_stop(shutdown_thread);
 
-- 
2.30.2

Re: [PATCH] powerpc/83xx/mpc8349emitx: Drop unused variable

[Michael Ellerman]

On Wed, 10 Nov 2021 12:07:39 +0100, Uwe Kleine-König wrote:
> Commit 5d354dc35ebb ("powerpc/83xx/mpc8349emitx: Make
> mcu_gpiochip_remove() return void") removed the usage of the variable
> ret, but failed to remove the variable itself, resulting in:
> 
> 	arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c: In function ‘mcu_remove’:
> 	arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c:189:6: error: unused variable ‘ret’ [-Werror=unused-variable]
> 	  189 |  int ret;
> 	      |      ^~~
> 
> [...]

Applied to powerpc/fixes.

[1/1] powerpc/83xx/mpc8349emitx: Drop unused variable
      https://git.kernel.org/powerpc/c/2da516d7ed0865bf9835830907f2f6631006d628

cheers