linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry
@ 2024-04-17 15:07 Ritesh Harjani (IBM)
  2024-04-22  8:16 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Ritesh Harjani (IBM) @ 2024-04-17 15:07 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: nathanl, Ritesh Harjani (IBM), npiggin, donettom

walk_vmemmap() was skipping the first vmemmap entry pointed by
vmemmap_list pointer itself. This patch fixes that.

With this we should see the vmemmap entry at 0xc00c000000000000 for hash
which wasn't getting printed on doing

"cat /sys/kernel/debug/kernel_hash_pagetable"

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
 arch/powerpc/mm/ptdump/hashpagetable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/ptdump/hashpagetable.c b/arch/powerpc/mm/ptdump/hashpagetable.c
index 9a601587836b..a6baa6166d94 100644
--- a/arch/powerpc/mm/ptdump/hashpagetable.c
+++ b/arch/powerpc/mm/ptdump/hashpagetable.c
@@ -491,7 +491,7 @@ static void walk_vmemmap(struct pg_state *st)
 	 * Traverse the vmemmaped memory and dump pages that are in the hash
 	 * pagetable.
 	 */
-	while (ptr->list) {
+	while (ptr) {
 		hpte_find(st, ptr->virt_addr, mmu_vmemmap_psize);
 		ptr = ptr->list;
 	}
--
2.44.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry
  2024-04-17 15:07 [PATCH] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry Ritesh Harjani (IBM)
@ 2024-04-22  8:16 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2024-04-22  8:16 UTC (permalink / raw)
  To: linuxppc-dev, Ritesh Harjani (IBM); +Cc: nathanl, donettom, npiggin

On Wed, 17 Apr 2024 20:37:40 +0530, Ritesh Harjani (IBM) wrote:
> walk_vmemmap() was skipping the first vmemmap entry pointed by
> vmemmap_list pointer itself. This patch fixes that.
> 
> With this we should see the vmemmap entry at 0xc00c000000000000 for hash
> which wasn't getting printed on doing
> 
> "cat /sys/kernel/debug/kernel_hash_pagetable"
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry
      https://git.kernel.org/powerpc/c/f318c8be797f8572629d5386a88cde7d753457a8

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-22  8:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17 15:07 [PATCH] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry Ritesh Harjani (IBM)
2024-04-22  8:16 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).