From: Xiubo Li-B47053 <B47053@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
Wang Huan-B18965 <B18965@freescale.com>,
"timur@tabi.org" <timur@tabi.org>,
"perex@perex.cz" <perex@perex.cz>,
Guo Shawn-R65073 <r65073@freescale.com>,
"LW@KARO-electronics.de" <LW@KARO-electronics.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Chen Guangyu-B42378 <B42378@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"oskar@scara.com" <oskar@scara.com>,
Estevam Fabio-R49496 <r49496@freescale.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob@landley.net" <rob@landley.net>,
Jin Zhengxiong-R64188 <R64188@freescale.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.
Date: Mon, 28 Oct 2013 06:07:41 +0000 [thread overview]
Message-ID: <1DD289F6464F0949A2FCA5AA6DC23F8286A3DC@039-SN2MPN1-013.039d.mgd.msft.net> (raw)
In-Reply-To: <20131018172814.GT2443@sirena.org.uk>
> > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct
> snd_soc_codec *codec,
> > struct regulator_init_data *init_data,
> > int voltage)
> > {
> > +#ifdef CONFIG_SND_SOC_FSL_SGTL5000
> > + return 0;
> > +#else
> > dev_err(codec->dev, "this setup needs regulator support in the
> kernel\n");
> > return -EINVAL;
> > +#endif
> > }
>=20
> If these systems don't actually need the internal regulator then should
> they not be trying to enable it? =20
>
Yes, I think do not trying to enable the regulator is much better.
>Alternatively if it's OK to ignore this then why is this conditional in th=
e board?
>=20
The CONFIG_SND_SOC_FSL_SGTL5000 micro maybe confuse you and others.
And it should be CONFIG_SND_SOC_FSL_SGTL5000_VF610....
next prev parent reply other threads:[~2013-10-28 6:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:01 [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Xiubo Li
2013-10-17 9:01 ` [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver Xiubo Li
2013-10-17 9:42 ` Lothar Waßmann
2013-10-18 3:19 ` Xiubo Li-B47053
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:21 ` [alsa-devel] " Lars-Peter Clausen
2013-10-17 13:22 ` Timur Tabi
2013-10-17 13:33 ` Lars-Peter Clausen
2013-10-17 13:37 ` Timur Tabi
2013-10-17 13:51 ` Lars-Peter Clausen
2013-10-17 14:10 ` Mark Brown
2013-10-18 3:42 ` Xiubo Li-B47053
2013-10-17 17:43 ` Lars-Peter Clausen
2013-10-21 6:59 ` Xiubo Li-B47053
2013-10-22 2:20 ` Xiubo Li-B47053
2013-10-28 5:58 ` Xiubo Li-B47053
2013-11-12 5:02 ` Vinod Koul
2013-11-12 7:35 ` Li Xiubo
2013-11-12 7:59 ` Lars-Peter Clausen
2013-10-24 11:05 ` Mark Brown
2013-10-28 7:15 ` Xiubo Li-B47053
2013-10-29 4:00 ` Xiubo Li-B47053
2013-10-29 4:02 ` Nicolin Chen
2013-10-29 9:31 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 2/8] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2013-10-17 9:01 ` [PATCHv1 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2013-10-17 9:01 ` [PATCHv1 4/8] Documentation: Add device tree bindings for Freescale SAI Xiubo Li
2013-10-17 9:01 ` [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec Xiubo Li
2013-10-17 9:56 ` Nicolin Chen
2013-10-21 4:07 ` Xiubo Li-B47053
2013-10-17 10:17 ` Lothar Waßmann
2013-10-21 4:15 ` Xiubo Li-B47053
2013-10-21 8:11 ` Lothar Waßmann
2013-10-21 11:21 ` Timur Tabi
2013-10-18 17:28 ` Mark Brown
2013-10-28 6:07 ` Xiubo Li-B47053 [this message]
2013-10-17 9:01 ` [PATCHv1 6/8] ASoC: fsl: add SGT15000 based audio machine driver Xiubo Li
2013-10-18 17:33 ` Mark Brown
2013-10-21 7:50 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 7/8] ARM: dts: Enable SGT15000 codec based audio driver node for VF610 Xiubo Li
2013-10-17 9:01 ` [PATCHv1 8/8] Documentation: Add device tree bindings for Freescale VF610 sound Xiubo Li
2013-10-17 9:46 ` Lucas Stach
2013-10-18 3:27 ` Xiubo Li-B47053
2013-10-18 17:31 ` Mark Brown
2013-10-21 7:24 ` Xiubo Li-B47053
2013-10-22 9:47 ` Mark Brown
2013-10-17 10:22 ` [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1DD289F6464F0949A2FCA5AA6DC23F8286A3DC@039-SN2MPN1-013.039d.mgd.msft.net \
--to=b47053@freescale.com \
--cc=B18965@freescale.com \
--cc=B42378@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=R64188@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=oskar@scara.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=r49496@freescale.com \
--cc=r65073@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).