From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
linux-doc@vger.kernel.org, tiwai@suse.de, b18965@freescale.com,
Timur Tabi <timur@tabi.org>,
lgirdwood@gmail.com, r65073@freescale.com,
LW@KARO-electronics.de, linux@arm.linux.org.uk,
b42378@freescale.com, Xiubo Li <Li.Xiubo@freescale.com>,
oskar@scara.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, ian.campbell@citrix.com,
pawel.moll@arm.com, swarren@wwwdotorg.org,
rob.herring@calxeda.com, linux-arm-kernel@lists.infradead.org,
fabio.estevam@freescale.com, linux-kernel@vger.kernel.org,
rob@landley.net, r64188@freescale.com, shawn.guo@linaro.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.
Date: Thu, 17 Oct 2013 15:10:03 +0100 [thread overview]
Message-ID: <20131017141003.GO2443@sirena.org.uk> (raw)
In-Reply-To: <525FEB7A.5040406@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Thu, Oct 17, 2013 at 03:51:54PM +0200, Lars-Peter Clausen wrote:
> On 10/17/2013 03:37 PM, Timur Tabi wrote:
> > I understand that, but I'm trying to figure out why of_iomap() is okay for
> > hundreds of other drivers, but not this one. I've used it dozens of times
> > myself, without ever worrying about overlapping regions.
> The driver would work fine with just of_iomap(). But the resource range
> check comes basically for free and it does help to catch errors, so I'd
> recommend on using it rather than not using it.
There's also the fact that it's a devm_ function which means less error
handling code that we can break which is nice. There's probably a case
for an improved OF helper here...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-17 14:11 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:01 [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Xiubo Li
2013-10-17 9:01 ` [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver Xiubo Li
2013-10-17 9:42 ` Lothar Waßmann
2013-10-18 3:19 ` Xiubo Li-B47053
2013-10-17 12:15 ` Timur Tabi
2013-10-17 12:21 ` [alsa-devel] " Lars-Peter Clausen
2013-10-17 13:22 ` Timur Tabi
2013-10-17 13:33 ` Lars-Peter Clausen
2013-10-17 13:37 ` Timur Tabi
2013-10-17 13:51 ` Lars-Peter Clausen
2013-10-17 14:10 ` Mark Brown [this message]
2013-10-18 3:42 ` Xiubo Li-B47053
2013-10-17 17:43 ` Lars-Peter Clausen
2013-10-21 6:59 ` Xiubo Li-B47053
2013-10-22 2:20 ` Xiubo Li-B47053
2013-10-28 5:58 ` Xiubo Li-B47053
2013-11-12 5:02 ` Vinod Koul
2013-11-12 7:35 ` Li Xiubo
2013-11-12 7:59 ` Lars-Peter Clausen
2013-10-24 11:05 ` Mark Brown
2013-10-28 7:15 ` Xiubo Li-B47053
2013-10-29 4:00 ` Xiubo Li-B47053
2013-10-29 4:02 ` Nicolin Chen
2013-10-29 9:31 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 2/8] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610 Xiubo Li
2013-10-17 9:01 ` [PATCHv1 3/8] ARM: dts: Enables SAI ALSA SoC DAI device for Vybrid VF610 TOWER board Xiubo Li
2013-10-17 9:01 ` [PATCHv1 4/8] Documentation: Add device tree bindings for Freescale SAI Xiubo Li
2013-10-17 9:01 ` [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec Xiubo Li
2013-10-17 9:56 ` Nicolin Chen
2013-10-21 4:07 ` Xiubo Li-B47053
2013-10-17 10:17 ` Lothar Waßmann
2013-10-21 4:15 ` Xiubo Li-B47053
2013-10-21 8:11 ` Lothar Waßmann
2013-10-21 11:21 ` Timur Tabi
2013-10-18 17:28 ` Mark Brown
2013-10-28 6:07 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 6/8] ASoC: fsl: add SGT15000 based audio machine driver Xiubo Li
2013-10-18 17:33 ` Mark Brown
2013-10-21 7:50 ` Xiubo Li-B47053
2013-10-17 9:01 ` [PATCHv1 7/8] ARM: dts: Enable SGT15000 codec based audio driver node for VF610 Xiubo Li
2013-10-17 9:01 ` [PATCHv1 8/8] Documentation: Add device tree bindings for Freescale VF610 sound Xiubo Li
2013-10-17 9:46 ` Lucas Stach
2013-10-18 3:27 ` Xiubo Li-B47053
2013-10-18 17:31 ` Mark Brown
2013-10-21 7:24 ` Xiubo Li-B47053
2013-10-22 9:47 ` Mark Brown
2013-10-17 10:22 ` [PATCHv1 0/8] ALSA: Add SAI driver and enable SGT15000 codec Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017141003.GO2443@sirena.org.uk \
--to=broonie@kernel.org \
--cc=LW@KARO-electronics.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b18965@freescale.com \
--cc=b42378@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=oskar@scara.com \
--cc=pawel.moll@arm.com \
--cc=r64188@freescale.com \
--cc=r65073@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).