From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Olof Johansson <olof@lixom.net>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Darren Stevens <darren@stevens-zone.net>,
Bjorn Helgaas <helgaas@kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus
Date: Wed, 6 Dec 2017 09:37:39 +0100 [thread overview]
Message-ID: <1d5276c3-1d29-114a-c868-6f022eee58e7@xenosoft.de> (raw)
In-Reply-To: <4CEE49CE-68F3-457F-B302-54BA8550F36A@xenosoft.de>
[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]
On 03 December 2017 10:43AM, Christian Zigotzky wrote:
>
> On 3. Dec 2017, at 00:02, Olof Johansson <olof@lixom.net> wrote:
>>
>>> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson <olof@lixom.net> wrote:
>>>
>>> The below patch, together with Bjorn's, should do it. Christian,
can you test
>>> and report back?
>>>
>>> I'm guessing it won't do any harm to set this on non-X1000
platforms. My
>>> test system is currently powered down so I can't check.
>>>
>>>
>>> From a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001
>>> From: Olof Johansson <olof@lixom.net>
>>> Date: Sat, 2 Dec 2017 14:56:36 -0800
>>> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS
>>>
>>> Needed on Amiga X1000 with SB600.
>>>
>>> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>>> Signed-off-by: Olof Johansson <olof@lixom.net>
>>> ---
>>> arch/powerpc/platforms/pasemi/pci.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/powerpc/platforms/pasemi/pci.c
b/arch/powerpc/platforms/pasemi/pci.c
>>> index 5ff6108..ea54ed2 100644
>>> --- a/arch/powerpc/platforms/pasemi/pci.c
>>> +++ b/arch/powerpc/platforms/pasemi/pci.c
>>> @@ -224,6 +224,8 @@ void __init pas_pci_init(void)
>>> return;
>>> }
>>>
>>> + pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS):
>>
>> Typo, should be ';', not ':'. I obviously didn't even try compiling
this. :)
>>
>>
>> -Olof
>
> Hi Olof,
>
> Thanks a lot for your patch! I will test it on Wednesday.
>
> Cheers,
> Christian
Hi Olof,
I tested your patch today. Unfortunately the kernel 4.15-rc2 doesn't
compile with your patch.
Error messages:
^~~~~~~~~
arch/powerpc/platforms/pasemi/pci.c: In function ‘pas_pci_init’:
arch/powerpc/platforms/pasemi/pci.c:298:2: error: implicit declaration
of function ‘pci_set_flag’ [-Werror=implicit-function-declaration]
pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS);
^~~~~~~~~~~~
cc1: some warnings being treated as errors
---
I figured out that we need 'pci_set_flags' instead of 'pci_set_flag'. I
modified your patch and after that the kernel compiles. Please find
attached the new patch.
Cheers,
Christian
[-- Attachment #2: pci.c.patch --]
[-- Type: text/x-patch, Size: 541 bytes --]
arch/powerpc/platforms/pasemi/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 5ff6108..ea54ed2 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -224,6 +224,8 @@ void __init pas_pci_init(void)
return;
}
+ pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS);
+
for (np = NULL; (np = of_get_next_child(root, np)) != NULL;)
if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np))
of_node_get(np);
next prev parent reply other threads:[~2017-12-06 8:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 7:47 [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus Christian Zigotzky
2017-11-23 13:31 ` Michael Ellerman
2017-11-29 19:28 ` Christian Zigotzky
2017-11-29 19:46 ` Bjorn Helgaas
2017-11-29 20:45 ` Christian Zigotzky
2017-11-29 22:34 ` Bjorn Helgaas
2017-11-29 23:39 ` Christian Zigotzky
2017-11-30 22:42 ` Bjorn Helgaas
2017-12-01 22:08 ` Christian Zigotzky
2017-12-01 23:27 ` Bjorn Helgaas
2017-12-02 12:54 ` Christian Zigotzky
2017-12-02 23:00 ` Olof Johansson
2017-12-02 23:02 ` Olof Johansson
2017-12-03 9:43 ` Christian Zigotzky
2017-12-06 8:37 ` Christian Zigotzky [this message]
2017-12-06 11:03 ` Christian Zigotzky
2017-12-06 12:57 ` Michael Ellerman
2017-12-06 21:06 ` Bjorn Helgaas
2017-12-08 11:59 ` Michael Ellerman
2017-12-09 18:03 ` Christian Zigotzky
2017-12-15 8:04 ` Christian Zigotzky
2017-12-15 20:25 ` Bjorn Helgaas
2017-12-16 7:18 ` Christian Zigotzky
2017-12-22 9:57 ` Christian Zigotzky
2017-12-22 10:22 ` Christian Zigotzky
2017-12-22 11:19 ` Michael Ellerman
2017-12-22 12:11 ` Christian Zigotzky
2018-06-04 14:10 ` Michael Ellerman
2017-12-06 12:44 ` [PATCH] " Michael Ellerman
2017-12-06 15:53 ` Olof Johansson
2017-12-08 11:57 ` Michael Ellerman
2018-03-16 12:10 ` [PATCH 0/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards Christian Zigotzky
2018-03-16 12:55 ` [PATCH 1/1] " Christian Zigotzky
2018-03-19 19:13 ` Bjorn Helgaas
2018-03-19 20:46 ` Christian Zigotzky
2018-03-19 22:32 ` Michael Ellerman
2018-03-21 6:44 ` Christian Zigotzky
2018-03-25 20:55 ` Darren Stevens
2018-04-16 4:29 ` [PATCH 1/1] " Christian Zigotzky
2017-12-04 11:40 ` SB600 for the Nemo board has non-zero devices on non-root bus Darren Stevens
2017-12-04 13:31 ` Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5276c3-1d29-114a-c868-6f022eee58e7@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=bhelgaas@google.com \
--cc=darren@stevens-zone.net \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).