linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Christian Zigotzky <chzigotzky@xenosoft.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 1/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards
Date: Mon, 19 Mar 2018 14:13:10 -0500	[thread overview]
Message-ID: <20180319191310.GG77194@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <639e975f-1b3a-4f85-9a40-13fe2473fc28@xenosoft.de>

On Fri, Mar 16, 2018 at 01:55:36PM +0100, Christian Zigotzky wrote:
> Bjorn Helgaas created a patch for making PCI_SCAN_ALL_PCIE_DEVS work for
> Root Ports as well as Downstream. Previously PCI_SCAN_ALL_PCIE_DEVS (set by
> quirks or the "pci=pcie_scan_all"
> kernel parameter) only affected Switch Downstream Ports, not Root Ports. The
> problem is, that we have to add always the boot argument "pci=pcie_scan_all"
> for using Bjorn's improvements. Without the boot argument
> "pci=pcie_scan_all", the kernel doesn't boot on P.A. Semi boards with SB600
> chipset (SB600 chipset is connected via PCIe x4 to the P.A. Semi’s
> PA6T-1682M System-on-a-Chip) because the kernel can't find any drives
> connected to the SB600 anymore. Olof Johansson has created a patch for
> executing "pci=pcie_scan_all" automatically on P.A. Semi boards. With his
> patch, we don't need to add 'pci=pcie_scan_all' to the kernel boot arguments
> anymore.

The patch looks fine, but I need a signed-off-by line before I can apply
it.  See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst

> ---
> 
> arch/powerpc/platforms/pasemi/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/platforms/pasemi/pci.c
> b/arch/powerpc/platforms/pasemi/pci.c
> index 5ff6108..ea54ed2 100644
> --- a/arch/powerpc/platforms/pasemi/pci.c
> +++ b/arch/powerpc/platforms/pasemi/pci.c
> @@ -224,6 +224,8 @@ void __init pas_pci_init(void)
>          return;
>      }
> 
> +    pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS);
> +
>      for (np = NULL; (np = of_get_next_child(root, np)) != NULL;)
>          if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np))
>              of_node_get(np);
> 
> --
> 
> 

  reply	other threads:[~2018-03-19 19:13 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  7:47 [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus Christian Zigotzky
2017-11-23 13:31 ` Michael Ellerman
2017-11-29 19:28   ` Christian Zigotzky
2017-11-29 19:46     ` Bjorn Helgaas
2017-11-29 20:45       ` Christian Zigotzky
2017-11-29 22:34         ` Bjorn Helgaas
2017-11-29 23:39           ` Christian Zigotzky
2017-11-30 22:42             ` Bjorn Helgaas
2017-12-01 22:08               ` Christian Zigotzky
2017-12-01 23:27                 ` Bjorn Helgaas
2017-12-02 12:54                   ` Christian Zigotzky
2017-12-02 23:00                     ` Olof Johansson
2017-12-02 23:02                       ` Olof Johansson
2017-12-03  9:43                         ` Christian Zigotzky
2017-12-06  8:37                           ` Christian Zigotzky
2017-12-06 11:03                             ` Christian Zigotzky
2017-12-06 12:57                               ` Michael Ellerman
2017-12-06 21:06                                 ` Bjorn Helgaas
2017-12-08 11:59                                   ` Michael Ellerman
2017-12-09 18:03                                     ` Christian Zigotzky
2017-12-15  8:04                                       ` Christian Zigotzky
2017-12-15 20:25                                         ` Bjorn Helgaas
2017-12-16  7:18                                           ` Christian Zigotzky
2017-12-22  9:57                                             ` Christian Zigotzky
2017-12-22 10:22                                               ` Christian Zigotzky
2017-12-22 11:19                                               ` Michael Ellerman
2017-12-22 12:11                                                 ` Christian Zigotzky
2018-06-04 14:10                               ` Michael Ellerman
2017-12-06 12:44                       ` [PATCH] " Michael Ellerman
2017-12-06 15:53                         ` Olof Johansson
2017-12-08 11:57                           ` Michael Ellerman
2018-03-16 12:10                   ` [PATCH 0/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards Christian Zigotzky
2018-03-16 12:55                     ` [PATCH 1/1] " Christian Zigotzky
2018-03-19 19:13                       ` Bjorn Helgaas [this message]
2018-03-19 20:46                         ` Christian Zigotzky
2018-03-19 22:32                         ` Michael Ellerman
2018-03-21  6:44                           ` Christian Zigotzky
2018-03-25 20:55                           ` Darren Stevens
2018-04-16  4:29                           ` [PATCH 1/1] " Christian Zigotzky
2017-12-04 11:40               ` SB600 for the Nemo board has non-zero devices on non-root bus Darren Stevens
2017-12-04 13:31                 ` Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319191310.GG77194@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=chzigotzky@xenosoft.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).