* [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
@ 2008-10-17 18:56 Anton Vorontsov
2008-10-21 4:39 ` Kumar Gala
2008-10-21 18:23 ` Scott Wood
0 siblings, 2 replies; 6+ messages in thread
From: Anton Vorontsov @ 2008-10-17 18:56 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt signal
is connected to the IPIC's EXT2 interrupt line, the line is shared with
Vitesse 8201 Ethernet PHY.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8349emitx.dts | 8 ++++++++
arch/powerpc/boot/dts/mpc8349emitxgp.dts | 8 ++++++++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5cedf37..7fc5414 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -83,6 +83,14 @@
interrupts = <15 0x8>;
interrupt-parent = <&ipic>;
dfsrr;
+
+ rtc@68 {
+ device_type = "rtc";
+ compatible = "dallas,ds1339";
+ reg = <0x68>;
+ interrupts = <18 0x8>;
+ interrupt-parent = <&ipic>;
+ };
};
spi@7000 {
diff --git a/arch/powerpc/boot/dts/mpc8349emitxgp.dts b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
index 81ae1d3..fa40647 100644
--- a/arch/powerpc/boot/dts/mpc8349emitxgp.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
@@ -81,6 +81,14 @@
interrupts = <15 0x8>;
interrupt-parent = <&ipic>;
dfsrr;
+
+ rtc@68 {
+ device_type = "rtc";
+ compatible = "dallas,ds1339";
+ reg = <0x68>;
+ interrupts = <18 0x8>;
+ interrupt-parent = <&ipic>;
+ };
};
spi@7000 {
--
1.5.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
2008-10-17 18:56 [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards Anton Vorontsov
@ 2008-10-21 4:39 ` Kumar Gala
2008-10-21 18:23 ` Scott Wood
1 sibling, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2008-10-21 4:39 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Oct 17, 2008, at 1:56 PM, Anton Vorontsov wrote:
> The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt
> signal
> is connected to the IPIC's EXT2 interrupt line, the line is shared
> with
> Vitesse 8201 Ethernet PHY.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8349emitx.dts | 8 ++++++++
> arch/powerpc/boot/dts/mpc8349emitxgp.dts | 8 ++++++++
> 2 files changed, 16 insertions(+), 0 deletions(-)
applied
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
2008-10-17 18:56 [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards Anton Vorontsov
2008-10-21 4:39 ` Kumar Gala
@ 2008-10-21 18:23 ` Scott Wood
2008-10-21 18:35 ` Kumar Gala
2008-10-21 18:41 ` Anton Vorontsov
1 sibling, 2 replies; 6+ messages in thread
From: Scott Wood @ 2008-10-21 18:23 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 5cedf37..7fc5414 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -83,6 +83,14 @@
> interrupts = <15 0x8>;
> interrupt-parent = <&ipic>;
> dfsrr;
> +
> + rtc@68 {
> + device_type = "rtc";
> + compatible = "dallas,ds1339";
> + reg = <0x68>;
> + interrupts = <18 0x8>;
> + interrupt-parent = <&ipic>;
> + };
Why are we adding more device_types?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
2008-10-21 18:23 ` Scott Wood
@ 2008-10-21 18:35 ` Kumar Gala
2008-10-21 18:39 ` Scott Wood
2008-10-21 18:41 ` Anton Vorontsov
1 sibling, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2008-10-21 18:35 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:
> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/
>> boot/dts/mpc8349emitx.dts
>> index 5cedf37..7fc5414 100644
>> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
>> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
>> @@ -83,6 +83,14 @@
>> interrupts = <15 0x8>;
>> interrupt-parent = <&ipic>;
>> dfsrr;
>> +
>> + rtc@68 {
>> + device_type = "rtc";
>> + compatible = "dallas,ds1339";
>> + reg = <0x68>;
>> + interrupts = <18 0x8>;
>> + interrupt-parent = <&ipic>;
>> + };
>
> Why are we adding more device_types?
I think the 'rtc' device_type is legacy from OF.
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
2008-10-21 18:35 ` Kumar Gala
@ 2008-10-21 18:39 ` Scott Wood
0 siblings, 0 replies; 6+ messages in thread
From: Scott Wood @ 2008-10-21 18:39 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Kumar Gala wrote:
> On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:
>> Why are we adding more device_types?
>
> I think the 'rtc' device_type is legacy from OF.
Yes, and it advertises a run-time service that we do not and cannot
support. We should not have it in flat trees.
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
2008-10-21 18:23 ` Scott Wood
2008-10-21 18:35 ` Kumar Gala
@ 2008-10-21 18:41 ` Anton Vorontsov
1 sibling, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2008-10-21 18:41 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Tue, Oct 21, 2008 at 01:23:44PM -0500, Scott Wood wrote:
> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > index 5cedf37..7fc5414 100644
> > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > @@ -83,6 +83,14 @@
> > interrupts = <15 0x8>;
> > interrupt-parent = <&ipic>;
> > dfsrr;
> > +
> > + rtc@68 {
> > + device_type = "rtc";
> > + compatible = "dallas,ds1339";
> > + reg = <0x68>;
> > + interrupts = <18 0x8>;
> > + interrupt-parent = <&ipic>;
> > + };
>
> Why are we adding more device_types?
It seems that CHRP is using the device_type for rtc devices, which
means that real OF also provide it. But I guess we don't need it,
right? Then we should cleanup all the boards.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-10-21 18:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-17 18:56 [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards Anton Vorontsov
2008-10-21 4:39 ` Kumar Gala
2008-10-21 18:23 ` Scott Wood
2008-10-21 18:35 ` Kumar Gala
2008-10-21 18:39 ` Scott Wood
2008-10-21 18:41 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).