* [PATCH] powerpc: remove unused variable from pci_dlpar.c
@ 2008-11-03 7:07 Stephen Rothwell
2008-11-03 7:26 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-11-03 7:07 UTC (permalink / raw)
To: pauus; +Cc: ppc-dev
And get rid of this build warning:
arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
This is one of the very few warnings left in a ppc64_defconfig build and
getting rid of it will make it easier to see future introduced ones (in
fact this was introduced very recently).
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/platforms/pseries/pci_dlpar.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
This patch is against Linus' tree and so could go into 2.6.28 if you
think it should. This is also fixed by one of Ben's ominbus patches
(http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
upstream merge.
diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
index 31481dc..7190493 100644
--- a/arch/powerpc/platforms/pseries/pci_dlpar.c
+++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
@@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
{
struct pci_controller *phb;
int primary;
- struct pci_bus *b;
primary = list_empty(&hose_list);
phb = pcibios_alloc_controller(dn);
--
1.5.6.5
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: remove unused variable from pci_dlpar.c
2008-11-03 7:07 [PATCH] powerpc: remove unused variable from pci_dlpar.c Stephen Rothwell
@ 2008-11-03 7:26 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-11-03 7:26 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: ppc-dev, pauus
On Mon, 2008-11-03 at 18:07 +1100, Stephen Rothwell wrote:
> And get rid of this build warning:
>
> arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
> arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
>
> This is one of the very few warnings left in a ppc64_defconfig build and
> getting rid of it will make it easier to see future introduced ones (in
> fact this was introduced very recently).
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
Ack.
> arch/powerpc/platforms/pseries/pci_dlpar.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> This patch is against Linus' tree and so could go into 2.6.28 if you
> think it should. This is also fixed by one of Ben's ominbus patches
> (http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
> upstream merge.
>
> diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
> index 31481dc..7190493 100644
> --- a/arch/powerpc/platforms/pseries/pci_dlpar.c
> +++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
> @@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
> {
> struct pci_controller *phb;
> int primary;
> - struct pci_bus *b;
>
> primary = list_empty(&hose_list);
> phb = pcibios_alloc_controller(dn);
> --
> 1.5.6.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] powerpc: remove unused variable from pci_dlpar.c
@ 2008-11-03 7:18 Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-11-03 7:18 UTC (permalink / raw)
To: paulus; +Cc: ppc-dev
And get rid of this build warning:
arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
This is one of the very few warnings left in a ppc64_defconfig build and
getting rid of it will make it easier to see future introduced ones (in
fact this was introduced very recently).
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/platforms/pseries/pci_dlpar.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
[Resent to get Paul's address right and add cc to Ben]
This patch is against Linus' tree and so could go into 2.6.28 if you
think it should. This is also fixed by one of Ben's ominbus patches
(http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
upstream merge.
diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
index 31481dc..7190493 100644
--- a/arch/powerpc/platforms/pseries/pci_dlpar.c
+++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
@@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
{
struct pci_controller *phb;
int primary;
- struct pci_bus *b;
primary = list_empty(&hose_list);
phb = pcibios_alloc_controller(dn);
--
1.5.6.5
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-03 7:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-03 7:07 [PATCH] powerpc: remove unused variable from pci_dlpar.c Stephen Rothwell
2008-11-03 7:26 ` Benjamin Herrenschmidt
2008-11-03 7:18 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).