* [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support
@ 2009-03-19 15:52 Anton Vorontsov
2009-03-19 15:56 ` Andy Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Anton Vorontsov @ 2009-03-19 15:52 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Andy Fleming, linuxppc-dev
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
driver now refuses to probe TBI MDIO buses as it doesn't know about
"fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
-ENODEV status.
Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
MDIO buses.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/net/fsl_pq_mdio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b0ce144..6be36b9 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -321,6 +321,7 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev,
dev_set_drvdata(&ofdev->dev, new_bus);
if (of_device_is_compatible(np, "fsl,gianfar-mdio") ||
+ of_device_is_compatible(np, "fsl,gianfar-tbi") ||
of_device_is_compatible(np, "gianfar")) {
#ifdef CONFIG_GIANFAR
tbipa = get_gfar_tbipa(regs);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support
2009-03-19 15:52 [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support Anton Vorontsov
@ 2009-03-19 15:56 ` Andy Fleming
2009-03-21 20:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andy Fleming @ 2009-03-19 15:56 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev, netdev, David Miller
On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:
> commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
> and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
> driver now refuses to probe TBI MDIO buses as it doesn't know about
> "fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
> -ENODEV status.
>
> Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
> MDIO buses.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Andy Fleming <afleming@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support
2009-03-19 15:56 ` Andy Fleming
@ 2009-03-21 20:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-03-21 20:30 UTC (permalink / raw)
To: afleming; +Cc: netdev, linuxppc-dev
From: Andy Fleming <afleming@freescale.com>
Date: Thu, 19 Mar 2009 10:56:59 -0500
>
> On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:
>
> > commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
> > and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
...
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> Acked-by: Andy Fleming <afleming@freescale.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-21 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19 15:52 [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support Anton Vorontsov
2009-03-19 15:56 ` Andy Fleming
2009-03-21 20:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).