* [PATCH 1/2] Make dtstruct variable to be 8 byte aligned
@ 2009-08-10 14:13 M. Mohan Kumar
2009-08-12 23:25 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: M. Mohan Kumar @ 2009-08-10 14:13 UTC (permalink / raw)
To: horms, kexec; +Cc: linuxppc-dev, nhorman, miltonm
[PATCH 1/2] Make dtstruct variable to be 8 byte aligned
kexec is creating a version 3 device tree to be backwards compatible. This
version of the struct has 8-byte alignment for properties whose value is 8 or
more bytes. As the code directly checks the pointer when deciding to add the
alignment word, the struct memory must start on an 8 byte boundary. Force the
dtstruct variable to be always 8 bytes aligned.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
kexec/arch/ppc64/fs2dt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kexec/arch/ppc64/fs2dt.c b/kexec/arch/ppc64/fs2dt.c
index 1f551fd..b01ff86 100644
--- a/kexec/arch/ppc64/fs2dt.c
+++ b/kexec/arch/ppc64/fs2dt.c
@@ -41,7 +41,7 @@
static char pathname[MAXPATH], *pathstart;
static char propnames[NAMESPACE] = { 0 };
-static unsigned dtstruct[TREEWORDS], *dt;
+static unsigned dtstruct[TREEWORDS] __attribute__ ((aligned (8))), *dt;
static unsigned long long mem_rsrv[2*MEMRESERVE] = { 0, 0 };
static int crash_param = 0;
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Make dtstruct variable to be 8 byte aligned
2009-08-10 14:13 [PATCH 1/2] Make dtstruct variable to be 8 byte aligned M. Mohan Kumar
@ 2009-08-12 23:25 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2009-08-12 23:25 UTC (permalink / raw)
To: M. Mohan Kumar; +Cc: linuxppc-dev, nhorman, kexec, miltonm
On Mon, Aug 10, 2009 at 07:43:51PM +0530, M. Mohan Kumar wrote:
> [PATCH 1/2] Make dtstruct variable to be 8 byte aligned
>
> kexec is creating a version 3 device tree to be backwards compatible. This
> version of the struct has 8-byte alignment for properties whose value is 8 or
> more bytes. As the code directly checks the pointer when deciding to add the
> alignment word, the struct memory must start on an 8 byte boundary. Force the
> dtstruct variable to be always 8 bytes aligned.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-13 0:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-10 14:13 [PATCH 1/2] Make dtstruct variable to be 8 byte aligned M. Mohan Kumar
2009-08-12 23:25 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).